[PATCH 1/4] libucil: fix some memory leaks

Bug #656229 reported by Kamil Dudka on 2010-10-07
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Arne Caspari

Bug Description

Thanks in advance for considering the patch!

Kamil Dudka (kdudka) wrote :
Arne Caspari (arne-datafloater) wrote :

I will be on vacation through 18. October and will review this patchset when I return. Thank you very much for your efforts!

Azamat (shakhimardanov) wrote :

Hi all,
I am Azamat. I am new here. Currently using unicap for some vision projects.
In new releases after 0.95 there seems to be some "bug".
In unicap.h and unicap.c in unicap_data_buffer_private there is a member variable called "private".
Since it is reserved keyword for C++, both gcc/g++-4.3.2 complain on debian and I get complaints (not sure though why gcc).
Since in some projects I need to mix C and C++ this is a little bit a problem.
I renamed that variable in both files to sth else. Now everything is fine.
Here is a -p0 level patch file:

Azamat (shakhimardanov) wrote :

Also a question: why do new releases (after 0.95) need to register udev rules?


Arne Caspari (arne-datafloater) wrote :

Hi Azamat,

please post general questions on the forum:

It registers udev rules since one driver ( the euvccam_cpi driver ) uses usbfs to talk with the camera. The udev rule sets the permissions correctly so that a non-root user can access the cameras.

Arne Caspari (arne-datafloater) wrote :

I reviewed the patch and included the changes in BZR trunk.

Changed in unicap:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Arne Caspari (arne-datafloater)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers