[PATCH] add missing lock/unlock in unicapgtk_video_display_set_pause()

Bug #646428 reported by Kamil Dudka
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unicap
Fix Committed
Medium
Arne Caspari

Bug Description

The attached patch adds missing lock/unlock in unicapgtk_video_display_set_pause(). We have a crasher bug in our bugzilla, reported half a year ago:

https://bugzilla.redhat.com/show_bug.cgi?id=532289

Looking at the code, I discovered that the place where the crash occurs is the only place where ugtk->backend_get_image_data() is called without calling ugtk->backend_lock() first. As long as I understand the code, this must be a mistake. However I haven't been successful in reproducing the crash myself and the fix is not yet confirmed by users.

Could you please have a look at the attached patch? Thanks in advance!

Revision history for this message
Kamil Dudka (kdudka) wrote :
Changed in unicap:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Arne Caspari (arne-datafloater)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.