[Regression] Route status not set correctly when simulating a route
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
uNav |
Fix Released
|
Critical
|
costales |
Bug Description
I have noticed a regression with the route status. This is reproducible in trunk and the store version. So it was not newly introduced in this development cycle.
Steps to reproduce bug:
First add the following line of code, onRouteStateCha
1. Press Simulate Route and choose Point A
2. Now choose Point B
Notice the following output of routeState in the log files,
qml: Route Status: simulate_
qml: Route Status: no
As you can see it sets the route status to "no", which is incorrect! Now open any page like the Settings Page or the route page and then return to the map by pressing the back button. At this point, notice the output,
qml: Route Status: simulate_done_bike
The reason this bug is critical is because, the first time you open the route page after simulating a route, you don't see a "Cancel simulation" button since the route state is "no". Only when you open the route page a second time, you see the "Cancel button".
This bug is even more serious in the new menu navigation strucuture since the so called "destination header action" is not visible when you simulate a route.
Related branches
- Nekhelesh Ramananthan: Approve
-
Diff: 2295 lines (+460/-1572)14 files modifiednav/img/header/center_onpos.svg (+0/-167)
nav/img/header/center_onpos_light.svg (+0/-167)
nav/img/header/destination.svg (+0/-255)
nav/img/header/gps_off.svg (+0/-161)
nav/img/header/nav-actions-transparent.svg (+195/-0)
nav/img/header/nav-actions.svg (+195/-0)
nav/img/header/transparent_center_onpos.svg (+0/-167)
nav/img/header/transparent_center_onpos_light.svg (+0/-167)
nav/img/header/transparent_destination.svg (+0/-255)
nav/img/header/transparent_gps_off.svg (+0/-168)
nav/index.html (+8/-1)
nav/locales/unav.pot (+52/-54)
qml/Main.qml (+8/-8)
qml/js/PoiCategories.js (+2/-2)
- Nekhelesh Ramananthan: Pending requested
-
Diff: 1698 lines (+26/-1530)11 files modifiednav/img/header/center_onpos.svg (+0/-167)
nav/img/header/center_onpos_light.svg (+0/-167)
nav/img/header/destination.svg (+0/-255)
nav/img/header/gps_off.svg (+0/-161)
nav/img/header/transparent_center_onpos.svg (+0/-167)
nav/img/header/transparent_center_onpos_light.svg (+0/-167)
nav/img/header/transparent_destination.svg (+0/-255)
nav/img/header/transparent_gps_off.svg (+0/-168)
nav/index.html (+8/-1)
qml/Main.qml (+6/-10)
qml/js/PoiCategories.js (+12/-12)
Changed in unav: | |
status: | Triaged → In Progress |
Changed in unav: | |
status: | In Progress → Fix Committed |
Changed in unav: | |
status: | Fix Committed → Fix Released |