UI Cookiecutter

NG details view route should have different name

Bug #1641250 reported by Cindy Lu
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate Dashboard
Fix Released
Critical
Unassigned
Magnum UI
Fix Released
Critical
Shu Muto
Magnum UI pike-1 "p1"
OpenStack Dashboard (Horizon)
Fix Released
Low
Cindy Lu
OpenStack Dashboard (Horizon) pike-1
UI Cookiecutter
Fix Released
Critical
Shu Muto
Zun UI
Fix Released
Critical
Shu Muto
senlin-dashboard
Fix Released
Undecided
Shu Muto

Bug Description

https://github.com/openstack/horizon/blob/master/openstack_dashboard/static/app/core/core.module.js#L56

path includes the name "project" but detail views can also come from "admin" and "identity". Change the name.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/396800

Changed in horizon:
assignee: nobody → Cindy Lu (clu-m)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/396800
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=c73e1c8fa82c8059d0c8e8848413380ab6050ad5
Submitter: Jenkins
Branch: master

commit c73e1c8fa82c8059d0c8e8848413380ab6050ad5
Author: Cindy Lu <email address hidden>
Date: Fri Nov 11 16:32:13 2016 -0800

    NG details view route should not be '/project/...'

    Right now the route includes the name 'project'
    but we may have details view for 'identity' and
    'admin' too, so it should be more general.

    Picked just 'ngdetails' instead and moved this out as a
    constant. Since this constant needs to be used
    by the config blocks, I moved it out into its own
    constant module.

    Change-Id: I7603250dd70eb40568aa74be2ae4821ee8fcefcc
    Closes-Bug: #1641250

Changed in horizon:
status: In Progress → Fix Released
Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
milestone: none → pike-1
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/445411

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (stable/ocata)

Change abandoned by Rob Cresswell (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/445411

Shu Muto (shu-mutou)
Changed in magnum-ui:
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → Shu Muto (shu-mutou)
Changed in senlin-dashboard:
status: New → Confirmed
assignee: nobody → Shu Muto (shu-mutou)
Changed in zun-ui:
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → Shu Muto (shu-mutou)
Changed in magnum-ui:
milestone: none → pike-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to zun-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/447880

Changed in zun-ui:
status: Confirmed → In Progress
Shu Muto (shu-mutou)
Changed in ui-cookiecutter:
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → Shu Muto (shu-mutou)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ui-cookiecutter (master)

Fix proposed to branch: master
Review: https://review.openstack.org/447890

Changed in ui-cookiecutter:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to senlin-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/447910

Changed in senlin-dashboard:
status: Confirmed → In Progress
Changed in magnum-ui:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to magnum-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/447911

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to zun-ui (master)

Reviewed: https://review.openstack.org/447880
Committed: https://git.openstack.org/cgit/openstack/zun-ui/commit/?id=f44f68aa9f6be43931a12ccd56514dd73ac96d75
Submitter: Jenkins
Branch: master

commit f44f68aa9f6be43931a12ccd56514dd73ac96d75
Author: Shu Muto <email address hidden>
Date: Tue Mar 21 15:34:09 2017 +0900

    Use detailRoute constant for path of details view

    This patch replaces hard coded "project/ngdetails/" for path of
    details view to constant using "horizon.app.core.detailRoute".

    Change-Id: Ia238f0a4b6df45f08673e4d41b24c6005d22ef00
    Closes-Bug: #1641250

Changed in zun-ui:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to senlin-dashboard (master)

Reviewed: https://review.openstack.org/447910
Committed: https://git.openstack.org/cgit/openstack/senlin-dashboard/commit/?id=2c0d48e05a6b647c045a09b83d9fe66d258fd6ff
Submitter: Jenkins
Branch: master

commit 2c0d48e05a6b647c045a09b83d9fe66d258fd6ff
Author: Shu Muto <email address hidden>
Date: Tue Mar 21 16:05:05 2017 +0900

    Use detailRoute constant for path of details view

    This patch replaces hard coded "project/ngdetails/" for path of
    details view to constant using "horizon.app.core.detailRoute".

    Change-Id: I1697c87f9ea281ee4fa8963f96bb3b66b9d6cca5
    Closes-Bug: #1641250

Changed in senlin-dashboard:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to magnum-ui (master)

Reviewed: https://review.openstack.org/447911
Committed: https://git.openstack.org/cgit/openstack/magnum-ui/commit/?id=cac8f9e0943ed6d529473cae178509e4a7d77af2
Submitter: Jenkins
Branch: master

commit cac8f9e0943ed6d529473cae178509e4a7d77af2
Author: Shu Muto <email address hidden>
Date: Tue Mar 21 16:19:56 2017 +0900

    Use detailRoute constant for path of details view

    This patch replaces hard coded "project/ngdetails/" for path of
    details view to constant using "horizon.app.core.detailRoute".

    Change-Id: Ia0b0c1db3d2df6c3f459d1254deb974e71824bf7
    Closes-Bug: #1641250

Changed in magnum-ui:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ui-cookiecutter (master)

Reviewed: https://review.openstack.org/447890
Committed: https://git.openstack.org/cgit/openstack/ui-cookiecutter/commit/?id=6e9c342e91e12f1a2985d91eb82d4f5457a17792
Submitter: Jenkins
Branch: master

commit 6e9c342e91e12f1a2985d91eb82d4f5457a17792
Author: Shu Muto <email address hidden>
Date: Tue Mar 21 15:49:40 2017 +0900

    Use detailRoute constant for path of details view

    This patch replaces hard coded "project/ngdetails/" for path of
    details view to constant using "horizon.app.core.detailRoute".

    Change-Id: I57232feb09b38adc436b2da2de9bce445ba35906
    Closes-Bug: #1641250

Changed in ui-cookiecutter:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.0.0b1

This issue was fixed in the openstack/horizon 12.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/magnum-ui 3.0.0

This issue was fixed in the openstack/magnum-ui 3.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/senlin-dashboard 0.7.0

This issue was fixed in the openstack/senlin-dashboard 0.7.0 release.

Graham Hayes (grahamhayes)
Changed in designate-dashboard:
importance: Undecided → Critical
status: New → In Progress
Revision history for this message
Dr. Jens Harbott (j-harbott) wrote :

For designate-dashboard this is a duplicate of https://bugs.launchpad.net/designate-dashboard/+bug/1715417 which should be already fixed.

Graham Hayes (grahamhayes)
Changed in designate-dashboard:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.