refresh_possible_transports should catch more exceptions

Bug #801776 reported by Max Bowsher
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Distributed Development
Fix Released
High
Vincent Ladeuil

Bug Description

Traceback (most recent call last):
  File "/srv/package-import.canonical.com/new/scripts/import_package.py", line 1155, in <module>
    only_before=options.only_before))
  File "/srv/package-import.canonical.com/new/scripts/import_package.py", line 1071, in main
    bstore, push, possible_transports=possible_transports)
  File "/srv/package-import.canonical.com/new/scripts/import_package.py", line 606, in import_package
    possible_transports=possible_transports)
  File "/srv/package-import.canonical.com/new/scripts/import_package.py", line 414, in make_db_set
    icommon.refresh_possible_transports(possible_transports)
  File "/srv/package-import.canonical.com/new/scripts/udd/icommon.py", line 1783, in refresh_possible_transports
    t.has('file-that-does-not-exist')
  File "/var/lib/python-support/python2.5/bzrlib/transport/http/_pycurl.py", line 157, in has
    self._curl_perform(curl, header)
  File "/var/lib/python-support/python2.5/bzrlib/transport/http/_pycurl.py", line 388, in _curl_perform
    'curl connection error (%s)\non %s' % (e[1], url))
bzrlib.errors.ConnectionError: Connection error: curl connection error (Peer closed the TLS connection)
on https://launchpadlibrarian.net/59057562/file-that-does-not-exist

Related branches

Revision history for this message
Max Bowsher (maxb) wrote :

I've seen this a few times as a spurious failure. Most recently from the qbittorrent import.

Revision history for this message
Vincent Ladeuil (vila) wrote :

The root cause is that refresh_possible_transports only catch socket.error while bzrlib may have raise other higer level exceptions which also represent a connection loss (in which case the transport is not reusable and should just be silently discarded).

Changed in udd:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Vincent Ladeuil (vila)
summary: - refresh_possible_transports mysteriously talking to the librarian and
- failing hard
+ refresh_possible_transports should catch more exceptions
Revision history for this message
Vincent Ladeuil (vila) wrote :

I encountered the same issue while re-trying the chromium-browser import which seems fine otherwise (but takes 24 hours or more to finish).

Vincent Ladeuil (vila)
Changed in udd:
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.