Improve the code for creation of the dput.cf file
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu CI Engine |
Confirmed
|
High
|
Francis Ginther |
Bug Description
This is a follow up to https:/
> > > === modified file 'branch-source-
> builder/
> >
> > > - cmd = ["dput", ppa,
> > > + cmd = ["dput", "-u", "-c", "/tmp/dput.cf", ppa,
> > > "{}_{}_
> version_
> >
> > I'm being a little over-protective, but as per: "/tmp/dput.cf" - Seems
> > like we should either make a constant for that, or (and I don't know the
> > code structure/flow, have pass this value down to the function via
> > upload_package.py
>
> I'll leave this for Francis to comment, he implemented that part and knows the
> constraints better than I do.
A constant is more appropriate and will make it easier if we need to relocate the file. And when thinking about the proper location, /srv/$service_
Changed in uci-engine: | |
milestone: | none → phase-0.5 |