We do not run pyflakes or dep8 on our charms

[Evan]

We're not running pyflakes on our charms, and they have landmines:

  % pyflakes charms/precise/python-django/hooks/install
charms/precise/python-django/hooks/install:565: local variable 'django_admin_cmd' is assigned to but never used
charms/precise/python-django/hooks/install:613: undefined name 'vcs_clonse_dir'

[Chris Johnston (cjohnston)]

We need to work on getting everything that we change into the upstream
charms

On Mon, Feb 24, 2014 at 6:38 AM, Evan Dandrea <email address hidden>wrote:

> Public bug reported:
>
> We're not running pyflakes on our charms, and they have landmines:
>
> % pyflakes charms/precise/python-django/hooks/install
> charms/precise/python-django/hooks/install:565: local variable
> 'django_admin_cmd' is assigned to but never used
> charms/precise/python-django/hooks/install:613: undefined name
> 'vcs_clonse_dir'
>
> ** Affects: ubuntu-ci-services-itself
> Importance: Undecided
> Status: New
>
>
> ** Tags: airline
>
> --
> You received this bug notification because you are subscribed to Ubuntu
> CI Services.
> https://bugs.launchpad.net/bugs/1284076
>
> Title:
> We do not run pyflakes or dep8 on our charms
>
> Status in Ubuntu CI Services:
> New
>
> Bug description:
> We're not running pyflakes on our charms, and they have landmines:
>
> % pyflakes charms/precise/python-django/hooks/install
> charms/precise/python-django/hooks/install:565: local variable
> 'django_admin_cmd' is assigned to but never used
> charms/precise/python-django/hooks/install:613: undefined name
> 'vcs_clonse_dir'
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu-ci-services-itself/+bug/1284076/+subscriptions
>

--
Chris Johnston <email address hidden>
Software Engineer - CI Engineering Team
Canonical Ltd.
www.ubuntu.com

[Evan (ev)]

Chris, I absolutely agree, though we should keep that push to the longer term.