cmd_client: unlink doesn't work as expected, has bad help text.

Bug #364802 reported by Rick McBride on 2009-04-21
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Medium
Lucio Torre
Ubuntu One Servers
Medium
Lucio Torre

Bug Description

so... unlink doesn't work as expected. I get the following when trying to remove a directory. I get that it's failing because the directory is non-empty, but it probably shouldn't traceback like that.

Additionally, it would be really sweet if I could wildcard (so that I could empty the directory out easily).

As noted below, the help text for unlink appears to be identical to that for "hash".

/ $ unlink "1238440128.1"
Traceback (most recent call last):
  File "../../trunk/utilities/cmd_client.py", line 151, in decorator
    function(*args, **kwargs)
  File "../../trunk/utilities/cmd_client.py", line 579, in do_unlink
    self.unlink(node_id)
  File "../../trunk/utilities/cmd_client.py", line 332, in unlink
    return self.defer_from_thread(_unlink)
  File "../../trunk/utilities/cmd_client.py", line 218, in defer_from_thread
    result.raiseException()
  File "/usr/lib/python2.6/dist-packages/twisted/python/failure.py", line 326, in raiseException
    raise self.type, self.value, self.tb
StorageRequestError: NOT_EMPTY
/ $ help unlink
Print the hash of filename.
/ $ help

Documented commands (type help <topic>):
========================================
EOF connect_ssl hash move quit shares
cat disconnect ls oauth_from_keyring_maybe root shell
cd dummy_auth mkdir oauth_from_token rput status
connect get mkfile put set_share unlink

Undocumented commands:
======================
help

/ $ help hash
Print the hash of filename.
/ $ help unlink
Print the hash of filename.

Rick McBride (rmcbride) on 2009-04-21
Changed in ubunet:
importance: Undecided → High
milestone: none → beta1

Rick McBride wrote:
> Private bug reported:
>
> so... unlink doesn't work as expected. I get the following when trying
> to remove a directory. I get that it's failing because the directory is
> non-empty, but it probably shouldn't traceback like that.
>

it does what its supposed to do and what you expect it will do. it just
doesnt show it nicely. so lets keep this bug to improve the error
handling in cmd_client (all operations that fail, even in reasonable
ways) show that kind of errors.

Lucio.

Lucio Torre (lucio.torre) wrote :

Lucio Torre wrote:
> Rick McBride wrote:
>> Private bug reported:
>>
>> so... unlink doesn't work as expected. I get the following when trying
>> to remove a directory. I get that it's failing because the directory is
>> non-empty, but it probably shouldn't traceback like that.
>>
>
> it does what its supposed to do and what you expect it will do. it just
> doesnt show it nicely. so lets keep this bug to improve the error
> handling in cmd_client (all operations that fail, even in reasonable
> ways) show that kind of errors.
>
> Lucio.
>
ah, and yes, docstring need some improvement.

Lucio.

tags: added: chicharra
Rick McBride (rmcbride) on 2009-04-28
Changed in ubuntuone-client:
assignee: nobody → lucio.torre
importance: Undecided → High
status: New → Triaged
Changed in ubunet:
status: New → Triaged
Elliot Murphy (statik) wrote :

closing out the duplicate bug task.

Changed in ubunet:
importance: High → Undecided
milestone: beta1 → none
status: Triaged → Invalid
Elliot Murphy (statik) on 2009-04-29
Changed in ubuntuone-client:
milestone: none → beta2
Rick McBride (rmcbride) on 2009-05-11
visibility: private → public
Changed in ubuntuone-client:
milestone: beta2 → later
Elliot Murphy (statik) on 2009-07-07
tags: added: ubuntuone-love
Guillermo Gonzalez (verterok) wrote :

cmd_client isn't in ubuntuone-client (yet)

Changed in ubunet:
assignee: nobody → Lucio Torre (lucio.torre)
importance: Undecided → High
milestone: none → later
status: Invalid → Triaged
Changed in ubuntuone-client:
status: Triaged → Invalid
Changed in ubunet:
assignee: Lucio Torre (lucio.torre) → John Lenton (chipaca)
John Lenton (chipaca) on 2009-12-22
Changed in ubuntuone-servers:
assignee: John Lenton (chipaca) → Lucio Torre (lucio.torre)
tags: added: chicharra-maverick
Changed in ubuntuone-servers:
importance: High → Medium
Changed in ubuntuone-client:
importance: High → Medium
tags: added: chicharra-natty
removed: chicharra-maverick
tags: added: chicharra-oneiric
removed: chicharra-natty
dobey (dobey) on 2011-06-23
Changed in ubuntuone-client:
milestone: later → none
Changed in ubuntuone-servers:
milestone: later → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers