daemon started from launchd crashes with uncaught exception

[Mike McCracken]

Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: +[FSEventsCommSocketServer addConnectedClient:]: unrecognized selector sent to class 0x100025b00
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: caught exception: NSInvalidArgumentException : +[FSEventsCommSocketServer addConnectedClient:]: unrecognized selector sent to class 0x100025b00
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 0 CoreFoundation 0x00007fff9602af56 __exceptionPreprocess + 198
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 1 libobjc.A.dylib 0x00007fff89ef3dee objc_exception_throw + 43
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 2 CoreFoundation 0x00007fff960b70fe +[NSObject doesNotRecognizeSelector:] + 190
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 3 CoreFoundation 0x00007fff96017e23 ___forwarding___ + 371
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 4 CoreFoundation 0x00007fff96017c38 _CF_forwarding_prep_0 + 232
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 5 com.ubuntu.one.fsevents 0x0000000100007bd7 SocketServerCallback + 87
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 6 CoreFoundation 0x00007fff95fe10c4 __CFSocketPerformV0 + 980
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 7 CoreFoundation 0x00007fff95f994f1 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 17
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 8 CoreFoundation 0x00007fff95f98d5d __CFRunLoopDoSources0 + 253
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 9 CoreFoundation 0x00007fff95fbfb49 __CFRunLoopRun + 905
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 10 CoreFoundation 0x00007fff95fbf486 CFRunLoopRunSpecific + 230
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 11 Foundation 0x00007fff95c29f7b -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 267
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 12 Foundation 0x00007fff95c29e67 -[NSRunLoop(NSRunLoop) run] + 62
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 13 com.ubuntu.one.fsevents 0x000000010000af68 -[FSEventsDaemon application:runWithArguments:] + 1032
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 14 com.ubuntu.one.fsevents 0x000000010000b645 -[DDCliApplication runWithClass:] + 357
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 15 com.ubuntu.one.fsevents 0x000000010000b9b2 DDCliAppRunWithClass + 114
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 16 com.ubuntu.one.fsevents 0x0000000100001eb8 main + 56
Aug 27 23:02:18 mba com.ubuntu.one.fsevents[87262]: 17 com.ubuntu.one.fsevents 0x0000000100001e74 start + 52

[Mike McCracken (mikemc)]

Issue was putting 'self' in the socket context while in a class method, where self is the class.

Debugging this was confusing because FSEventsCommSocketServer has a copy and pasted serverStartedWithHandle from its superclass. I'm not sure why that's there. Of course I ended up changing the method in the superclass, because that's the file where the callback is defined, but that didn't fix the bug.