Latest dev-tools revision breaks tests

Bug #1037689 reported by dobey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Fix Released
Undecided
dobey
ubuntuone-dev-tools
Triaged
Undecided
Unassigned

Bug Description

The latest ubuntuone-dev-tools revision introduces the use of unicode_literals in ubuntuone.devtools.runners and thus causes the override of $HOME to be a unicode object instead of str (bytes) in python2. In ubuntuone-client this now results in the following error:

  ModifySharesSubscriptionTests
    test_subscribe_share ... Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/twisted/internet/defer.py", line 1039, in _inlineCallbacks
    result = g.send(result)
  File "/build/buildd/ubuntuone-client-4.1+r1290/contrib/testing/testcase.py", line 409, in setUp
    config.get_user_config(config_file=self.config_file)
  File "/build/buildd/ubuntuone-client-4.1+r1290/ubuntuone/syncdaemon/config.py", line 197, in get_user_config
    _user_config = _Config(config_file, config_files)
  File "/build/buildd/ubuntuone-client-4.1+r1290/ubuntuone/syncdaemon/config.py", line 289, in __init__
    self.default = self._load_defaults(config_files)
  File "/build/buildd/ubuntuone-client-4.1+r1290/ubuntuone/syncdaemon/config.py", line 301, in _load_defaults
    cp.parse_all()
  File "/build/buildd/ubuntuone-client-4.1+r1290/ubuntuone/syncdaemon/config.py", line 234, in parse_all
    super(SyncDaemonConfigParser, self).parse_all()
  File "/usr/lib/pymodules/python2.7/configglue/inischema/attributed.py", line 65, in parse_all
    self.parse(section, option)
  File "/usr/lib/pymodules/python2.7/configglue/inischema/typed.py", line 92, in parse
    value.value = value.parser(value.value, *args)
  File "/build/buildd/ubuntuone-client-4.1+r1290/ubuntuone/syncdaemon/config.py", line 103, in home_dir_parser
    result = expand_user(path)
  File "/build/buildd/ubuntuone-client-4.1+r1290/ubuntuone/platform/__init__.py", line 66, in expand_user
    assert isinstance(result, str)
exceptions.AssertionError:

There is actually a small issue in ubuntuone-client's default test case as well which makes this more of an issue, so I am reporting it in both places.

Related branches

dobey (dobey)
Changed in ubuntuone-client:
status: New → Triaged
assignee: nobody → Rodney Dawes (dobey)
Changed in ubuntuone-client:
status: Triaged → Fix Committed
dobey (dobey)
Changed in ubuntuone-client:
status: Fix Committed → Fix Released
dobey (dobey)
Changed in ubuntuone-dev-tools:
assignee: Rodney Dawes (dobey) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.