Qt control panel says kilobits per second, means kibibytes per second

Bug #985484 reported by Roman Yepishev on 2012-04-19
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ubuntu One Control Panel
Status tracked in Trunk
Stable-3-0
Undecided
Unassigned
Stable-4-0
Undecided
Unassigned
Trunk
High
Roberto Alsina
ubuntuone-control-panel (Ubuntu)
High
Ubuntu One Client Engineering team
Nominated for Precise by Roberto Alsina
Quantal
High
Ubuntu One Client Engineering team

Bug Description

The old control panel had KiB/s label, the new control panel says "kilobits per second". The backend expects KiB/s and the config file being written specifies the values in bytes per second.

STR:

1. Set 100 "kilobits per second" in the control panel
2. Open ~/.config/ubuntuone/syncdaemon.conf

Actual results:
The value of the changed parameter is 102400 (100 * 1024).

The label is wrong.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: ubuntuone-control-panel-qt 3.0.0-0ubuntu1
ProcVersionSignature: Ubuntu 3.2.0-23.36-generic 3.2.14
Uname: Linux 3.2.0-23-generic x86_64
ApportVersion: 2.0.1-0ubuntu4
Architecture: amd64
Date: Thu Apr 19 11:33:02 2012
InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Alpha amd64 (20120225)
PackageArchitecture: all
SourcePackage: ubuntuone-control-panel
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

Roman Yepishev (rye) wrote :
Rick McBride (rmcbride) on 2012-04-20
Changed in ubuntuone-control-panel:
assignee: nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+)
Changed in ubuntuone-control-panel (Ubuntu):
assignee: nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+)
Changed in ubuntuone-control-panel:
status: New → Confirmed
Changed in ubuntuone-control-panel (Ubuntu):
status: New → Confirmed
Leo Arias (elopio) wrote :

I reported bug #848529 because we should use binary prefixes everywhere.
---
Ubuntu Bug Squad volunteer triager
http://wiki.ubuntu.com/BugSquad

Changed in ubuntuone-control-panel:
status: Confirmed → Triaged
Changed in ubuntuone-control-panel (Ubuntu):
status: Confirmed → Triaged
tags: added: desktop+
Roberto Alsina (ralsina) on 2012-05-14
Changed in ubuntuone-control-panel:
importance: Undecided → High
Changed in ubuntuone-control-panel (Ubuntu):
importance: Undecided → High
Roberto Alsina (ralsina) wrote :

I have done a branch to get rid of those labels, and provide units inside the spinboxes. I think this:

1) Looks better
2) Is much more compact, which helps with our bugs about translated strings being overly long

However, it's a change in copy, so I want some feedback from design.

Attached are before/after pictures.

Roberto Alsina (ralsina) wrote :
Alejandro J. Cura (alecu) wrote :

Looks much nicer!

Robert Grant (rtgrant) wrote :

+1 on the proposed change, looks much nicer and will definitely be better for localisation.

Could we also make the increments more meaningful? For example:

* No limit / Automatic (default option)
* 1024 kbps (fast connections)
* 512 kbps (medium fast connections)
* 256 kbps (slow connections)
* 128 kbps (dial up connection)

Not sure about the actual numbers, but if we at least could avoid having -1 in there?

Roberto Alsina (ralsina) wrote :

Agreed about the -1 being weird. Any suggestions on what to replace it with? A 0?

So 0 + unchecked means unlimited?

A ∞ ? Too nerdy? ;-)

Mike McCracken (mikemc) wrote :

ralsina -- my suggestion might be mac-ish, I'm still getting used to the ubuntu aesthetic, but FWIW here's what I'd do:

There shouldn't be a need for a number that means unlimited -- just unchecked means unlimited.
If the box is unchecked, the selection box should be disabled, and the number in the box replaced with something like "unlimited" or "no limit". again, I don't know qt well, but in osx cocoa, that'd be grey text so you know you can't edit it, and the buttons of the text box would also be disabled.

I like lisette's suggestion of giving people context for what limit they might want - but why do people usually limit this?
Do they actually want a choice like 'leave me enough bandwidth to watch youtube', or 'leave me enough bandwidth to browse the web quickly'? That means we'd need some idea of what bandwidth they have, and how much of it we need to leave them so they can do what they want...

This is getting a little complex, but I wonder how many people have a good idea what number they want in there, and what that'd mean. If we can give them a way to say what their goal is and figure it out for them, that'd be a big improvement IMO.
(It'd also be a big improvement over DB).

FINALLY, the holy grail is just to always do the right thing and not need a preference. Can we 'nice' our network traffic so it uses max bw unless some other app with higher priority is using it? That'll take some research but doesn't that sound like something that ought to be possible?

Leo Arias (elopio) on 2012-05-24
tags: added: u1-ux
tags: added: bandwidth units
dobey (dobey) on 2012-05-24
Changed in ubuntuone-control-panel:
status: Triaged → Fix Committed
Roberto Alsina (ralsina) on 2012-05-24
Changed in ubuntuone-control-panel (Ubuntu):
status: Triaged → Fix Committed
dobey (dobey) on 2012-05-24
Changed in ubuntuone-control-panel (Ubuntu):
status: Fix Committed → Triaged
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-control-panel - 3.99.0-0ubuntu1

---------------
ubuntuone-control-panel (3.99.0-0ubuntu1) quantal; urgency=low

  * New upstream release.
    - Improve upload/download limit UI. (LP: #847227, #985484)
    - Fix sorting of shares and folders. (LP: #1006385)
    - Use suggested path for server path comparisons. (LP: #1005574)
  * debian/control:
    - Update build dependencies in preparation for running tests during builds.
  * debian/watch:
    - Update to use stable-4-0 series for Quantal.
 -- Rodney Dawes <email address hidden> Wed, 20 Jun 2012 16:42:13 -0400

Changed in ubuntuone-control-panel (Ubuntu Quantal):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers