The app name is not passed to the webclient
Bug #952880 reported by
Manuel de la Peña
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Ubuntu One Control Panel | Status tracked in Trunk | |||||
Stable-3-0 |
Fix Released
|
Undecided
|
Unassigned | |||
Trunk |
Fix Released
|
Medium
|
Manuel de la Peña | |||
ubuntuone-control-panel (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Since all the sso libraries are application agnostic the application name has to be passed to the sso webclient so that its title is correctly displayed in the different dialogs that are spawned when there are either auth issues or ssl ones.
The code should be like:
self.wc = webclient_
The kwarg name can be removed since it will later be removed since it was added so that the code was backward compatible.
* PS the Ubuntu One Control Panel string is an example.
Related branches
lp:~mandel/ubuntuone-control-panel/add-app-name
- Natalia Bidart (community): Approve
- Diego Sarmentero (community): Approve
-
Diff: 43 lines (+7/-2)2 files modifiedubuntuone/controlpanel/tests/test_web_client.py (+5/-0)
ubuntuone/controlpanel/web_client.py (+2/-2)
Changed in ubuntuone-control-panel: | |
assignee: | nobody → Manuel de la Peña (mandel) |
Changed in ubuntuone-control-panel: | |
status: | Triaged → Fix Committed |
To post a comment you must log in.
This bug was fixed in the package ubuntuone- control- panel - 2.99.91-0ubuntu1
--------------- control- panel (2.99.91-0ubuntu1) precise; urgency=low
ubuntuone-
* New upstream release:
- Added the app name from ubuntu one to be used in the webclient
so that it is shown in the sso ui (LP: #952880).
- Added 'Computer to cloud' page to the wizard
(part of LP: #933697).
- Tweaked the title of the aforementioned page (LP: #888521).
- Added 'Cloud to computer' page to the initial wizard
(part of LP: #933697).
- Added a confirmation dialog to quit the wizard
(part of LP: #933697).
- Implemented a method to list the user's default folders in
every platform (part of LP: #933697).
- Apply new specification for tabbing navigation and tabbing style
(LP: #942020).
- Make the "Explore" buttons for folders be disabled (style-wise)
when the folder is not synched (LP: #949035).
- Removed first line from the man page for the qt control panel
so is detected as such and installed (LP: #948970).
- Added several tweaks to the UI stylesheet to avoid 'movements'
when focusing a button, and to remove the ugly border from the
twitter and facebook buttons.
- Enable platform-specific styling (LP: #953318).
- Arranged Tab ordering in folders tab according to guidelines
(LP: #950073).
- Enabled Qt translation engine so standard dialogs are translated
(LP: #951651).
- Switched to the native file chooser on Linux (LP: #947711).
- Fixed --alert and --switch-to tabname and updated --help and
manpage accordingly (LP: #940465).
- Don't hard-code the font sizes (LP: #942025, LP: #953062).
* Removed patches which were included upstream.
* debian/watch:
- Updated url to fetch tarball from latest milestone.
* debian/control:
- Bumped dependency versions on ubuntu-sso-client and ubuntuone-client to
2.99.91.
-- Natalia Bidart (nessita) <email address hidden> Wed, 21 Mar 2012 14:11:29 -0300