Ubuntu One Control Panel

The are lint errors when running suite on Precise

Bug #920640 reported by Natalia Bidart
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Control Panel
Status tracked in Trunk
Stable-3-0
Fix Released
Undecided
Unassigned
Ubuntu One Control Panel 2.99.3
Trunk
Fix Released
High
Natalia Bidart

Bug Description

== Python Lint Notices ==

ubuntuone/controlpanel/dbus_service.py:
    159: [E1002, ControlPanelBackend.__init__] Use of super on an old style class

ubuntuone/controlpanel/gui/gtk/gui.py:
    843: [E1101, DevicesPanel.on_devices_info_ready] Class 'style' has no 'bg' member
    843: [E1101, DevicesPanel.on_devices_info_ready] Class 'style' has no 'bg' member
    843: [E1101, DevicesPanel.on_devices_info_ready] Class 'style' has no 'bg' member
    843: [E1101, DevicesPanel.on_devices_info_ready] Class 'style' has no 'bg' member

ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py:
    62: [E1101, LoadingTestCase.test_fg_color] Class 'style' has no 'fg' member
    62: [E1101, LoadingTestCase.test_fg_color] Class 'style' has no 'fg' member
    62: [E1101, LoadingTestCase.test_fg_color] Class 'style' has no 'fg' member
    137: [E1101, LabelLoadingTestCase.test_fg_color] Class 'style' has no 'fg' member
    137: [E1101, LabelLoadingTestCase.test_fg_color] Class 'style' has no 'fg' member
    137: [E1101, LabelLoadingTestCase.test_fg_color] Class 'style' has no 'fg' member
    150: [E1101, LabelLoadingTestCase.test_fg_color_loading] Class 'style' has no 'fg' member
    150: [E1101, LabelLoadingTestCase.test_fg_color_loading] Class 'style' has no 'fg' member
    150: [E1101, LabelLoadingTestCase.test_fg_color_loading] Class 'style' has no 'fg' member
    152: [E1101, LabelLoadingTestCase.test_fg_color_loading] Class 'style' has no 'fg' member
    152: [E1101, LabelLoadingTestCase.test_fg_color_loading] Class 'style' has no 'fg' member
    152: [E1101, LabelLoadingTestCase.test_fg_color_loading] Class 'style' has no 'fg' member

ubuntuone/controlpanel/gui/gtk/widgets.py:
    251: [E1101, GreyableBin.do_realize] Class 'style' has no 'attach' member
    251: [E1101, GreyableBin.do_realize] Class 'style' has no 'attach' member
    251: [E1101, GreyableBin.do_realize] Class 'style' has no 'attach' member
    252: [E1101, GreyableBin.do_realize] Class 'style' has no 'set_background' member
    252: [E1101, GreyableBin.do_realize] Class 'style' has no 'set_background' member
    252: [E1101, GreyableBin.do_realize] Class 'style' has no 'set_background' member
    253: [E1101, GreyableBin.do_realize] Class 'style' has no 'set_background' member
    253: [E1101, GreyableBin.do_realize] Class 'style' has no 'set_background' member
    253: [E1101, GreyableBin.do_realize] Class 'style' has no 'set_background' member
    349: [E1101, GreyableBin.do_expose_event] Class 'style' has no 'paint_flat_box' member
    349: [E1101, GreyableBin.do_expose_event] Class 'style' has no 'paint_flat_box' member
    349: [E1101, GreyableBin.do_expose_event] Class 'style' has no 'paint_flat_box' member

ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py:
    23: [W0403] Relative import 'windows', should be 'ubuntuone.controlpanel.gui.qt.uniqueapp.windows'
    25: [W0403] Relative import 'linux', should be 'ubuntuone.controlpanel.gui.qt.uniqueapp.linux'

ubuntuone/controlpanel/tests/test_sd_client.py:
    327: [E1101, BaseTestCase.setUp] Instance of 'SyncDaemonTool' has no 'shares' member
    <and a lot more like this>

See original description

Related branches

lp:~nataliabidart/ubuntuone-control-panel/fix-lint
Roberto Alsina (community): Approve
Diff: 120 lines (+19/-12)
6 files modified
ubuntuone/controlpanel/dbus_service.py (+5/-10)
ubuntuone/controlpanel/gui/gtk/gui.py (+2/-0)
ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py (+4/-0)
ubuntuone/controlpanel/gui/gtk/widgets.py (+3/-0)
ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py (+2/-2)
ubuntuone/controlpanel/tests/test_sd_client.py (+3/-0)
lp:~nataliabidart/ubuntuone-control-panel/stable-3-0-update-2.99.3
Roberto Alsina (community): Approve
Diff: 518 lines (+131/-77)
17 files modified
run-tests.bat (+40/-35)
setup.py (+2/-1)
ubuntuone/controlpanel/backend.py (+16/-6)
ubuntuone/controlpanel/dbus_service.py (+5/-10)
ubuntuone/controlpanel/gui/gtk/gui.py (+2/-0)
ubuntuone/controlpanel/gui/gtk/tests/test_widgets.py (+4/-0)
ubuntuone/controlpanel/gui/gtk/widgets.py (+3/-0)
ubuntuone/controlpanel/gui/qt/addfolder.py (+3/-5)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+4/-0)
ubuntuone/controlpanel/gui/qt/main/linux.py (+0/-5)
ubuntuone/controlpanel/gui/qt/main/windows.py (+1/-7)
ubuntuone/controlpanel/gui/qt/tests/__init__.py (+4/-0)
ubuntuone/controlpanel/gui/qt/tests/test_addfolder.py (+2/-1)
ubuntuone/controlpanel/gui/qt/uniqueapp/__init__.py (+2/-2)
ubuntuone/controlpanel/sd_client/__init__.py (+4/-0)
ubuntuone/controlpanel/tests/test_backend.py (+28/-2)
ubuntuone/controlpanel/tests/test_sd_client.py (+11/-3)
Natalia Bidart (nataliabidart)
description: updated
Changed in ubuntuone-control-panel:
assignee: nobody → Natalia Bidart (nataliabidart)
importance: Undecided → High
status: New → In Progress
Ubuntu One Auto Pilot (otto-pilot)
Changed in ubuntuone-control-panel:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.