pylint is too complex and causes many problems
Bug #1068335 reported by
dobey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Ubuntu One Control Panel | Status tracked in Trunk | |||||
| Stable-4-2 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
Medium
|
dobey | |||
| Ubuntu Single Sign On Client | Status tracked in Trunk | |||||
| Stable-4-2 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
Medium
|
dobey | |||
| ubuntuone-dev-tools | Status tracked in Trunk | |||||
| Stable-4-2 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
Medium
|
dobey | |||
Bug Description
Pylint is a very complex static language checker, and causes us many issues. We're currently having to ship a patch which has been rejected upstream, in order to use it for the projects where we still do. It also requires us to litter our code with plenty of disable/enable messages, to make the report avoid some valid cases where modules cannot be imported, or similar.
To combat these issues we should move everything to pyflakes, which is much simpler, and does not have any enable/disable comment flags.
Related branches
lp:~dobey/ubuntuone-dev-tools/run-with-flakes
- Diego Sarmentero (community): Approve
- Michał Karnicki (community): Approve
-
Diff: 191 lines (+31/-55)7 files modifiedbin/u1lint (+17/-4)
run-tests (+3/-0)
ubuntuone/devtools/reactors/qt4.py (+1/-1)
ubuntuone/devtools/testcase.py (+0/-38)
ubuntuone/devtools/testcases/dbus.py (+2/-4)
ubuntuone/devtools/testcases/squid.py (+1/-1)
ubuntuone/devtools/tests/test_decorators.py (+7/-7)
lp:~dobey/ubuntu-sso-client/lint-roller
- Mike McCracken (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 572 lines (+48/-81)15 files modifiedbin/ubuntu-sso-login (+1/-0)
run-mac-tests (+2/-1)
run-tests (+3/-2)
run-tests.bat (+2/-1)
ubuntu_sso/keyring/__init__.py (+5/-2)
ubuntu_sso/networkstate/__init__.py (+0/-6)
ubuntu_sso/networkstate/linux.py (+2/-6)
ubuntu_sso/qt/main/__init__.py (+3/-5)
ubuntu_sso/qt/proxy_dialog.py (+2/-8)
ubuntu_sso/qt/ssl_dialog.py (+2/-4)
ubuntu_sso/utils/__init__.py (+1/-3)
ubuntu_sso/utils/tests/test_tcpactivation.py (+0/-20)
ubuntu_sso/utils/tests/test_ui.py (+3/-3)
ubuntu_sso/utils/webclient/__init__.py (+4/-10)
ubuntu_sso/utils/webclient/tests/test_webclient.py (+18/-10)
lp:~dobey/ubuntuone-control-panel/lint-roller
- Mike McCracken (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 257 lines (+29/-34)12 files modifiedrun-tests (+4/-3)
run-tests.bat (+2/-1)
ubuntuone/controlpanel/backend.py (+3/-2)
ubuntuone/controlpanel/dbus_service.py (+1/-8)
ubuntuone/controlpanel/dbustests/__init__.py (+1/-1)
ubuntuone/controlpanel/gui/__init__.py (+6/-1)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+5/-4)
ubuntuone/controlpanel/gui/qt/preferences.py (+1/-1)
ubuntuone/controlpanel/gui/qt/share_links.py (+2/-2)
ubuntuone/controlpanel/tests/test_backend.py (+1/-1)
ubuntuone/controlpanel/tests/test_web_client.py (+2/-2)
ubuntuone/controlpanel/web_client.py (+1/-8)
lp:~dobey/ubuntuone-client/lint-roller
- Mike McCracken (community): Approve
-
Diff: 26 lines (+3/-2)2 files modifiedtests/syncdaemon/test_interaction_interfaces.py (+1/-1)
ubuntuone/syncdaemon/interaction_interfaces.py (+2/-1)
| Changed in ubuntu-sso-client: | |
| status: | New → Triaged |
To post a comment you must log in.
