The current code layout makes it hard to separate the tests per-platform (constants)
Bug #989119 reported by
Diego Sarmentero
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu One Client |
Fix Released
|
High
|
Mike McCracken | ||
Bug Description
The current code layout makes it impossible/hard to separate the tests per-platform. The suggested solution is:
Refactor this module to have something like:
constants/
__init__.py
linux.py
windows.py
darwin.py
Refactor the Tests for this module in the same way.
Related branches
lp:~mikemc/ubuntuone-client/cleanup-platform-constants
- Brian Curtin (community): Approve
- dobey (community): Approve
- Diego Sarmentero (community): Approve
-
Diff: 89 lines (+0/-69)3 files modifiedubuntuone/platform/linux/constants.py (+0/-34)
ubuntuone/platform/windows/__init__.py (+0/-1)
ubuntuone/platform/windows/constants.py (+0/-34)
| summary: |
- Refactor platform/constants + The current code layout makes it hard to separate the tests per-platform + (constants) |
| description: | updated |
Revision history for this message
| Mike McCracken (mikemc) wrote | #1 |
| Changed in ubuntuone-client: | |
| status: | New → Triaged |
| tags: | added: desktop+ |
| Changed in ubuntuone-client: | |
| status: | Triaged → Fix Committed |
| Changed in ubuntuone-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Note that the branch I linked to this bug hasn't been tested because the tests are still too wound up with platform specific imports to run.
And there are no tests that test this trivial constants module.
My first branch, please let me know if I've done anything weird.