string leak in syncdaemon_daemon_is_folder_enabled()

Bug #981255 reported by Charles Kerr on 2012-04-13
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Status tracked in Trunk
Stable-2-0
Medium
Unassigned
Stable-3-0
Medium
Unassigned
Trunk
Medium
Charles Kerr
ubuntuone-client (Ubuntu)
Undecided
dobey
Oneiric
Undecided
Unassigned
Precise
Undecided
dobey

Bug Description

The variable 'dirpath' is leaked in libsyncdaemon/syncdaemon-daemon.c's syncdaemon_daemon_is_folder_enabled(). A one-liner g_free() fixes it.

[Test Case]
This is a simple memory leak with an obvious fix. It's a small leak and would take significant repeated work to test for a noticeable difference.

[Regression Potential]
Minimal. It is highly unlikely this change will get reverted or the same leak reintroduced.

Related branches

Leo Arias (elopio) on 2012-04-16
Changed in ubuntuone-client:
assignee: nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+)
status: New → Triaged
tags: added: desktop+
dobey (dobey) on 2012-04-16
Changed in ubuntuone-client (Ubuntu Precise):
status: New → Triaged
assignee: nobody → Rodney Dawes (dobey)
Brian Murray (brian-murray) wrote :

Thanks for uploading the fix for this bug report to -proposed. However, when reviewing the package in -proposed and the details of this bug report I noticed that this bug is not fixed in the development release of Ubuntu. What are the plans for getting this fixed in Quantal? Additionallly, the bug description is missing required SRU information as described at https://wiki.ubuntu.com/StableReleaseUpdates/#Procedure.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-client - 3.0.1-0ubuntu1.1

---------------
ubuntuone-client (3.0.1-0ubuntu1.1) quantal; urgency=low

  * New upstream release.
    - Don't ignore test failures in from main tests suite. (LP: #993574)
    - Avoid multiple parallel GetDelta commands on same volume. (LP: #883252)
    - Fix small memory leak in folder enabled check. (LP: #981255)
    - Don't start syncdaemon with u1sdtool -q if not running. (LP: #907479)
    - Avoid having Upload execute before Makefile command. (LP: #978903)
  * debian/watch:
    - Update watch file to use stable-3-0 series for downloads now
 -- Rodney Dawes <email address hidden> Tue, 22 May 2012 13:33:55 -0400

Changed in ubuntuone-client (Ubuntu):
status: Triaged → Fix Released
dobey (dobey) on 2012-06-05
description: updated

Hello Charles, or anyone else affected,

Accepted ubuntuone-client into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in ubuntuone-client (Ubuntu Precise):
status: Triaged → Fix Committed
tags: added: verification-needed
Marc Deslauriers (mdeslaur) wrote :

NACK.

ubuntuone-client was updated in precise-updates for the security issue in bug 882062.

This SRU needs to be updated to include the security fix.

dobey (dobey) wrote :

The fix does indeed remove the leak.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-client - 3.0.1-0ubuntu1.0.1

---------------
ubuntuone-client (3.0.1-0ubuntu1.0.1) precise-proposed; urgency=low

  * New upstream release.
    - Don't ignore test failures in from main tests suite. (LP: #993574)
    - Avoid multiple parallel GetDelta commands on same volume. (LP: #883252)
    - Fix small memory leak in folder enabled check. (LP: #981255)
    - Don't start syncdaemon with u1sdtool -q if not running. (LP: #907479)
    - Avoid having Upload execute before Makefile command. (LP: #978903)
  * debian/watch:
    - Update watch file to use stable-3-0 series for downloads now
 -- Rodney Dawes <email address hidden> Wed, 06 Jun 2012 14:08:37 -0400

Changed in ubuntuone-client (Ubuntu Precise):
status: Fix Committed → Fix Released
Rolf Leggewie (r0lf) wrote :

oneiric has seen the end of its life and is no longer receiving any updates. Marking the oneiric task for this ticket as "Won't Fix".

Changed in ubuntuone-client (Ubuntu Oneiric):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers