Should export an interface to validate udf paths
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Ubuntu One Client | Status tracked in Trunk | |||||
Stable-3-0 |
Fix Released
|
Undecided
|
Brian Curtin | |||
Trunk |
Fix Released
|
Medium
|
Brian Curtin | |||
Ubuntu One Control Panel | Status tracked in Trunk | |||||
Stable-3-0 |
Fix Released
|
Undecided
|
Unassigned | |||
Trunk |
Fix Released
|
Medium
|
Natalia Bidart | |||
ubuntuone-client (Ubuntu) |
Fix Released
|
Medium
|
dobey | |||
ubuntuone-control-panel (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Currently, the logic to check if a path is valid for user-defined-folder (a.k.a. cloud folder) creation is in control panel's validate_
This logic belongs to the u1-client project, and it should be exported as a method in the syncdaemon IPC/DBus interface.
Also, since the logic is currently in u1cp, there are calls being made to os_helper functions, which causes unicode/bytes issues, since in u1cp everything is unicode, but os_helper API uses bytes, so we're increasing the coupling between those.
Temporarily, until the validation logic is added to u1-client, a call to is_link and the related test will be disabled in u1cp. Should be removed and replaced for a call to the new syncdaemon validation service.
Related branches
- Natalia Bidart (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 303 lines (+176/-9)9 files modifiedtests/platform/test_external_interface.py (+10/-0)
tests/syncdaemon/test_interaction_interfaces.py (+10/-0)
tests/syncdaemon/test_vm.py (+107/-1)
ubuntuone/platform/linux/dbus_interface.py (+6/-0)
ubuntuone/platform/tools/__init__.py (+8/-0)
ubuntuone/platform/windows/ipc.py (+5/-0)
ubuntuone/platform/windows/ipc_client.py (+4/-0)
ubuntuone/syncdaemon/interaction_interfaces.py (+7/-0)
ubuntuone/syncdaemon/volume_manager.py (+19/-8)
- Roberto Alsina (community): Approve
- Diego Sarmentero (community): Approve
-
Diff: 233 lines (+35/-112)4 files modifiedubuntuone/controlpanel/backend.py (+2/-28)
ubuntuone/controlpanel/sd_client/__init__.py (+4/-0)
ubuntuone/controlpanel/tests/test_backend.py (+12/-84)
ubuntuone/controlpanel/tests/test_sd_client.py (+17/-0)
- Alejandro J. Cura (community): Approve
-
Diff: 1335 lines (+334/-437)19 files modifiedubuntuone/controlpanel/backend.py (+13/-31)
ubuntuone/controlpanel/dbustests/test_sd_client/test_linux.py (+0/-94)
ubuntuone/controlpanel/gui/__init__.py (+1/-1)
ubuntuone/controlpanel/gui/qt/controlpanel.py (+3/-4)
ubuntuone/controlpanel/gui/qt/folders.py (+3/-2)
ubuntuone/controlpanel/gui/qt/gui.py (+1/-2)
ubuntuone/controlpanel/gui/qt/main/__init__.py (+2/-1)
ubuntuone/controlpanel/gui/qt/main/tests/test_main.py (+10/-1)
ubuntuone/controlpanel/gui/qt/tests/test_folders.py (+13/-1)
ubuntuone/controlpanel/gui/qt/tests/test_preferences.py (+15/-0)
ubuntuone/controlpanel/gui/qt/tests/test_wizard.py (+12/-1)
ubuntuone/controlpanel/gui/qt/wizard.py (+4/-8)
ubuntuone/controlpanel/sd_client/__init__.py (+10/-13)
ubuntuone/controlpanel/sd_client/linux.py (+0/-46)
ubuntuone/controlpanel/tests/test_backend.py (+66/-105)
ubuntuone/controlpanel/tests/test_sd_client.py (+23/-17)
ubuntuone/controlpanel/utils/__init__.py (+8/-4)
ubuntuone/controlpanel/utils/tests/test_windows.py (+106/-71)
ubuntuone/controlpanel/utils/windows.py (+44/-35)
description: | updated |
Changed in ubuntuone-control-panel: | |
status: | New → Triaged |
Changed in ubuntuone-client: | |
importance: | Undecided → Medium |
Changed in ubuntuone-control-panel: | |
importance: | Undecided → Medium |
assignee: | nobody → Natalia Bidart (nataliabidart) |
description: | updated |
Changed in ubuntuone-client: | |
importance: | Medium → Low |
Changed in ubuntuone-control-panel: | |
importance: | Medium → Low |
tags: | added: u1-windows |
Changed in ubuntuone-client: | |
importance: | Low → Medium |
Changed in ubuntuone-control-panel: | |
importance: | Low → Medium |
tags: | added: u1-windows-cleanup |
Changed in ubuntuone-client: | |
assignee: | Natalia Bidart (nataliabidart) → Diego Sarmentero (diegosarmentero) |
Changed in ubuntuone-control-panel: | |
assignee: | Natalia Bidart (nataliabidart) → Diego Sarmentero (diegosarmentero) |
Changed in ubuntuone-client: | |
assignee: | Diego Sarmentero (diegosarmentero) → Brian Curtin (brian.curtin) |
status: | Triaged → In Progress |
Changed in ubuntuone-client: | |
status: | In Progress → Fix Committed |
Changed in ubuntuone-client (Ubuntu): | |
assignee: | nobody → Rodney Dawes (dobey) |
importance: | Undecided → Medium |
milestone: | none → ubuntu-12.04-beta-1 |
status: | New → In Progress |
tags: | removed: u1-windows-cleanup u1-zomg-windows |
description: | updated |
Changed in ubuntuone-control-panel: | |
assignee: | Diego Sarmentero (diegosarmentero) → Natalia Bidart (nataliabidart) |
Changed in ubuntuone-control-panel: | |
status: | Triaged → In Progress |
Changed in ubuntuone-control-panel (Ubuntu): | |
milestone: | none → ubuntu-12.04 |
This bug was fixed in the package ubuntuone-client - 2.99.4-0ubuntu1
---------------
ubuntuone-client (2.99.4-0ubuntu1) precise; urgency=low
* New upstream release.
- Work with new gireactor from twisted. (LP: #921574, LP: #928892)
- Export an interface to validate folder paths. (LP: #824252)
- Fix or skip some tests causing issues. (LP: #929812, LP: #929546)
* debian/watch:
- Update watch file for new release.
* debian/control:
- Bump standards version to 3.9.2.
- Update dependencies and recommends to prefer gir versions.
- Require twisted 11.1.0-1ubuntu1 which provides gireactor in a patch.
-- Rodney Dawes <email address hidden> Thu, 16 Feb 2012 11:08:42 -0500