Should export an interface to validate udf paths

Bug #824252 reported by Roberto Alsina on 2011-08-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Status tracked in Trunk
Stable-3-0
Undecided
Brian Curtin
Trunk
Medium
Brian Curtin
Ubuntu One Control Panel
Status tracked in Trunk
Stable-3-0
Undecided
Unassigned
Trunk
Medium
Natalia Bidart
ubuntuone-client (Ubuntu)
Medium
dobey
ubuntuone-control-panel (Ubuntu)
Undecided
Unassigned

Bug Description

Currently, the logic to check if a path is valid for user-defined-folder (a.k.a. cloud folder) creation is in control panel's validate_path_for_folder, and in every other app that allows clients to create cloud folders in U1.

This logic belongs to the u1-client project, and it should be exported as a method in the syncdaemon IPC/DBus interface.

Also, since the logic is currently in u1cp, there are calls being made to os_helper functions, which causes unicode/bytes issues, since in u1cp everything is unicode, but os_helper API uses bytes, so we're increasing the coupling between those.

Temporarily, until the validation logic is added to u1-client, a call to is_link and the related test will be disabled in u1cp. Should be removed and replaced for a call to the new syncdaemon validation service.

Related branches

Roberto Alsina (ralsina) on 2011-08-11
description: updated
Changed in ubuntuone-control-panel:
status: New → Triaged
Changed in ubuntuone-client:
importance: Undecided → Medium
Changed in ubuntuone-control-panel:
importance: Undecided → Medium
assignee: nobody → Natalia Bidart (nataliabidart)
description: updated
Changed in ubuntuone-client:
importance: Medium → Low
Changed in ubuntuone-control-panel:
importance: Medium → Low
tags: added: u1-windows
Changed in ubuntuone-client:
importance: Low → Medium
Changed in ubuntuone-control-panel:
importance: Low → Medium
tags: added: u1-windows-cleanup
Changed in ubuntuone-client:
assignee: Natalia Bidart (nataliabidart) → Diego Sarmentero (diegosarmentero)
Changed in ubuntuone-control-panel:
assignee: Natalia Bidart (nataliabidart) → Diego Sarmentero (diegosarmentero)
Changed in ubuntuone-client:
assignee: Diego Sarmentero (diegosarmentero) → Brian Curtin (brian.curtin)
status: Triaged → In Progress
Changed in ubuntuone-client:
status: In Progress → Fix Committed
dobey (dobey) on 2012-02-16
Changed in ubuntuone-client (Ubuntu):
assignee: nobody → Rodney Dawes (dobey)
importance: Undecided → Medium
milestone: none → ubuntu-12.04-beta-1
status: New → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-client - 2.99.4-0ubuntu1

---------------
ubuntuone-client (2.99.4-0ubuntu1) precise; urgency=low

  * New upstream release.
    - Work with new gireactor from twisted. (LP: #921574, LP: #928892)
    - Export an interface to validate folder paths. (LP: #824252)
    - Fix or skip some tests causing issues. (LP: #929812, LP: #929546)
  * debian/watch:
    - Update watch file for new release.
  * debian/control:
    - Bump standards version to 3.9.2.
    - Update dependencies and recommends to prefer gir versions.
    - Require twisted 11.1.0-1ubuntu1 which provides gireactor in a patch.
 -- Rodney Dawes <email address hidden> Thu, 16 Feb 2012 11:08:42 -0500

Changed in ubuntuone-client (Ubuntu):
status: In Progress → Fix Released
tags: removed: u1-windows-cleanup u1-zomg-windows
description: updated
Changed in ubuntuone-control-panel:
assignee: Diego Sarmentero (diegosarmentero) → Natalia Bidart (nataliabidart)
Changed in ubuntuone-control-panel:
status: Triaged → In Progress
Changed in ubuntuone-control-panel (Ubuntu):
milestone: none → ubuntu-12.04
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntuone-control-panel - 2.99.92-0ubuntu1

---------------
ubuntuone-control-panel (2.99.92-0ubuntu1) precise; urgency=low

  * New upstream release:
    - Using limit_bandwidth attribute to properly process the info dict
      for preferences (LP: #944256).
    - Handle errors from backend on the signin wizard page (LP: #945078).
    - Avoid the 'show/hide details' button to grow when focused (LP: #961348).
    - Modified stylesheet to use the new colours from brand, and to also ease
      the reading of white text (LP: #956077).
    - Fixed the gap tab outlines (LP: #822629).
    - Remove custom path validation and use the one provided by syncdaemon
      (LP: #824252).
    - Make use of the new feature from syncdaemon where 'refresh_volumes'
      returns a deferred that gets fired when the server info is ready
      (LP: #851810).
    - Ensured that Folders' tree view has proper texts in the columns to
      have proper column widths (LP: #965175).
    - Forced white background (LP: #961346).
  * debian/control:
    - Bumped dependency versions on ubuntu-sso-client and ubuntuone-client to
      2.99.92.
  * debian/watch:
    - Updated url to fetch tarball from latest milestone.
 -- Natalia Bidart (nessita) <email address hidden> Wed, 04 Apr 2012 13:03:50 -0300

Changed in ubuntuone-control-panel (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers