hardlinks dont make PyInotify say CLOSE_WRITE and content never gets uploaded

[Lucio Torre]

$ cd ~/Ubuntu One/
$ echo test > sample_file
[ mkfile and putcontent happen ]
$ ln sample_file sample_hardlink
[ only mkfile happens, file does not show online ]
$ touch sample_hardlink
[ put content happens, file shows online ]

[Lucio Torre (lucio.torre)]

logs for file:
https://pastebin.canonical.com/49634/

logs for hardlink:
https://pastebin.canonical.com/49634/

[Facundo Batista (facundo)]

Indeed, the are the pyinotify events:

touch f1
    <Event dir=False mask=0x100 maskname=IN_CREATE name=f1 path=foo pathname=/tmp/foo/f1 wd=1 >
    <Event dir=False mask=0x20 maskname=IN_OPEN name=f1 path=foo pathname=/tmp/foo/f1 wd=1 >
    <Event dir=False mask=0x4 maskname=IN_ATTRIB name=f1 path=foo pathname=/tmp/foo/f1 wd=1 >
    <Event dir=False mask=0x8 maskname=IN_CLOSE_WRITE name=f1 path=foo pathname=/tmp/foo/f1 wd=1 >

ln f1 f2
    <Event dir=False mask=0x100 maskname=IN_CREATE name=f2 path=foo pathname=/tmp/foo/f2 wd=1 >

[Guilherme Salgado (salgado)]

As it stands this bug is just about making sure when a hard-link is created we properly detect its content and make a put_content call, but I wonder if it shouldn't in fact be about adding proper support for hard-links? Making the put_content call when a hard-link is created would be a first step, but we'd have no guarantee that further changes made locally to the content would be picked by the syncdaemon (e.g. if I have f1 and f2 pointing to the same content in my fs, but only f1 synced to U1, if I edit f2 the content in U1 will not be updated).