LR should not re-queue uploads directly
Bug #744608 reported by
Facundo Batista
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Client |
Fix Released
|
High
|
Ubuntu One Foundations+ team | ||
ubuntuone-client (Ubuntu) |
Fix Released
|
Medium
|
Ubuntu One Foundations+ team |
Bug Description
This is because the interrupted upload node may have changed while LR is closed, so a re-hash may be needed.
It should just send a FS_FILE_CLOSE_WRITE event.
Related branches
lp:~facundo/ubuntuone-client/lr-resume-upload-send-closewrite
- Guillermo Gonzalez: Approve
- dobey (community): Approve
-
Diff: 86 lines (+42/-9)2 files modifiedtests/syncdaemon/test_localrescan.py (+31/-6)
ubuntuone/syncdaemon/local_rescan.py (+11/-3)
Changed in ubuntuone-client: | |
assignee: | nobody → Ubuntu One Foundations+ team (ubuntuone-foundations+) |
Changed in ubuntuone-client: | |
status: | Confirmed → In Progress |
Changed in ubuntuone-client (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Ubuntu One Foundations+ team (ubuntuone-foundations+) |
milestone: | none → ubuntu-11.04-beta-2 |
tags: | added: u1-natty-beta |
Changed in ubuntuone-client: | |
status: | In Progress → Fix Committed |
Changed in ubuntuone-client: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Better! It should detect if file changed or not. If it changed, issue a FS_FILE_ CLOSE_WRITE; if it didn't change, just resume the upload.