syncdaemon mixes uniqueness, cancels, and uploading/downloading dictionaries

Bug #707586 reported by Lucio Torre
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Fix Released
High
Facundo Batista

Bug Description

When syncdaemon adds an upload, it will check in uploading to see if it should be removed. Then it will also remove it from the list in some other place, and somewhere else you also have to cancel the transfer. This should be simplified so that stuff like https://bugs.launchpad.net/ubuntuone-client/+bug/705231 does no happen again.

Revision history for this message
Facundo Batista (facundo) wrote :

This has three sides:

- Cancel the previous upload when Upload/Download detects other command because their uniqueness. Note that we're moving the responsibility to the command, getting it out from Sync. I'll let this bug live for this.

- Work with uploading: I need to see if can refactor the "uploading" attribute to be hold on each command and not depend of a global structure. I still need to do this analysis.

- Remove from the list in several places: A refactor needs to be done in the Command steps through its life. For this, bug #704473 is open.

Revision history for this message
Facundo Batista (facundo) wrote :

This is more complex than just moving the cancel out of Sync. Some cancel_upload must still live in Sync (and maybe Unlink be able to cancel Uploads/Downloads).

For cancel_download is even more complicated, we may finish moving the create_partial/remove_partial from Sync to Download.

In any case, we'll not do this for Natty

tags: removed: chicharra-natty
Leo Arias (elopio)
tags: added: maverick
removed: u1-maverick
Changed in ubuntuone-client:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.