plugin needs to check success param of UploadFinished - signal is emitted for failed uploads too

Bug #585953 reported by Roman Yepishev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Won't Fix
Medium
Ubuntu One Client Engineering team
ubuntuone-client (Ubuntu)
Won't Fix
Undecided
Unassigned

Bug Description

When upload is terminated, UploadFinished signal is emitted:

2010-05-26 19:28:10,415 - ubuntuone.SyncDaemon.ActionQueue - DEBUG - Upload share:'20b0b044-523f-462a-8938-7e2fa16030b0' node:marker: 02cd553e-f693-4d2b-a625-4c9e30b5d450 Upload(share_id="'20b0b044-523f-462a-8938-7e2fa16030b0'", hash="'sha1:021f659cd394752974db35b6d0e0f018b6754fd3'", fileobj_factory='<bound method FSKey.open_file of <ubuntuone.syncdaemon.sync.FSKey object at 0x1992be0>>', node_id='marker:02cd553e-f693-4d2b-a625-4c9e30b5d450', crc32='2777194710L', previous_hash="''", size='26229') traceback follows:

Traceback (most recent call last):
Failure: ubuntuone.storageprotocol.errors.InternalError: INTERNAL_ERROR

...
2010-05-26 19:28:10,416 - ubuntuone.SyncDaemon.EQ - DEBUG - push_event: AQ_UPLOAD_ERROR, args:(), kw:{'share_id': '20b0b044-523f-462a-8938-7e2fa16030b0', 'hash': 'sha1:021f659cd394752974db35b6d0e0f018b6754fd3', 'node_id': '877b5a79-d712-43ce-a192-2be84f63d190', 'error': 'INTERNAL_ERROR'}

This signal looks like completely valid UploadFinished signal:
signal sender=:1.273 -> dest=(null destination) serial=192 path=/status; interface=com.ubuntuone.SyncDaemon.Status; member=UploadFinished
   string "/home/rtg/Public/download-error.png"
   array [
      dict entry(
         string "error"
         string "INTERNAL_ERROR"
      )
   ]

This is bad because nautilus plugin flags this file as uploaded and this Upload has not actually Finished.

Roman Yepishev (rye)
Changed in ubuntuone-client:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Ubuntu One Foundations+ team (ubuntuone-foundations+)
tags: added: chicharra foundations+
Revision history for this message
Facundo Batista (facundo) wrote :

The signal is correctly sent from syncdaemon.

When the upload finishes, it sends an UploadFinished signal: if it finished ok, the error field is empty, otherwise it carries the error that happened.

So I'm removing the chicharra tag from here.

tags: removed: chicharra
Revision history for this message
Roman Yepishev (rye) wrote :

This is a bug in nautilus extension - need to check for error field.

Revision history for this message
Roman Yepishev (rye) wrote :

This causes the files that are being uploaded to get ubuntuone-synchronized emblem even though the upload failed in case when users exceeds their quota.

Changed in ubuntuone-client:
assignee: Ubuntu One Foundations+ team (ubuntuone-foundations+) → Ubuntu One Desktop+ team (ubuntuone-desktop+)
tags: added: desktop+ nautilus nautilus-emblems
removed: foundations+
Changed in ubuntuone-client:
importance: High → Medium
status: Confirmed → Triaged
summary: - UploadFinished signal is emitted for failed uploads
+ plugin needs to check success param of UploadFinished - signal is
+ emitted for failed uploads too
Changed in ubuntuone-client:
status: Triaged → Won't Fix
Changed in ubuntuone-client (Ubuntu):
status: New → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.