calling delete folder via DBus with an invalid udf id fails but there is not broadcast of DBus error singal
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Ubuntu One Client | Status tracked in Trunk | |||||
Stable-1-2 |
Fix Released
|
High
|
Guillermo Gonzalez | |||
Trunk |
Fix Released
|
High
|
Guillermo Gonzalez | |||
ubuntuone-client (Ubuntu) |
Fix Released
|
High
|
Ubuntu One Client Engineering team | |||
Lucid |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
if DBus exposed Folders.delete is called with a non-existent/
-------
TEST CASE:
u1sdtool --delete-
Result: u1sdtool hangs forever
Expected result: u1sdtool returns error: FolderDeleteError: DOES_NOT_EXIST (volume_
-------
Here is the log of a test:
guillermo@naug:~/$ DBUS_SESSION_
2010-05-20 13:09:58,989 - ubuntuone.
2010-05-20 13:09:58,990 - ubuntuone.
2010-05-20 13:09:58,990 - ubuntuone.
2010-05-20 13:09:58,991 - ubuntuone.
2010-05-20 13:09:58,991 - ubuntuone.
2010-05-20 13:09:58,991 - ubuntuone.
2010-05-20 13:09:58,991 - ubuntuone.
2010-05-20 13:09:58,992 - ubuntuone.
2010-05-20 13:09:58,992 - ubuntuone.
2010-05-20 13:09:58,992 - ubuntuone.
2010-05-20 13:09:58,994 - ubuntuone.
method return sender=:1.0 -> dest=:1.15 reply_serial=2
guillermo@
2010-05-20 13:09:59,056 - ubuntuone.
2010-05-20 13:09:59,057 - ubuntuone.
2010-05-20 13:09:59,057 - ubuntuone.
2010-05-20 13:09:59,057 - ubuntuone.
The DBusInterface should hanlde this case and broadcast the error/faiure signal, as the client will probably wait for a success/failure response.
Related branches
- Stuart Colville (community): Approve
- Rick McBride (community): Approve
-
Diff: 241 lines (+72/-27)5 files modifiedtests/syncdaemon/test_dbus.py (+28/-5)
tests/syncdaemon/test_vm.py (+8/-0)
ubuntuone/syncdaemon/dbus_interface.py (+12/-8)
ubuntuone/syncdaemon/filesystem_manager.py (+2/-1)
ubuntuone/syncdaemon/volume_manager.py (+22/-13)
- Rodrigo Moya (community): Approve
- Rick McBride (community): Approve
-
Diff: 289 lines (+81/-31)5 files modifiedtests/syncdaemon/test_dbus.py (+33/-6)
tests/syncdaemon/test_vm.py (+8/-0)
ubuntuone/syncdaemon/dbus_interface.py (+16/-11)
ubuntuone/syncdaemon/filesystem_manager.py (+2/-1)
ubuntuone/syncdaemon/volume_manager.py (+22/-13)
Changed in ubuntuone-client (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Ubuntu One Desktop+ team (ubuntuone-desktop+) |
Changed in ubuntuone-client: | |
status: | Confirmed → In Progress |
tags: | added: u1-lucid-sru |
description: | updated |
description: | updated |
tags: |
added: verification-done removed: verification-needed |
tags: | added: testcase |
Accepted ubuntuone-client into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https:/ /wiki.ubuntu. com/Testing/ EnableProposed for documentation how to enable and use -proposed. Thank you in advance!