client applet fails for python older than 2.6.3

Bug #487319 reported by Thomas Vander Stichele
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Invalid
Undecided
Unassigned

Bug Description

Traceback (most recent call last):
- File "/usr/lib/python2.6/site-packages/dbus/connection.py", line 586, in msg_-reply_handler
- reply_handler(*message.get_args_list(**get_args_opts))
- File "/usr/lib/python2.6/site-packages/ubuntuone/oauthdesktop/auth.py", line -276, in got_state
- self.acquire_access_token(description, store)
- File "/usr/lib/python2.6/site-packages/ubuntuone/oauthdesktop/auth.py", line -336, in acquire_access_token
- self.request_token = self.make_token_request(oauth_request)
- File "/usr/lib/python2.6/site-packages/ubuntuone/oauthdesktop/auth.py", line -229, in make_token_request
- fp = opener.open(oauth_request.http_url, oauth_request.to_postdata())
- File "/usr/lib/python2.6/urllib.py", line 205, in open
- return getattr(self, name)(url, data)
- File "/usr/lib/python2.6/urllib.py", line 433, in open_https
- h.endheaders()
- File "/usr/lib/python2.6/httplib.py", line 868, in endheaders
- self._send_output()
- File "/usr/lib/python2.6/httplib.py", line 740, in _send_output
- self.send(msg)
- File "/usr/lib/python2.6/httplib.py", line 699, in send
- self.connect()
- File "/usr/lib/python2.6/site-packages/ubuntuone/oauthdesktop/auth.py", line -58, in _connect_wrapper
- if self._tunnel_host:
-AttributeError: HTTPSConnection instance has no attribute '_tunnel_host'
|
self._tunnel_host was added in revision 74203, which is right before 2.6.3, so not in < 2.6.3.

As a general rule at the very least this should be protected with a get given that it's intended to be private.

Will attach a patch.

Revision history for this message
Thomas Vander Stichele (thomasvs) wrote :
Revision history for this message
dobey (dobey) wrote :

This has already been fixed in trunk and stable-1-0 and is in the 1.0.2 release, so I'm marking this Invalid. And yes, I know the LP UI is pointing at the wrong version. The latest tarball release is 1.0.2. And will be making a 1.0.3 soon, after backporting some more important fixes. Sorry for the confusion. And thanks for getting this working on Fedora!

Changed in ubuntuone-client:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.