file_watcher_update_path is called with "" path when published file is not present (e.g. unsubscribed UDF)

[Roman Yepishev]

ubuntuone-client-gnome:
  Installed: 3.0.1-0ubuntu1

Description: Ubuntu 12.04.1 LTS
Release: 12.04
Codename: precise

I have 600+ published files. When I unsubscribed the UDFs having the most published files and removed the files Nautilus became unusable on the next login. It kept reading icons for files as if they have changed.

file_watcher_update_path can be called with empty path. Empty path is what syncdaemon reports back for GetPublicFiles when the physical file is not present currently (e.g. unsubscribed UDF). This causes nautilus_file_info_invalidate_extension_info to be called on each and every file in watcher->files table because "" is a prefix for every key there. This in turn causes nautilus to invalidate file information public_file_count * watched_file_count times.

STR:

1. Publish a lot of files
2. Unsubscribe UDF and remove the files
3. Restart nautilus

Expected results:
Nautilus is working properly

Actual results:
Nautilus appears hanging and does not react to user action.

[Roman Yepishev (rye)]

Upon discussion with Rodney we decided to have libsyncdaemon stop signalling about published files with empty paths and nautilus plugin should ignore empty paths too.

[Roman Yepishev (rye)]

Patch for lilbsyncdaemon

[Roman Yepishev (rye)]

Patch for nautilus plugin

[Steve Langasek (vorlon)]

The Precise Pangolin has reached end of life, so this bug will not be fixed for that release