[SRU]After install ubuntukylin-theme the grub can't be updated
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| OEM Priority Project |
Medium
|
Unassigned | ||
| Trusty |
Undecided
|
Unassigned | ||
| Ubuntu Kylin |
High
|
Aron Xu | ||
| ubuntukylin-theme |
Undecided
|
zhangchao | ||
| ubuntukylin-theme (Ubuntu) |
Medium
|
Aron Xu | ||
| Trusty |
Medium
|
Aron Xu | ||
| Vivid |
Medium
|
Aron Xu |
Bug Description
[Impact]
After user remove this package, the grub-theme can't be updated. We met this issue in OEM project.
[Test Case]
Just remove or install the package, you will find the grub-theme was not updated.
[Regression Potential]
No, we just do a 'update-grub' after the package was installed.
(copied from #1418909)
Original description
=======
In OEM project we just install ubuntukylin-theme package only, and after install it we found that the grub's background not updated.
When I do 'update-grub', then it fix this issue.
Related branches
- zhangchao (community): Approve on 2015-01-29
- Aron Xu (community): Approve on 2015-01-29
- Anthony Wong: Pending requested 2015-01-28
-
Diff: 47 lines (+14/-4)3 files modifieddebian/changelog (+6/-0)
debian/ubuntukylin-theme.postinst (+4/-2)
debian/ubuntukylin-theme.postrm (+4/-2)
Changed in ubuntukylin-theme: | |
assignee: | nobody → zhangchao (zctgbhu) |
affects: | ubuntukylin-theme → ubuntukylin |
Changed in ubuntukylin: | |
milestone: | none → vivid-beta1 |
Bin Li (binli) wrote : | #1 |
zhangchao (zctgbhu) wrote : | #2 |
Thank you for your patch,I have merged.
Changed in ubuntukylin: | |
importance: | Undecided → High |
status: | New → Fix Committed |
Bin Li (binli) wrote : | #3 |
zhangchao,
Thanks for your quick work, could we also merge it into trusty and push it to trusty-updates channel? Thanks!
zhangchao (zctgbhu) wrote : | #4 |
Bin Li,
I have backport to trusty, You can use this branch:
https:/
64. By zhangchao 3 minutes ago
merges:Bin Li 2015-01-29 * Add update-grub in .postinst and .postrm. (LP: #1415792)
Thanks!
zhangchao (zctgbhu) wrote : | #5 |
I have updated for 14.04 and 15.04
14.04:
lp:ubuntukylin-theme/14.04
15.04:
lp:ubuntukylin-theme/15.04
Bin Li (binli) wrote : | #6 |
Cool, hope it in updates channel quickly. :)
Anthony Wong (anthonywong) wrote : | #7 |
To have the package officially released to trusty-updates, you have to go through the SRU process: https:/
shijing (shijing) wrote : | #8 |
@anthony 谁能处理SRU,
Bin Li (binli) wrote : | #9 |
I will work on it, :)
Anthony Wong (anthonywong) wrote : | #10 |
Aron will help to upload the package, as he has the permission.
Bin, can you help to write the SRU justification?
Changed in ubuntukylin: | |
assignee: | zhangchao (zctgbhu) → Aron Xu (happyaron) |
Changed in ubuntukylin-theme (Ubuntu Trusty): | |
assignee: | nobody → Aron Xu (happyaron) |
Changed in ubuntukylin-theme (Ubuntu Vivid): | |
assignee: | nobody → Aron Xu (happyaron) |
Changed in ubuntukylin-theme: | |
status: | New → Fix Released |
assignee: | nobody → zhangchao (zctgbhu) |
Changed in ubuntukylin: | |
status: | Fix Committed → In Progress |
Bin Li (binli) wrote : | #11 |
@Anthony,
I've opened a new bug for SRU process.
description: | updated |
summary: |
- After install ubuntukylin-theme the grub can't be updated + [SRU]After install ubuntukylin-theme the grub can't be updated |
Changed in ubuntukylin-theme (Ubuntu Trusty): | |
status: | New → In Progress |
importance: | Undecided → Medium |
Changed in ubuntukylin-theme (Ubuntu Vivid): | |
status: | New → In Progress |
importance: | Undecided → Medium |
Changed in ubuntukylin-theme (Ubuntu Vivid): | |
status: | In Progress → Fix Committed |
Changed in ubuntukylin-theme (Ubuntu Trusty): | |
status: | In Progress → Fix Committed |
Changed in ubuntukylin: | |
status: | In Progress → Fix Committed |
Launchpad Janitor (janitor) wrote : | #12 |
This bug was fixed in the package ubuntukylin-theme - 1.2.1
---------------
ubuntukylin-theme (1.2.1) vivid; urgency=medium
[ Bin Li ]
* Add update-grub in .postinst and .postrm. (LP: #1415792)
-- Aron Xu <email address hidden> Fri, 06 Feb 2015 13:33:47 +0000
Changed in ubuntukylin-theme (Ubuntu Vivid): | |
status: | Fix Committed → Fix Released |
Bin Li (binli) wrote : | #13 |
@Anthony,
Could you help contact the SRU team to push it ? Thank!
Aron Xu (happyaron) wrote : | #14 |
@sru-team,
For the concern of re-introducing bug 1228462, the patch has voided being a regression by detecting the existence of grub.cfg, so that we'll run update-grub only when grub2 is successfully installed and configured which is not the case during image generation.
Changed in ubuntukylin: | |
milestone: | vivid-beta1 → trusty-sru |
tags: | added: verification-needed |
Bin Li (binli) wrote : | #15 |
It's good for OEM image. :)
tags: |
added: verification-done removed: verification-needed |
tags: | added: verification-done-trusty |
Changed in ubuntukylin-theme (Ubuntu Trusty): | |
status: | Fix Committed → In Progress |
status: | In Progress → Fix Committed |
Changed in oem-priority: | |
status: | New → Triaged |
importance: | Undecided → Medium |
Launchpad Janitor (janitor) wrote : | #16 |
This bug was fixed in the package ubuntukylin-theme - 1.0.2
---------------
ubuntukylin-theme (1.0.2) trusty; urgency=medium
[ Bin Li ]
* Add update-grub in .postinst and .postrm. (LP: #1415792)
-- Aron Xu <email address hidden> Fri, 06 Feb 2015 21:41:14 +0800
Changed in ubuntukylin-theme (Ubuntu Trusty): | |
status: | Fix Committed → Fix Released |
tags: | removed: verification-done-trusty |
Changed in oem-priority: | |
status: | Triaged → Fix Released |
Changed in ubuntukylin: | |
status: | Fix Committed → Fix Released |
I made a merge request, which is works fine in OEM project. :)