the "Ubuntu Help" should be "Ubuntu Kylin Help"
Bug #1331873 reported by
handsome_feng
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Session Menu |
Fix Released
|
Medium
|
Charles Kerr | ||
Ubuntu Kylin |
Fix Released
|
Medium
|
handsome_feng | ||
Ubuntu Translations |
Fix Released
|
Medium
|
Unassigned | ||
indicator-session (Ubuntu) |
Fix Released
|
Undecided
|
Charles Kerr |
Bug Description
the "Ubuntu Help"should be "Ubuntu Kuliy Help" in the indicator ,since this is ubuntuKylin system.
Related branches
lp:~feng-kylin/indicator-session/indicatorForKylin
On hold
for merging
into
lp:indicator-session/14.10
- Charles Kerr (community): Needs Fixing
-
Diff: 44 lines (+30/-1)1 file modifiedsrc/service.c (+30/-1)
lp:~charlesk/indicator-session/lp-1331873-use-etc-release-for-distro-name
- PS Jenkins bot (community): Approve (continuous-integration)
- Ted Gould (community): Approve
-
Diff: 95 lines (+78/-2)1 file modifiedsrc/service.c (+78/-2)
Changed in ubuntukylin: | |
assignee: | nobody → handsome_feng (445865575-b) |
importance: | Undecided → Medium |
tags: | added: ubuntukylin |
Changed in ubuntukylin: | |
milestone: | none → utopic-alpha2 |
Changed in indicator-session: | |
importance: | Undecided → Medium |
status: | New → Triaged |
Changed in indicator-session: | |
assignee: | nobody → Charles Kerr (charlesk) |
status: | Triaged → In Progress |
Changed in ubuntukylin: | |
status: | New → Fix Committed |
Changed in indicator-session: | |
status: | In Progress → Fix Released |
Changed in indicator-session (Ubuntu): | |
assignee: | nobody → Charles Kerr (charlesk) |
Changed in ubuntukylin: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
IRC discussion from #ubuntu-desktop:
[09:16:50] <charles> hmm, I wonder if there's a better way to do things like this so that we don't wind up with #ifdef-level code all over the place /code.launchpad .net/~445865575 -b/indicator- session/ indicatorForKyl in/+merge/ 223664 n-release, for identifying Kylin systems. www.freedesktop .org/software/ systemd/ man/os- release. html
[09:16:55] <charles> https:/
[09:20:31] <Laney> maybe they should divert /etc/os-release or something
[09:29:15] <seb128> charles, what laney said, use NAME from /etc/os-release and get Kylin to change that
[09:29:36] <seb128> like "%s Help", NAME
[09:30:19] <seb128> happyaron, FJKong: do you if Kylin change its /etc/os-release?
[09:30:50] <happyaron> seb128: Kylin does not change it atm
[09:32:37] <seb128> happyaron, do you know if they discussed change it?
[09:34:43] <happyaron> seb128: they didn't
[09:35:26] <happyaron> seb128: they added a file, /etc/ubuntukyli
[09:35:52] <Laney> it means that programs have to special case kylin though
[09:35:55] <seb128> happyaron, well, that forces code to special case rather than just reading os-release
[09:37:42] <happyaron> seb128: they want to keep compatibility with Ubuntu as much as possible, so that all program that do OS checking can identify it as Ubuntu, except those ones can recognize the additional indication of Kylin flavor.
[09:37:58] <seb128> shrug
[09:38:09] <seb128> they want to be Ubuntu but not be flagged as Ubuntu at the same time
[09:38:23] <happyaron> that's it
[09:39:02] <Laney> http://
[09:39:06] <Laney> I think that NAME is for presentation
Anthony, is there harm in changing the presentation name in /etc/os-release? What breaks if we set NAME=Kylin Ubuntu there?