Activity log for bug #1692538

Date Who What changed Old value New value Message
2017-05-22 14:19:25 bugproxy bug added bug
2017-05-22 14:19:27 bugproxy tags architecture-ppc64le bugnameltc-154875 severity-critical targetmilestone-inin16042
2017-05-22 14:19:28 bugproxy ubuntu: assignee Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage)
2017-05-22 14:19:31 bugproxy affects ubuntu linux (Ubuntu)
2017-05-22 15:01:13 Manoj Iyer bug task added ubuntu-power-systems
2017-05-25 16:11:49 Joseph Salisbury tags architecture-ppc64le bugnameltc-154875 severity-critical targetmilestone-inin16042 architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042
2017-06-01 15:40:51 Manoj Iyer tags architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042 architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042 ubuntu-16.04
2017-06-02 18:11:38 Launchpad Janitor linux (Ubuntu): status New Confirmed
2017-06-03 17:40:31 Frank Heimes ubuntu-power-systems: status New Confirmed
2017-07-19 16:21:28 Manoj Iyer linux (Ubuntu): importance Undecided Critical
2017-07-19 16:21:30 Manoj Iyer ubuntu-power-systems: importance Undecided Critical
2017-07-19 16:21:43 Manoj Iyer linux (Ubuntu): assignee Ubuntu on IBM Power Systems Bug Triage (ubuntu-power-triage) Canonical Kernel Team (canonical-kernel-team)
2017-07-21 15:26:08 Frank Heimes ubuntu-power-systems: assignee Canonical Kernel Team (canonical-kernel-team)
2017-07-24 15:55:54 Manoj Iyer tags architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042 ubuntu-16.04 architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042 triage-g ubuntu-16.04
2017-07-30 13:57:51 Joseph Salisbury nominated for series Ubuntu Xenial
2017-07-30 13:57:51 Joseph Salisbury bug task added linux (Ubuntu Xenial)
2017-07-30 13:57:51 Joseph Salisbury nominated for series Ubuntu Artful
2017-07-30 13:57:51 Joseph Salisbury bug task added linux (Ubuntu Artful)
2017-07-30 13:57:51 Joseph Salisbury nominated for series Ubuntu Zesty
2017-07-30 13:57:51 Joseph Salisbury bug task added linux (Ubuntu Zesty)
2017-07-30 13:58:00 Joseph Salisbury linux (Ubuntu Zesty): importance Undecided Critical
2017-07-30 13:58:02 Joseph Salisbury linux (Ubuntu Xenial): importance Undecided Critical
2017-07-30 13:58:06 Joseph Salisbury linux (Ubuntu Zesty): status New In Progress
2017-07-30 13:58:10 Joseph Salisbury linux (Ubuntu Xenial): status New In Progress
2017-07-30 13:58:12 Joseph Salisbury linux (Ubuntu Artful): status Confirmed In Progress
2017-07-30 13:58:15 Joseph Salisbury linux (Ubuntu Artful): assignee Canonical Kernel Team (canonical-kernel-team) Joseph Salisbury (jsalisbury)
2017-07-30 13:58:18 Joseph Salisbury linux (Ubuntu Zesty): assignee Joseph Salisbury (jsalisbury)
2017-07-30 13:58:21 Joseph Salisbury linux (Ubuntu Xenial): assignee Joseph Salisbury (jsalisbury)
2017-07-31 15:02:08 Seth Forshee linux (Ubuntu Artful): status In Progress Fix Committed
2017-08-11 10:42:37 Stefan Bader linux (Ubuntu Zesty): status In Progress Fix Committed
2017-08-16 07:46:08 Launchpad Janitor linux (Ubuntu Artful): status Fix Committed Fix Released
2017-08-16 07:46:08 Launchpad Janitor cve linked 2017-1000111
2017-08-16 07:46:08 Launchpad Janitor cve linked 2017-1000112
2017-08-16 16:34:54 Kleber Sacilotto de Souza tags architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042 triage-g ubuntu-16.04 architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042 triage-g ubuntu-16.04 verification-needed-zesty
2017-08-16 20:19:48 bugproxy tags architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042 triage-g ubuntu-16.04 verification-needed-zesty architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042 triage-g ubuntu-16.04 verification-done-zesty
2017-08-24 20:09:25 bugproxy tags architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042 triage-g ubuntu-16.04 verification-done-zesty architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042 triage-g ubuntu-16.04 verification-done-xenial verification-done-zesty
2017-08-25 16:22:35 Joseph Salisbury description == Comment: #0 - BRYANT G. LY <bgly@us.ibm.com> - 2017-05-22 08:40:16 == ---Problem Description--- - Issue 1: ibmveth doesn't support largesend and checksum offload features when configured as "Trunk". Driver has explicit checks to prevent enabling these offloads. - Issue 2: SYN packet drops seen at destination VM. When the packet originates, it has CHECKSUM_PARTIAL flag set and as it gets delivered to IO server's inbound Trunk ibmveth, on validating "checksum good" bits in ibmveth receive routine, SKB's ip_summed field is set with CHECKSUM_UNNECESSARY flag. This packet is then bridged by OVS (or Linux Bridge) and delivered to outbound Trunk ibmveth. At this point the outbound ibmveth transmit routine will not set "no checksum" and "checksum good" bits in transmit buffer descriptor, as it does so only when the ip_summed field is CHECKSUM_PARTIAL. When this packet gets delivered to destination VM, TCP layer receives the packet with checksum value of 0 and with no checksum related flags in ip_summed field. This leads to packet drops. So, TCP connections never goes through fine. - Issue 3: First packet of a TCP connection will be dropped, if there is no OVS flow cached in datapath. OVS while trying to identify the flow, computes the checksum. The computed checksum will be invalid at the receiving end, as ibmveth transmit routine zeroes out the pseudo checksum value in the packet. This leads to packet drop. - Issue 4: ibmveth driver doesn't have support for SKB's with frag_list. When Physical NIC has GRO enabled and when OVS bridges these packets, OVS vport send code will end up calling dev_queue_xmit, which in turn calls validate_xmit_skb. In validate_xmit_skb routine, the larger packets will get segmented into MSS sized segments, if SKB has a frag_list and if the driver to which they are delivered to doesn't support NETIF_F_FRAGLIST feature. Contact Information = Bryant G. Ly/bgly@us.ibm.com ---uname output--- 4.8.0-51.54 Machine Type = p8 ---Debugger--- A debugger is not configured ---Steps to Reproduce--- Increases performance greatly The patch has been accepted upstream: https://patchwork.ozlabs.org/patch/764533/ == SRU Justification == Commit 66aa0678ef is request to fix four issues with the ibmveth driver. The issues are as follows: - Issue 1: ibmveth doesn't support largesend and checksum offload features when configured as "Trunk". - Issue 2: SYN packet drops seen at destination VM. When the packet originates, it has CHECKSUM_PARTIAL flag set and as it gets delivered to IO server's inbound Trunk ibmveth, on validating "checksum good" bits in ibmveth receive routine, SKB's ip_summed field is set with CHECKSUM_UNNECESSARY flag. - Issue 3: First packet of a TCP connection will be dropped, if there is no OVS flow cached in datapath. - Issue 4: ibmveth driver doesn't have support for SKB's with frag_list. The details for the fixes to these issues are described in the commits git log. == Comment: #0 - BRYANT G. LY <bgly@us.ibm.com> - 2017-05-22 08:40:16 == ---Problem Description---  - Issue 1: ibmveth doesn't support largesend and checksum offload features    when configured as "Trunk". Driver has explicit checks to prevent    enabling these offloads.  - Issue 2: SYN packet drops seen at destination VM. When the packet    originates, it has CHECKSUM_PARTIAL flag set and as it gets delivered to    IO server's inbound Trunk ibmveth, on validating "checksum good" bits    in ibmveth receive routine, SKB's ip_summed field is set with    CHECKSUM_UNNECESSARY flag. This packet is then bridged by OVS (or Linux    Bridge) and delivered to outbound Trunk ibmveth. At this point the    outbound ibmveth transmit routine will not set "no checksum" and    "checksum good" bits in transmit buffer descriptor, as it does so only    when the ip_summed field is CHECKSUM_PARTIAL. When this packet gets    delivered to destination VM, TCP layer receives the packet with checksum    value of 0 and with no checksum related flags in ip_summed field. This    leads to packet drops. So, TCP connections never goes through fine.  - Issue 3: First packet of a TCP connection will be dropped, if there is    no OVS flow cached in datapath. OVS while trying to identify the flow,    computes the checksum. The computed checksum will be invalid at the    receiving end, as ibmveth transmit routine zeroes out the pseudo    checksum value in the packet. This leads to packet drop.  - Issue 4: ibmveth driver doesn't have support for SKB's with frag_list.    When Physical NIC has GRO enabled and when OVS bridges these packets,    OVS vport send code will end up calling dev_queue_xmit, which in turn    calls validate_xmit_skb.    In validate_xmit_skb routine, the larger packets will get segmented into    MSS sized segments, if SKB has a frag_list and if the driver to which    they are delivered to doesn't support NETIF_F_FRAGLIST feature. Contact Information = Bryant G. Ly/bgly@us.ibm.com ---uname output--- 4.8.0-51.54 Machine Type = p8 ---Debugger--- A debugger is not configured ---Steps to Reproduce---  Increases performance greatly The patch has been accepted upstream: https://patchwork.ozlabs.org/patch/764533/
2017-08-28 10:14:27 Launchpad Janitor linux (Ubuntu Zesty): status Fix Committed Fix Released
2017-08-28 10:14:27 Launchpad Janitor cve linked 2017-7487
2017-09-12 22:40:03 bugproxy tags architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16042 triage-g ubuntu-16.04 verification-done-xenial verification-done-zesty architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16043 triage-g ubuntu-16.04 verification-done-xenial verification-done-zesty
2017-09-18 14:13:21 Manoj Iyer ubuntu-power-systems: status Confirmed In Progress
2017-09-18 14:14:28 Manoj Iyer ubuntu-power-systems: status In Progress Fix Committed
2017-11-06 14:42:10 Andrew Cloke ubuntu-power-systems: status Fix Committed In Progress
2017-11-17 13:24:38 Daniel Axtens bug added subscriber Daniel Axtens
2017-11-20 15:25:44 Manoj Iyer ubuntu-power-systems: status In Progress Fix Released
2017-11-20 15:25:52 Manoj Iyer ubuntu-power-systems: status Fix Released In Progress
2017-11-21 06:45:28 Dominique Poulain bug added subscriber Dominique Poulain
2017-12-18 14:50:51 Andrew Cloke tags architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16043 triage-g ubuntu-16.04 verification-done-xenial verification-done-zesty architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16043 triage-a ubuntu-16.04 verification-done-xenial verification-done-zesty
2018-01-16 14:46:46 Manoj Iyer tags architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16043 triage-a ubuntu-16.04 verification-done-xenial verification-done-zesty architecture-ppc64le bugnameltc-154875 kernel-da-key severity-critical targetmilestone-inin16043 triage-g ubuntu-16.04 verification-done-xenial verification-done-zesty
2018-01-22 14:43:01 Manoj Iyer ubuntu-power-systems: status In Progress Fix Committed
2018-02-26 14:55:18 Manoj Iyer ubuntu-power-systems: status Fix Committed Fix Released
2018-10-29 15:30:45 Joseph Salisbury bug task deleted linux (Ubuntu Xenial)