Update snap store name "Snap Store"

[Robert Ancell]

[Impact]
Currently various things are shown for the snap "Source" field:
3.20: "Ubuntu Snappy Store" - hard-coded
3.22 / 3.24: "dashboard.snapcraft.io" - is inferred from the snap metadata
The officially decided store name is "Ubuntu Store" and this should show in this field.

[Test Case]
1. Open GNOME Software.
2. Install a snap (e.g. moon-buggy).
3. Select installed tab.
4. Look at the "Source" field when looking at the app details.

Expected result:
The source is "Snap Store"

Observed result:
The source is something else.

[Regression Potential]
Small risk of breaking existing code.

[Robert Ancell (robert-ancell)]

The source field was changed by GNOME Software upstream to infer the source based on the icon/screenshot metadata (which is where dashboard.snapcraft.io comes from). The reason for this change was on other distros the source may not have been the Ubuntu store.

To fix this correctly we probably need more information from snapd. The snapd system information has a 'store' field [1] which we can use to decide if this is not the default store. If it's blank is signifies the "default store", but this is not 100% clear this can be assumed that it's the Ubuntu store. We also need to clarify if this is a code or a user-visible string.

It needs to be investigated if installed snaps can tell where they came from. This might be possible by checking assertions. Otherwise we can only say a search result is from a given store, but an installed snap could be from anywhere (e.g. sideloaded).

While this bug seems simple at first glance, some thought needs to be put into it.

[1] https://github.com/snapcore/snapd/wiki/REST-API#get-v2system-info

[Robert Ancell (robert-ancell)]

Trello card: https://trello.com/c/vIp78NQC

[Robert Ancell (robert-ancell)]

commit 6d4b2dee2d3f5d36c7b1b518ac54ee6e2c354313
Author: Robert Ancell <email address hidden>
Date: Wed Sep 6 11:09:45 2017 +1200

    snap: Correct the app origin

[Robert Ancell (robert-ancell)]

Decision was made to use "Snap Store" instead of "Ubuntu Store".

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-software - 3.25.91-1ubuntu5

---------------
gnome-software (3.25.91-1ubuntu5) artful; urgency=medium

  * debian/patches/0012-snap-Correct-the-app-origin.patch:
    - Store is now called "Snap Store"

 -- Robert Ancell <email address hidden> Thu, 07 Sep 2017 09:09:54 +1200

[Brian Murray (brian-murray)]

Hello Robert, or anyone else affected,

Accepted gnome-software into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.22.7-0ubuntu3.17.04.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-zesty to verification-done-zesty. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-zesty. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Brian Murray (brian-murray)]

Hello Robert, or anyone else affected,

Accepted gnome-software into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-software/3.20.5-0ubuntu0.16.04.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Jean-Baptiste Lallement (jibel)]

SRU verification for Xenial:
I have reproduced the problem with gnome-software 3.20.5-0ubuntu0.16.04.6 in xenial-updates and have verified that the version of gnome-software 3.20.5-0ubuntu0.16.04.7 in -proposed fixes the issue.

Marking as verification-done

[Jean-Baptiste Lallement (jibel)]

SRU verification for Zesty:
I have reproduced the problem with gnome-software 3.22.7-0ubuntu3.17.04.7 in zesty-updates and have verified that the version of gnome-software 3.22.7-0ubuntu3.17.04.8 in -proposed fixes the issue.

Marking as verification-done

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-software - 3.22.7-0ubuntu3.17.04.8

---------------
gnome-software (3.22.7-0ubuntu3.17.04.8) zesty; urgency=medium

  * debian/patches/0001-snap-Protect-store-cache-with-a-lock.patch:
    - Fix crash due to multiple threads accessing a cache (LP: #1716633)
  * debian/patches/0001-snap-Don-t-attempt-to-refine-snaps-without-a-valid-n.patch:
    - Fix potential crash from invalid snaps
  * debian/patches/0001-snap-Fix-leak-of-GsApp.patch:
    - Fix small memory leak
  * debian/patches/0001-snap-Only-show-snaps-as-sandboxed-if-snapd-supports-.patch:
    - Simple patch added to make above patches apply cleanly
  * debian/patches/0001-snap-Cancel-snapd-transaction-when-install-remove-ca.patch:
  * debian/patches/0001-snap-Generate-correct-error-for-cancelled-operations.patch:
    - Abort change in snapd when install/remove cancelled (LP: #1721762)
  * debian/patches/0022-snap-Use-new-Polkit-API.patch:
    - Send Polkit interactive header (LP: #1736232)
  * debian/patches/0023-snap-Support-new-snapd-license-field.patch
    - Show license field (not yet supported by Ubuntu Store / snaps)
  * debian/patches/0024-Use-the-developer-name-if-set-in-preference-to-the-p.patch:
  * debian/patches/0025-snap-Use-developer-field.patch
    - Show snap developer (LP: #1715054)
  * debian/patches/0026-snap-Correct-the-app-origin.patch:
    - Set correct store name (LP: #1706500)

 -- Robert Ancell <email address hidden> Wed, 06 Dec 2017 10:37:25 +1300

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for gnome-software has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-software - 3.20.5-0ubuntu0.16.04.7

---------------
gnome-software (3.20.5-0ubuntu0.16.04.7) xenial; urgency=medium

  * debian/patches/0016-Add-a-dpkg-plugin.patch:
  * debian/patches/0017-Add-an-APT-plugin.patch:
    - Fix overflow showing installed size (LP: #1713586)
  * debian/patches/0047-Use-the-developer-name-if-set-in-preference-to-the-p.patch:
    - Backport support for showing developer name
  * debian/patches/0018-Add-a-Snap-plugin.patch:
    - Show snap developer (LP: #1715054)
    - Set correct store name (LP: #1706500)
    - Show license field
    - Send Polkit interactive header (LP: #1736232)
    - Fix crash due to multiple threads accessing a cache (LP: #1716633)
  * debian/patches/0001-ubuntu-reviews-Fix-Wilson-score-calculation.patch:
    - Fix average rating calculation (LP: #1721419)

 -- Robert Ancell <email address hidden> Wed, 06 Dec 2017 10:36:16 +1300