| 2017-01-13 17:28:51 |
Ryan Harper |
bug |
|
|
added bug |
| 2017-01-13 19:19:32 |
Launchpad Janitor |
branch linked |
|
lp:~raharper/curtin/trunk.multipath-skip-update-grub |
|
| 2017-01-13 19:23:16 |
Ryan Harper |
bug task added |
|
curtin (Ubuntu) |
|
| 2017-01-13 19:23:31 |
Ryan Harper |
curtin (Ubuntu): importance |
Undecided |
Medium |
|
| 2017-01-13 19:23:31 |
Ryan Harper |
curtin (Ubuntu): status |
New |
Confirmed |
|
| 2017-01-19 17:01:18 |
Launchpad Janitor |
branch linked |
|
lp:curtin |
|
| 2017-02-08 20:48:30 |
Launchpad Janitor |
branch linked |
|
lp:~curtin-dev/curtin/zesty |
|
| 2017-02-08 21:11:39 |
Launchpad Janitor |
curtin (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2017-02-09 00:29:04 |
Scott Moser |
nominated for series |
|
Ubuntu Xenial |
|
| 2017-02-09 00:29:04 |
Scott Moser |
bug task added |
|
os-prober (Ubuntu Xenial) |
|
| 2017-02-09 00:29:04 |
Scott Moser |
bug task added |
|
curtin (Ubuntu Xenial) |
|
| 2017-02-09 01:36:04 |
Scott Moser |
curtin (Ubuntu Xenial): status |
New |
Confirmed |
|
| 2017-02-09 01:36:11 |
Scott Moser |
curtin (Ubuntu Xenial): importance |
Undecided |
Medium |
|
| 2017-02-09 01:40:27 |
Scott Moser |
description |
1. % lsb_release -rd
Description: Ubuntu 16.04.1 LTS
Release: 16.04
2. % apt-cache policy os-prober
os-prober:
Installed: 1.70ubuntu3
Candidate: 1.70ubuntu3
Version table:
*** 1.70ubuntu3 500
500 http://us.archive.ubuntu.com/ubuntu xenial/main amd64 Packages
100 /var/lib/dpkg/status
3. os-prober should skip over multipath partitions
4. os-prober only skips currently mounted partitions and ends up mounting the same filesystem a second time with grub-mount; sometimes this results in corrupt reads from /var/lib/os-prober/<mount>/boot/grub/grub.cfg which results in undefined but broken behavior
On multipath systems, you have two block devices pointing to the same disk; when we create and mount a filesytem on one (/dev/sda1) we also see the results on a second device (/dev/sdb1)
grub hooks to calling os-prober which checks /proc/mounts for mounted partitions; it skips /dev/sda1, but when checking if /dev/sdb1 is mounted, its not listed in /proc/mounts and then continues to call grub-mount on /dev/sdb1; this uses grub-fuse to mount the disk a second time.
Even if multipath-tools and the module (dm-multipath) are not loaded, it is possible to detect multipath by examining the FSUUID on the block devices, blkid for example, will show that /dev/sda1 and /dev/sdb1 have the same UUID.
There is a patch for skipping multipath but requires multipathd and the dm-multipath module to be loaded.
https://build-test.opensuse.org/package/view_file/home:coolo:test/os-prober/os-prober-skip-part-on-multipath.patch?expand=1
ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: os-prober 1.70ubuntu3
ProcVersionSignature: Ubuntu 4.4.0-59.80-generic 4.4.35
Uname: Linux 4.4.0-59-generic x86_64
NonfreeKernelModules: zfs zunicode zcommon znvpair zavl
ApportVersion: 2.20.1-0ubuntu2.4
Architecture: amd64
CurrentDesktop: GNOME-Flashback:GNOME
Date: Fri Jan 13 11:17:25 2017
Dependencies:
gcc-6-base 6.0.1-0ubuntu1
libc6 2.23-0ubuntu5
libgcc1 1:6.0.1-0ubuntu1
InstallationDate: Installed on 2016-01-01 (378 days ago)
InstallationMedia: Ubuntu 16.04 LTS "Xenial Xerus" - Alpha amd64 (20151209)
SourcePackage: os-prober
UpgradeStatus: No upgrade log present (probably fresh install) |
==== Begin SRU Template ========
[Impact]
During an update-grub in the target system when using multipath
the 'os-prober' tool used to discover other operating systems
to add to the grub menu does not handle duplicate paths and
mounts the same disk up twice causing unknown behavior which
sometimes results in timeouts during installation.
[Test Case]
This failure was transient, but the test cases that showed the
failure were
tests/vmtests/test_multipath.py
So to verify fix, best path is to just run vmtest successfully.
[Regression Potential]
Likeliest failure path would be for multipath installation to
not boot, or fail to install.
[Other Info]
==== End SRU Template ========
1. % lsb_release -rd
Description: Ubuntu 16.04.1 LTS
Release: 16.04
2. % apt-cache policy os-prober
os-prober:
Installed: 1.70ubuntu3
Candidate: 1.70ubuntu3
Version table:
*** 1.70ubuntu3 500
500 http://us.archive.ubuntu.com/ubuntu xenial/main amd64 Packages
100 /var/lib/dpkg/status
3. os-prober should skip over multipath partitions
4. os-prober only skips currently mounted partitions and ends up mounting the same filesystem a second time with grub-mount; sometimes this results in corrupt reads from /var/lib/os-prober/<mount>/boot/grub/grub.cfg which results in undefined but broken behavior
On multipath systems, you have two block devices pointing to the same disk; when we create and mount a filesytem on one (/dev/sda1) we also see the results on a second device (/dev/sdb1)
grub hooks to calling os-prober which checks /proc/mounts for mounted partitions; it skips /dev/sda1, but when checking if /dev/sdb1 is mounted, its not listed in /proc/mounts and then continues to call grub-mount on /dev/sdb1; this uses grub-fuse to mount the disk a second time.
Even if multipath-tools and the module (dm-multipath) are not loaded, it is possible to detect multipath by examining the FSUUID on the block devices, blkid for example, will show that /dev/sda1 and /dev/sdb1 have the same UUID.
There is a patch for skipping multipath but requires multipathd and the dm-multipath module to be loaded.
https://build-test.opensuse.org/package/view_file/home:coolo:test/os-prober/os-prober-skip-part-on-multipath.patch?expand=1
ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: os-prober 1.70ubuntu3
ProcVersionSignature: Ubuntu 4.4.0-59.80-generic 4.4.35
Uname: Linux 4.4.0-59-generic x86_64
NonfreeKernelModules: zfs zunicode zcommon znvpair zavl
ApportVersion: 2.20.1-0ubuntu2.4
Architecture: amd64
CurrentDesktop: GNOME-Flashback:GNOME
Date: Fri Jan 13 11:17:25 2017
Dependencies:
gcc-6-base 6.0.1-0ubuntu1
libc6 2.23-0ubuntu5
libgcc1 1:6.0.1-0ubuntu1
InstallationDate: Installed on 2016-01-01 (378 days ago)
InstallationMedia: Ubuntu 16.04 LTS "Xenial Xerus" - Alpha amd64 (20151209)
SourcePackage: os-prober
UpgradeStatus: No upgrade log present (probably fresh install) |
|
| 2017-02-17 03:31:26 |
Launchpad Janitor |
branch linked |
|
lp:~curtin-dev/curtin/yakkety |
|
| 2017-02-17 03:34:47 |
Scott Moser |
nominated for series |
|
Ubuntu Yakkety |
|
| 2017-02-17 03:34:47 |
Scott Moser |
bug task added |
|
os-prober (Ubuntu Yakkety) |
|
| 2017-02-17 03:34:47 |
Scott Moser |
bug task added |
|
curtin (Ubuntu Yakkety) |
|
| 2017-02-17 03:35:22 |
Scott Moser |
curtin (Ubuntu Yakkety): status |
New |
Confirmed |
|
| 2017-02-17 03:35:25 |
Scott Moser |
curtin (Ubuntu Yakkety): importance |
Undecided |
Medium |
|
| 2017-02-17 17:01:31 |
Brian Murray |
curtin (Ubuntu Yakkety): status |
Confirmed |
Fix Committed |
|
| 2017-02-17 17:01:33 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2017-02-17 17:01:35 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2017-02-17 17:01:39 |
Brian Murray |
tags |
amd64 apport-bug xenial |
amd64 apport-bug verification-needed xenial |
|
| 2017-02-17 17:07:55 |
Brian Murray |
curtin (Ubuntu Xenial): status |
Confirmed |
Fix Committed |
|
| 2017-02-24 23:01:07 |
Jon Grimm |
tags |
amd64 apport-bug verification-needed xenial |
amd64 apport-bug verification-needed-xenial verification-needed-yakkety xenial |
|
| 2017-02-28 18:43:37 |
Scott Moser |
attachment added |
|
output of vmtests for xenial run https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1656369/+attachment/4828517/+files/sm-curtin-x1.tar.xz |
|
| 2017-02-28 18:44:07 |
Scott Moser |
tags |
amd64 apport-bug verification-needed-xenial verification-needed-yakkety xenial |
amd64 apport-bug verification-done-xenial verification-needed-yakkety xenial |
|
| 2017-02-28 18:48:28 |
Scott Moser |
tags |
amd64 apport-bug verification-done-xenial verification-needed-yakkety xenial |
amd64 apport-bug verification-done-xenial verification-done-yakkety xenial |
|
| 2017-02-28 18:52:21 |
Scott Moser |
attachment added |
|
output of vmtests for yakkety run https://bugs.launchpad.net/ubuntu/+source/os-prober/+bug/1656369/+attachment/4828526/+files/sm-curtin-y1.tar.xz |
|
| 2017-03-01 00:27:02 |
Launchpad Janitor |
curtin (Ubuntu Yakkety): status |
Fix Committed |
Fix Released |
|
| 2017-03-01 00:27:24 |
Chris Halse Rogers |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2017-03-01 00:53:57 |
Launchpad Janitor |
curtin (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
