notify-send shows "application has been installed" even when authenticate window is cancelled

Bug #1568935 reported by Eduar Arley Cardona
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
gnome-software (Ubuntu)
Fix Released
Low
Robert Ancell
Xenial
Fix Committed
Low
Unassigned
Yakkety
Fix Released
Low
Robert Ancell

Bug Description

$ lsb_release -rd
Description: Ubuntu Xenial Xerus (development branch)
Release: 16.04

$ apt-cache policy gnome-software
gnome-software:
  Instalados: 3.20.1~git20160331.78d1aab-0ubuntu2
  Candidato: 3.20.1~git20160331.78d1aab-0ubuntu2
  Tabla de versión:
 *** 3.20.1~git20160331.78d1aab-0ubuntu2 500
        500 http://co.archive.ubuntu.com/ubuntu xenial/main amd64 Packages
        100 /var/lib/dpkg/status

Steps to reproduce:
1. Open gnome-software. Search for any non-installed program.
2. Click on "Install"
3. On authenticate window, don't enter a password. Simply Cancel.

Expected result:
A message showing the authentication was refused, or the application couldn't be installed

Current result:
A notification "ProgramX has been installed"

ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: gnome-software
ProcVersionSignature: Ubuntu 4.4.0-18.34-generic 4.4.6
Uname: Linux 4.4.0-18-generic x86_64
ApportVersion: 2.20.1-0ubuntu1
Architecture: amd64
CurrentDesktop: Unity
Date: Mon Apr 11 10:38:08 2016
InstallationDate: Installed on 2016-03-27 (14 days ago)
InstallationMedia: Ubuntu 16.04 LTS "Xenial Xerus" - Beta amd64 (20160323)
SourcePackage: gnome-software
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Eduar Arley Cardona (eduar47) wrote :
affects: software-center (Ubuntu) → gnome-software (Ubuntu)
description: updated
Changed in gnome-software (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Bruno Nova (brunonova) wrote :

It also doesn't remove the application icon added to the launcher (tried this with Eclipse).

Revision history for this message
Robert Ancell (robert-ancell) wrote :

Fixed in upstream commit:

commit 8d15294552b1b47888f16222db2cf1c17482faee
Author: Richard Hughes <email address hidden>
Date: Mon Sep 12 16:50:58 2016 +0100

    Only show the external installed notification on success

diff --git a/src/gs-page.c b/src/gs-page.c
index 852b7e3..8cce6e5 100644
--- a/src/gs-page.c
+++ b/src/gs-page.c
@@ -172,7 +172,7 @@ gs_page_app_installed_cb (GObject *source,
        }

        /* only show this if the window is not active */
- if (gs_app_get_state (helper->app) != AS_APP_STATE_QUEUED_FOR_INSTALL &&
+ if (gs_app_is_installed (helper->app) &&
            !gs_shell_is_active (priv->shell))
                gs_app_notify_installed (helper->app);

Changed in gnome-software (Ubuntu Xenial):
status: New → Triaged
importance: Undecided → Low
Changed in gnome-software (Ubuntu Yakkety):
importance: Medium → Low
status: Triaged → Fix Committed
assignee: nobody → Robert Ancell (robert-ancell)
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Fixed in 3.20.1+git20160923.2.7374bdc-0ubuntu1 in yakkety (this change got picked up with another fix and not mentioned in the changelog).

Changed in gnome-software (Ubuntu Yakkety):
status: Fix Committed → Fix Released
Changed in gnome-software (Ubuntu Xenial):
status: Triaged → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.