| 2016-09-27 12:10:44 |
Alberto Salvia Novella |
bug |
|
|
added bug |
| 2016-09-27 12:10:52 |
Alberto Salvia Novella |
bug task added |
|
variety |
|
| 2016-09-27 12:11:11 |
Alberto Salvia Novella |
nominated for series |
|
Ubuntu Xenial |
|
| 2016-09-27 12:11:29 |
Alberto Salvia Novella |
variety (Ubuntu): status |
New |
Triaged |
|
| 2016-09-27 12:11:34 |
Alberto Salvia Novella |
variety: status |
New |
Confirmed |
|
| 2016-09-27 13:17:54 |
Peter Levi |
variety: status |
Confirmed |
Fix Released |
|
| 2016-09-27 13:18:52 |
Peter Levi |
variety: milestone |
|
0.6.1 |
|
| 2016-09-27 17:48:14 |
Alberto Salvia Novella |
bug task added |
|
hundredpapercuts |
|
| 2016-09-27 17:48:20 |
Alberto Salvia Novella |
hundredpapercuts: status |
New |
Triaged |
|
| 2016-09-27 17:48:23 |
Alberto Salvia Novella |
hundredpapercuts: importance |
Undecided |
Low |
|
| 2016-10-05 17:19:15 |
Alberto Salvia Novella |
bug |
|
|
added subscriber James Lu |
| 2017-03-17 19:57:27 |
James Lu |
variety (Ubuntu): status |
Triaged |
Fix Released |
|
| 2017-03-21 05:17:21 |
James Lu |
description |
The listed source of wallpapers (http://wallpapers.net/nature-desktop-wallpapers.html) doesn't download wallpapers. Correcting the link doesn't work either.
ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: variety 0.6.0-1
ProcVersionSignature: Ubuntu 4.4.0-38.57-generic 4.4.19
Uname: Linux 4.4.0-38-generic x86_64
ApportVersion: 2.20.1-0ubuntu2.1
Architecture: amd64
CurrentDesktop: Unity
Date: Tue Sep 27 14:07:06 2016
InstallationDate: Installed on 2016-05-02 (147 days ago)
InstallationMedia: Ubuntu 16.04 LTS "Xenial Xerus" - Release amd64 (20160420.1)
PackageArchitecture: all
SourcePackage: variety
UpgradeStatus: No upgrade log present (probably fresh install) |
The listed source of wallpapers (http://wallpapers.net/nature-desktop-wallpapers.html) doesn't download wallpapers. Correcting the link doesn't work either.
ProblemType: Bug
DistroRelease: Ubuntu 16.04
Package: variety 0.6.0-1
ProcVersionSignature: Ubuntu 4.4.0-38.57-generic 4.4.19
Uname: Linux 4.4.0-38-generic x86_64
ApportVersion: 2.20.1-0ubuntu2.1
Architecture: amd64
CurrentDesktop: Unity
Date: Tue Sep 27 14:07:06 2016
InstallationDate: Installed on 2016-05-02 (147 days ago)
InstallationMedia: Ubuntu 16.04 LTS "Xenial Xerus" - Release amd64 (20160420.1)
PackageArchitecture: all
SourcePackage: variety
UpgradeStatus: No upgrade log present (probably fresh install)
----
Below is the SRU template (James Lu):
[Impact]
Variety support for Wallpapers.net no longer works because the site has since changed its layout.
Newer versions of Variety have dropped support for this source, and the SRU patch below backports this removal in Xenial.
Per the bug nomination for Xenial and Section 2.1 of https://wiki.ubuntu.com/StableReleaseUpdates#Other_safe_cases (A library for a web service needs to be updated for changes to the web server API), I believe this fix is worthwhile in improving user experience and unlikely to cause serious regressions.
* An explanation of the effects of the bug on users and
* justification for backporting the fix to the stable release.
* In addition, it is helpful, but not required, to include an
explanation of how the upload fixes this bug.
[Test Case]
* In the Images list of Variety's preferences page, attempting to select Wallpapers.net ("wn") as a wallpaper source causes a silent failure as no wallpapers are found.
* Attempting to add any Wallpapers.net category (e.g. http://www.wallpapers.net/wallpapers/nature) using the Preferences->General->Add button fails with a "Could not find wallpapers there" error.
[Regression Potential]
From my testing, when this patch is applied, all previous sources using Wallpapers.net are removed (this actually raises a "Unknown source" error in the console, which leads to automatic removal). This makes it possible to have a variety configuration with no wallpaper sources left after an upgrade, but this does not appear to be fatal and can be quickly fixed through the preferences page.
Some more regression potential:
- This patch removes a substantial amount of code, so it's possible that there are there are modules with lingering dependencies on the removed Wallpapers.net code. Should this be true, that code will fail to import and potentially cause Variety to crash on start.
- Part of the upstream patch removes python-lxml as a dependency, which I've done in my packaging as well. As far as I can tell (from the results of "grep lxml **/*.py"), variety/WallpapersNetDownloader.py was the only module in Variety to use lxml, and this is removed by the patch. However, if this assumption is wrong, a missing module will cause Variety to fail to start.
- It may be worth checking how other features of Variety (e.g. filters) are affected by the potential removal of all Wallpaper sources (though this can be manually done by just deselecting everything in Preferences). One note is that sync is currently broken regardless of this commit due to https://bugs.launchpad.net/variety/+bug/1635912, which is yet to be fixed upstream.
[Other Info]
The patch I'm submitting for this bug is slightly modified from the upstream commit, and I've removed conflicting edits to the package description (debian/control) and the autogenerated po/variety.pot file. |
|
| 2017-03-21 07:26:21 |
Gianfranco Costamagna |
bug task added |
|
variety (Ubuntu Xenial) |
|
| 2017-03-22 18:08:46 |
Gianfranco Costamagna |
variety (Ubuntu Xenial): status |
New |
In Progress |
|
| 2017-03-23 18:42:02 |
Brian Murray |
variety (Ubuntu Xenial): status |
In Progress |
Incomplete |
|
| 2017-03-23 18:42:08 |
Brian Murray |
bug |
|
|
added subscriber Brian Murray |
| 2017-03-23 19:44:06 |
Alberto Salvia Novella |
variety (Ubuntu Xenial): importance |
Undecided |
Low |
|
| 2017-03-24 11:01:39 |
Alberto Salvia Novella |
variety (Ubuntu Xenial): status |
Incomplete |
Triaged |
|
| 2017-03-24 15:59:11 |
Brian Murray |
variety (Ubuntu Xenial): status |
Triaged |
Fix Committed |
|
| 2017-03-24 15:59:13 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2017-03-24 15:59:15 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2017-03-24 15:59:19 |
Brian Murray |
tags |
amd64 apport-bug third-party-packages xenial |
amd64 apport-bug third-party-packages verification-needed xenial |
|
| 2017-03-24 16:18:49 |
Brian Murray |
removed subscriber Brian Murray |
|
|
|
| 2017-10-13 19:29:39 |
Ubuntu Foundations Team Bug Bot |
tags |
amd64 apport-bug third-party-packages verification-needed xenial |
amd64 apport-bug removal-candidate third-party-packages verification-needed xenial |
|
| 2021-08-06 17:12:10 |
Paul White |
bug task deleted |
hundredpapercuts |
|
|
