[SRU] "Install Now" button disappears for good if all packages unselected and Ubuntu Pro packages are shown but unavailable

[Tormod Volden]

[Impact]

If one deselects all packages, the "Install Now" button disappears, which makes sense (on another note it would make even more sense if it was simply grayed out). However when one or more packages are then re-selected, the button won't ever reappear, and update-manager must be restarted in order to upgrade any packages.

[Test case]

For each affected $series:

* If 'apt list --upgradable' is empty, downgrade any one package in your system.
* sudo ua detach --assume-yes
* sudo apt install hello
* update-manager
* Verify at least one update is available, and the hello package is unavailable under the 'Ubuntu Pro security updates' section
* De-select all available packages
* Verify the 'install now' button disappears
* Select at least one available package
* Verify the 'install now' button is still absent
* Close the window

* Enable proposed (see https://wiki.ubuntu.com/Testing/EnableProposed)
* sudo apt install -t $series-proposed update-manager

* update-manager
* Verify at least one update is available, and the hello package is unavailable under the 'Ubuntu Pro security updates' section
* De-select all available packages
* Verify the 'install now' button disappears
* Select at least one available package
* Verify the 'install now' button is now visible again

[Where things could go wrong]

Things could go wrong with the 'install now' button. It should be visible when there is any available package selected and not visible when there is none selected. So a regression could appear as the user no longer being able install packages via this program, or being able to click "install now" with no packages selected to be installed. In any case, since this program is essentially a wrapper of Apt, all the package management functionality, including upgrading, would still be avaialable through Apt.

[Nathan Teodosio (nteodosio)]

You say "update-manager 1:24.04.6 (Ubuntu 20.04)" but tagged the bug Noble, can you please correct that?

[Nathan Teodosio (nteodosio)]

Here the window simply goes unresponsive and segfaults. Won't submit crash files, Whoopsie wants me to upgrade the entire system before doing so.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Tormod Volden (tormodvolden)]

I think you got segfaults because you hit bug #2027941 (or #2041831, the "secret" report, dunno which one should be made duplicate). I guess you used a mouse click to deselect :) If you use the spacebar to deselect, you can probably reproduce this bug.

[Tormod Volden (tormodvolden)]

Nathan, now that 2041831/2027941 has been fixed, I hope you can come back to this and reproduce the issue.

[Nathan Teodosio (nteodosio)]

Can't reproduce, here the button is simply turned grey, do you see anything in the screen shot that is not there in your case?

[Nathan Teodosio (nteodosio)]

Do you have "You need to enable Ubuntu Pro to install these updates." written in the program? Can you please send in a screen shot?

[Tormod Volden (tormodvolden)]

The screenshot shows the absence of the "Install Now" button.

$ lsb_release -c
No LSB modules are available.
Codename: noble
$
$ update-manager --version
WARNING:root:can not import unity GI Namespace Dbusmenu not available
update-manager: version 24.04.9
$

[Tormod Volden (tormodvolden)]

The message "You need to enable Ubuntu Pro to install these updates." is written exactly when the button disappears, or actually at any time that no packages are selected any longer.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Dave Jones (waveform)]

This looks good, but a few tweaks are need to the bug description for the purposes of the SRU process. The test plan is nicely written for verifying that the bug is fixed, but for SRU purposes it needs to:

* first replicate the issue (demonstrate the issue is actually present)

* upgrade the package from the proposed pocket (I realise it's not present in proposed yet, but we write the test plan from the perspective of what's going to be tested once it is)

* finally, demonstrate the proposed version now fixes the issue

I've edited the description to something I think should be acceptable for the SRU team, but please feel free to edit further if I've made any mistakes!

The other part that needs a minor tweak is the regression section: it's fine to point out what the fix *should* be fixing, but this is more about unintended side effects. In other words, consider what the consequences could be if this update (accidentally) breaks update-manager for the user. No matter how trivial the fix, this is always a possibility.

In this case, it's probably worth pointing out that, even if update-manager is broken to the point it cannot run, it's a thin veneer over the actual package management system, and the user would still have a path to upgrade packages via the apt command.

[Dave Jones (waveform)]

I'll leave tweaking the regression section to your better judgment, but in the meantime I'll sponsor this for oracular, noble, jammy, and focal (I don't *think* I can sponsor for bionic and xenial since they're in ESM).

[Dave Jones (waveform)]

Sponsored for oracular, noble, jammy, and focal; removing ubuntu-sponsors. Subscribing ubuntu-security to check bionic and xenial.

[Nathan Teodosio (nteodosio)]

Thank you, Dave, for sponsoring and for the thoughtful improvement suggestions. You seem to have taken care of it all (yes I think for Bionic and Xenial the process is special), and I edited the regression section, but let me know if it is still lacking in any form.

[Eduardo Barretto (ebarretto)]

John Breton will take a look into it for both xenial and bionic esm.
This not being a security issue per se, will instead fall into esm-infra-updates, just like focal+ will also go to updates pocket.

[John Breton (john-breton)]

Xenial and Bionic have been uploaded to our esm-infra-updates-staging PPA. We are just waiting for this SRU to be published in the archive first for the other releases.

[Timo Aaltonen (tjaalton)]

Hello Tormod, or anyone else affected,

Accepted update-manager into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:24.10.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

Hello Tormod, or anyone else affected,

Accepted update-manager into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:24.04.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Timo Aaltonen (tjaalton)]

An upload of update-manager to jammy-proposed has been rejected from the upload queue for the following reason: "git cruft in the upload".

[Timo Aaltonen (tjaalton)]

An upload of update-manager to focal-proposed has been rejected from the upload queue for the following reason: "git cruft in the upload".

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted update-manager (1:24.04.10) for noble have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-release-upgrader/1:24.04.26 (s390x)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/noble/update_excuses.html#update-manager

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Nathan Teodosio (nteodosio)]

In 24.04:

* 'apt list --upgradable' was not empty
* sudo ua detach --assume-yes
* sudo apt install hello
* update-manager
* At least one update was available, and the hello package was unavailable under the 'Ubuntu Pro security updates' section
* De-selected all available packages
* Verified that the 'install now' button disappeared
* Selected one available package
* Verified that the 'install now' button was still absent
* Closed the window

* Enabled proposed (see https://wiki.ubuntu.com/Testing/EnableProposed)
* sudo apt install update-manager/noble-proposed

* update-manager
* At least one update was available, and the hello package was unavailable under the 'Ubuntu Pro security updates' section
* De-selected all available packages
* Verified that the 'install now' button disappeared
* Selected one available package
* Verifed that the 'install now' button was visible again

[Chris Halse Rogers (raof)]

Hello Tormod, or anyone else affected,

Accepted update-manager into noble-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:24.04.12 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-noble to verification-done-noble. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-noble. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Chris Halse Rogers (raof)]

Hello Tormod, or anyone else affected,

Accepted update-manager into oracular-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:24.10.9 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-oracular to verification-done-oracular. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-oracular. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Chris Halse Rogers (raof)]

Hello Tormod, or anyone else affected,

Accepted update-manager into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:20.04.10.24 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Nathan Teodosio (nteodosio)]

In 24.04,

* 'apt list --upgradable' was not empty.
* sudo ua detach --assume-yes
* sudo apt install hello
* update-manager
* At least one update was available, and the hello package was unavailable under the 'Ubuntu Pro security updates' section
* De-selected all available packages
* Verified that the 'install now' button disappeared
* Selected an available package
* Verified that the 'install now' button is still absent
* Closed the window

* Enabled proposed (see https://wiki.ubuntu.com/Testing/EnableProposed)
* sudo apt install -t noble-proposed update-manager

* update-manager
* Verified that at least one update was available, and the hello package was unavailable under the 'Ubuntu Pro security updates' section
* De-selected all available packages
* Verified that the 'install now' button disappeared
* Selected one available package
* Verified that the 'install now' button was visible again

[Andreas Hasenack (ahasenack)]

Hello Tormod, or anyone else affected,

Accepted update-manager into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:22.04.22 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Ubuntu SRU Bot (ubuntu-sru-bot)]

All autopkgtests for the newly accepted update-manager (1:22.04.22) for jammy have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-release-upgrader/1:22.04.20 (amd64, s390x)
ubuntu-release-upgrader/unknown (arm64)
update-notifier/unknown (arm64)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/jammy/update_excuses.html#update-manager

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

[Nathan Teodosio (nteodosio)]

Autopkgtests fixed.

[Nathan Teodosio (nteodosio)]

In 22.04, I executed the test case successfully, confirming that in version .22 the 'install now' button comes back after selecting a package, differently from the behavior of .21..

[Timo Aaltonen (tjaalton)]

verification for oracular is missing

[Nathan Teodosio (nteodosio)]

Doesn't apply to 24.10 because ESM is not available for non-LTS.

Just to be sure, I unselected all packages and the 'install now' button didn't disappear, so that is good too, and upgrades occurred without problems, so setting this as done.

[Nathan Teodosio (nteodosio)]

In 20.04,

* 'apt list --upgradable' wasn't empty.
* sudo ua detach --assume-yes
* sudo apt install hello
* update-manager
* Verified that updates were available, and the hello package was unavailable under the 'Ubuntu Pro security updates' section
* De-selected all available packages
* Verified that the 'install now' button disappeared
* Selected one available package
* Verified that the 'install now' button was still absent
* Closed the window

Installed .24 from proposed.

* update-manager
* Verified updates were available, and the hello package was unavailable under the 'Ubuntu Pro security updates' section
* De-selected all available packages
* Verified that the 'install now' button disappeared
* Selected one available package
* Verified that the 'install now' button was visible again

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-manager - 1:24.10.9

---------------
update-manager (1:24.10.9) oracular; urgency=medium

  * test_update_origin.py: Update to noble, and packaged archive keys
    (LP: #2109339)
  * test_update_origin: close the dpkg status file when tearing down
    (also tracked in LP: #2109339)

update-manager (1:24.10.8) oracular; urgency=medium

  * Screen reader: announce status header for update dialogue (LP: #1105371).
    Although that was claimed to be fixed in the prevoius version, the part
    of the patch corresponding to it was actually left behind.

update-manager (1:24.10.7) oracular; urgency=medium

  * When all packages are unselected, install button goes away; Fix it not coming back
    after once a package is selected again (LP: #2068805).
  * Screen reader: announce status header for update dialogue and checkbox
    state when the highlighted package changes or is toggled. (lp: #1105371)

 -- Julian Andres Klode <email address hidden> Fri, 25 Apr 2025 15:14:08 +0200

[Andreas Hasenack (ahasenack)]

The verification of the Stable Release Update for update-manager has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-manager - 1:24.04.12

---------------
update-manager (1:24.04.12) noble; urgency=medium

  * test_update_origin.py: Update to noble, and packaged archive keys
    (LP: #2109339)
  * test_update_origin: close the dpkg status file when tearing down
    (also tracked in LP: #2109339)

update-manager (1:24.04.11) noble; urgency=medium

  * Screen reader: announce status header for update dialogue (LP: #1105371).
    Although that was claimed to be fixed in the prevoius version, the part
    of the patch corresponding to it was actually left behind.

update-manager (1:24.04.10) noble; urgency=medium

  * When all packages are unselected, install button goes away; Fix it not
    coming back after once a package is selected again (LP: #2068805).
  * Screen reader: announce status header for update dialogue and checkbox
    state when the highlighted package changes or is toggled.
    (lp: #1105371)

 -- Julian Andres Klode <email address hidden> Fri, 25 Apr 2025 15:16:13 +0200

[Tormod Volden (tormodvolden)]

Nathan, thanks a lot for fixing this!

[Nathan Teodosio (nteodosio)]

My pleasure!

[John Breton (john-breton)]

Hello all,

The fix is now available for Xenial and Bionic through esm-infra-updates.

[Launchpad Janitor (janitor)]

This bug was fixed in the package update-manager - 1:22.04.22

---------------
update-manager (1:22.04.22) jammy; urgency=medium

  * Print warning message on failing to run updates end-point (LP: #2064211).
  * When all packages are unselected, install button goes away; Fix it not
    coming back after once a package is selected again (LP: #2068805).
  * Switch to Debian source 3.0 (native)

 -- Nathan Pratta Teodosio <email address hidden> Thu, 11 Jul 2024 11:48:43 +0200