Own org.gnome.SettingsDaemon.MediaKeys D-Bus name too

Bug #1686077 reported by Jeremy Bicha on 2017-04-25
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
GNOME Settings Daemon
Fix Released
Medium
gnome-settings-daemon (Debian)
Fix Released
Unknown
gnome-settings-daemon (Ubuntu)
Medium
Unassigned
Xenial
Medium
Unassigned
Yakkety
Medium
Unassigned
Zesty
Medium
Unassigned
unity-settings-daemon (Ubuntu)
Medium
Unassigned
Xenial
Medium
Unassigned
Yakkety
Medium
Unassigned
Zesty
Medium
Unassigned

Bug Description

Impact
======
This bugfix enabled gnome-settings-daemon's multimedia key support to work according to what the API has said for years (in addition to the way it's been commonly used).

https://git.gnome.org/browse/gnome-settings-daemon/commit/?h=gnome-3-24&id=42f75ed4cdc86498d6e02e511a1314b8916bd4aa

https://mail.gnome.org/archives/desktop-devel-list/2017-April/msg00069.html

The SRU justification is that newer versions of apps will be switching to the D-Bus name in the API documentation. If someone installs the newer version from a PPA or a Flatpak or Snap, the multimedia key support should continue working.

Test Case
=========
Install this update on Ubuntu GNOME.
Reboot
Install d-feet then run d-feet
Switch to the session tab.
Type 'settings' into the search box.'
In the list of results there should be both org.gnome.SettingsDaemon and org.gnome.SettingsDaemon.MediaKeys with cmd: /usr/lib/gnome-settings-daemon/gsd-media-keys

Regression Potential
====================
This should just make gnome(unity)-settings-daemon own both the commonly used D-Bus name and the one actually defined in the API docs.

Jeremy Bicha (jbicha) on 2017-04-25
Changed in gnome-settings-daemon (Ubuntu Xenial):
importance: Undecided → Medium
status: New → Triaged
Changed in gnome-settings-daemon (Ubuntu Yakkety):
importance: Undecided → Medium
status: New → Triaged
Changed in gnome-settings-daemon (Ubuntu Zesty):
importance: Undecided → Medium
status: New → Triaged
Changed in unity-settings-daemon (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Changed in unity-settings-daemon (Ubuntu Xenial):
importance: Undecided → Medium
status: New → Triaged
Changed in unity-settings-daemon (Ubuntu Yakkety):
importance: Undecided → Medium
status: New → Triaged
Changed in unity-settings-daemon (Ubuntu Zesty):
importance: Undecided → Medium
status: New → Triaged
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 3.24.1-0ubuntu3

---------------
gnome-settings-daemon (3.24.1-0ubuntu3) artful; urgency=medium

  * Really add git_fix-gdm-plugins.patch
  * Add media-keys-Fix-mmkeys-D-Bus-API-to-match-API-docs.patch:
    Own the D-Bus name that the API documentation tells users of the
    multimedia keys API they should use (org.gnome.SettingsDaemon.MediaKeys),
    in addition to the D-Bus name that they actually use in practice
    (org.gnome.SettingsDaemon). (LP: #1686077)

 -- Jeremy Bicha <email address hidden> Tue, 25 Apr 2017 07:55:13 -0400

Changed in gnome-settings-daemon (Ubuntu):
status: Fix Committed → Fix Released
Changed in gnome-settings-daemon:
importance: Unknown → Medium
status: Unknown → Fix Released
Changed in gnome-settings-daemon (Debian):
status: Unknown → Fix Released
Jeremy Bicha (jbicha) on 2017-05-09
Changed in gnome-settings-daemon (Ubuntu Zesty):
status: Triaged → In Progress
Jeremy Bicha (jbicha) on 2017-05-10
description: updated

Hello Jeremy, or anyone else affected,

Accepted gnome-settings-daemon into zesty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gnome-settings-daemon/3.24.2-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-settings-daemon (Ubuntu Zesty):
status: In Progress → Fix Committed
tags: added: verification-needed
Jeremy Bicha (jbicha) wrote :

I installed gnome-settings-daemon 3.24.2-0ubuntu0.1 on Ubuntu GNOME 17.04 and successfully completed this test case with d-feet.

tags: added: verification-done-zesty
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-settings-daemon - 3.24.2-0ubuntu0.1

---------------
gnome-settings-daemon (3.24.2-0ubuntu0.1) zesty; urgency=medium

  * New upstream release (LP: #1689610)
    - Fix gdm starting with no plugins which broke Hi-DPI support
      on the login screen (LP: #1685035)
    - Fix brightness control in some dual-GPU computers (LP: #1683445)
    - Own the D-Bus name that the API documentation tells users of the
      multimedia keys API they should use (org.gnome.SettingsDaemon.MediaKeys),
      in addition to the D-Bus name that they actually use in practice
      (org.gnome.SettingsDaemon). (LP: #1686077)
  * Add revert-disable-rfkill-keys-handling.patch:
    - Revert commit that disabled GNOME's rfkill handling. Although
      this fixes problems for some users, it makes things worse for
      other people.

 -- Jeremy Bicha <email address hidden> Tue, 09 May 2017 14:05:29 -0400

Changed in gnome-settings-daemon (Ubuntu Zesty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for gnome-settings-daemon has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.