double header in 16.10
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
humanity-icon-theme (Ubuntu) |
Fix Released
|
Medium
|
Unassigned | ||
Xenial |
Fix Released
|
Medium
|
Unassigned | ||
Yakkety |
Fix Released
|
Medium
|
Unassigned | ||
ubiquity (Ubuntu) |
Fix Released
|
Medium
|
Mathieu Trudel-Lapierre | ||
Xenial |
Fix Released
|
Low
|
Mathieu Trudel-Lapierre | ||
Yakkety |
Won't Fix
|
Low
|
Unassigned |
Bug Description
[Impact]
During install and oem-firstboot, the header bar at the top of the screen in Ubiquity is twice as tall as it should be on hidpi screens (looking like two normal sized header bars stacked on top of each other), and the blue a11y icon is double sized.
This looks obviously incorrect and ugly and makes a bad first impression on users installing Ubuntu on a hidpi laptop or customers of Ubuntu OEMs booting new machines for the first time. Arstechnica commented negatively on this in their review of Dell's XPS 13: http://
Users of the Dell XPS 13 are affected as well as users of other brands of laptops with hidpi screens. System76 is temporarily carrying a patched version of Humanity to work around this bug.
The a11y icon is double-sized because the version of Humanity shipping in Ubuntu doesn't support @2 hidpi scaling, which results in the header bar doubling its height. Because the header bar is drawn with CAIRO_PAD_REPEAT, the gradient is repeated so it looks like two bars stacked one on top of the other. The fix to the Humanity icon theme adds @2 hidpi support, which shrinks the icon and restores the header bar to its normal height.
[Test Case]
ISO install:
1. Grab an Ubuntu iso and proceed to install (not "try") Ubuntu on a computer with a hidpi screen.
2. Note the double-sized header and icon during install.
- Using an iso with a fixed version of Humanity, the header and icon should look normal.
OEM-Firstboot:
1. Grab an Ubuntu iso and do an oem-install on on a computer with a hidpi screen.
2. After installing, click the launcher icon to "Prepare for shipping to the end user" and reboot.
3. During oem-firstboot, note the double-sized header and icon during install.
- To test the fix, install a fixed version of humanity before preparing the system for the end user.
[Regression Potential]
This patch affects the look of anything using the Humanity icon set. The look of Nautilus, and many other GTK apps will be affected. This is not a regression but fixes another bug and resolves a discrepancy between rendering of icons on hidpi screens vs lowdpi screens.
The biggest risk for regression comes from the off chance that there is an error or omission in the index.theme files. Comparing icons on a broad range of applications and systems should catch this class of issues. If any issues with icons are found, check there.
Related branches
- Iain Lane: Approve
-
Diff: 1095 lines (+570/-0)3 files modifiedHumanity-Dark/index.theme (+126/-0)
Humanity/index.theme (+438/-0)
debian/changelog (+6/-0)
Changed in ubiquity (Ubuntu): | |
importance: | Undecided → Medium |
tags: | added: iso-testing |
description: | updated |
Changed in ubiquity (Ubuntu): | |
status: | New → Confirmed |
Changed in ubiquity (Ubuntu): | |
status: | Confirmed → Triaged |
Changed in ubiquity (Ubuntu): | |
status: | Triaged → In Progress |
Changed in ubiquity (Ubuntu): | |
assignee: | nobody → Mathieu Trudel-Lapierre (cyphermox) |
milestone: | none → ubuntu-17.01 |
Changed in humanity-icon-theme (Ubuntu): | |
status: | New → Fix Committed |
description: | updated |
Changed in humanity-icon-theme (Ubuntu Xenial): | |
importance: | Undecided → Low |
Changed in ubiquity (Ubuntu Xenial): | |
importance: | Undecided → Medium |
Changed in ubiquity (Ubuntu Yakkety): | |
importance: | Undecided → Medium |
Changed in humanity-icon-theme (Ubuntu): | |
importance: | Undecided → Low |
importance: | Low → Medium |
Changed in humanity-icon-theme (Ubuntu Xenial): | |
importance: | Low → Medium |
Changed in humanity-icon-theme (Ubuntu Yakkety): | |
importance: | Undecided → Medium |
Changed in ubiquity (Ubuntu Xenial): | |
importance: | Medium → Low |
Changed in ubiquity (Ubuntu Yakkety): | |
importance: | Medium → Low |
tags: | removed: 16.10 rls-y-incoming |
Changed in ubiquity (Ubuntu Xenial): | |
status: | In Progress → Fix Committed |
Changed in ubiquity (Ubuntu Xenial): | |
status: | Fix Committed → In Progress |
I can't confirm in virtualbox here on a lowdpi screen, might be hidpi specific?