| 2016-07-08 17:18:56 |
David Jordan |
bug |
|
|
added bug |
| 2016-07-08 18:47:28 |
David Jordan |
summary |
ubiquity targets wrong drive, fails to install grub with nvme disks |
ubiquity targets invalid device name with nvme disks, fails to install grub |
|
| 2016-07-08 18:48:01 |
David Jordan |
description |
On Ubuntu 16.04, when installing Ubuntu to an nvme drive, Ubiquity fails to install grub. In ubiquity/misc.py the function default_grub targets /dev/nvme0 instead of /dev/nvme0n1, which is the real name of the device.
For single drive scenarios, this can be fixed by filtering out nvme devices from the regex line:
old:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/[a-z]+).*',
r'\1', target)
fixed:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/(?!nvme)[a-z]+).*',
r'\1', target)
For multi-drive scenarios, Ubiquity behaves inconsistently between bios and uefi modes. In UEFI mode, default_grub behaves like the single drive scenario and only sees the usb media (which it ignores) and the nvme drive.
In BIOS mode, there is a device listed at /dev/sda before the nvme drive. Ubiquity then tries to put grub on /dev/sda regardless that we're installing to the nvme drive. Grub then fails to install on /dev/sda.
This makes Ubuntu a pain to reinstall for our customers if they have an nvme drive. |
On Ubuntu 16.04, when installing Ubuntu to an nvme drive, Ubiquity fails to install grub. In ubiquity/misc.py the function default_grub targets /dev/nvme0 instead of /dev/nvme0n1, which is the real name of the device.
For single drive scenarios, this can be fixed by filtering out nvme devices from the regex line:
old:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/[a-z]+).*',
r'\1', target)
fixed:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/(?!nvme)[a-z]+).*',
r'\1', target) |
|
| 2016-07-25 16:38:13 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu): status |
New |
In Progress |
|
| 2016-07-25 16:38:15 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu): importance |
Undecided |
Medium |
|
| 2016-07-25 16:38:17 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu): assignee |
|
Mathieu Trudel-Lapierre (cyphermox) |
|
| 2016-07-25 20:41:37 |
Launchpad Janitor |
branch linked |
|
lp:ubiquity |
|
| 2016-07-25 23:55:15 |
Launchpad Janitor |
ubiquity (Ubuntu): status |
In Progress |
Fix Released |
|
| 2016-07-29 16:38:26 |
David Jordan |
ubiquity (Ubuntu): status |
Fix Released |
Confirmed |
|
| 2016-08-01 18:46:11 |
Mathieu Trudel-Lapierre |
nominated for series |
|
Ubuntu Trusty |
|
| 2016-08-01 18:46:11 |
Mathieu Trudel-Lapierre |
bug task added |
|
ubiquity (Ubuntu Trusty) |
|
| 2016-08-01 18:46:11 |
Mathieu Trudel-Lapierre |
nominated for series |
|
Ubuntu Xenial |
|
| 2016-08-01 18:46:11 |
Mathieu Trudel-Lapierre |
bug task added |
|
ubiquity (Ubuntu Xenial) |
|
| 2016-08-01 18:46:22 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu): status |
Confirmed |
Fix Released |
|
| 2016-08-01 18:46:26 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu Trusty): importance |
Undecided |
Medium |
|
| 2016-08-01 18:46:27 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu Xenial): importance |
Undecided |
Medium |
|
| 2016-08-01 18:46:29 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu Trusty): assignee |
|
Mathieu Trudel-Lapierre (cyphermox) |
|
| 2016-08-01 18:46:31 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu Xenial): assignee |
|
Mathieu Trudel-Lapierre (cyphermox) |
|
| 2016-08-01 18:46:35 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu Trusty): status |
New |
In Progress |
|
| 2016-08-01 18:46:40 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu Xenial): status |
New |
In Progress |
|
| 2016-08-01 18:50:13 |
Mathieu Trudel-Lapierre |
description |
On Ubuntu 16.04, when installing Ubuntu to an nvme drive, Ubiquity fails to install grub. In ubiquity/misc.py the function default_grub targets /dev/nvme0 instead of /dev/nvme0n1, which is the real name of the device.
For single drive scenarios, this can be fixed by filtering out nvme devices from the regex line:
old:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/[a-z]+).*',
r'\1', target)
fixed:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/(?!nvme)[a-z]+).*',
r'\1', target) |
[Impact]
Users with NVMe disks.
[Test case]
- Install system with NVMe disks; expect to pick the boot device.
Install should complete succesfully.
[Regression Potential]
None, this only adds matching for NVMe devices; any such devices will now be matched based on the partition numbers rather than risking to match a character device for NVMe formatting. This does not match regular block devices and partitions.
---
On Ubuntu 16.04, when installing Ubuntu to an nvme drive, Ubiquity fails to install grub. In ubiquity/misc.py the function default_grub targets /dev/nvme0 instead of /dev/nvme0n1, which is the real name of the device.
For single drive scenarios, this can be fixed by filtering out nvme devices from the regex line:
old:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/[a-z]+).*',
r'\1', target)
fixed:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/(?!nvme)[a-z]+).*',
r'\1', target) |
|
| 2016-08-01 18:50:22 |
Mathieu Trudel-Lapierre |
description |
[Impact]
Users with NVMe disks.
[Test case]
- Install system with NVMe disks; expect to pick the boot device.
Install should complete succesfully.
[Regression Potential]
None, this only adds matching for NVMe devices; any such devices will now be matched based on the partition numbers rather than risking to match a character device for NVMe formatting. This does not match regular block devices and partitions.
---
On Ubuntu 16.04, when installing Ubuntu to an nvme drive, Ubiquity fails to install grub. In ubiquity/misc.py the function default_grub targets /dev/nvme0 instead of /dev/nvme0n1, which is the real name of the device.
For single drive scenarios, this can be fixed by filtering out nvme devices from the regex line:
old:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/[a-z]+).*',
r'\1', target)
fixed:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/(?!nvme)[a-z]+).*',
r'\1', target) |
[Impact]
Users with NVMe disks.
[Test case]
- Install system with NVMe disks; expect to pick the boot device.
Install should complete succesfully.
[Regression Potential]
This only adds matching for NVMe devices; any such devices will now be matched based on the partition numbers rather than risking to match a character device for NVMe formatting. This does not match regular block devices and partitions.
---
On Ubuntu 16.04, when installing Ubuntu to an nvme drive, Ubiquity fails to install grub. In ubiquity/misc.py the function default_grub targets /dev/nvme0 instead of /dev/nvme0n1, which is the real name of the device.
For single drive scenarios, this can be fixed by filtering out nvme devices from the regex line:
old:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/[a-z]+).*',
r'\1', target)
fixed:
target = re.sub(r'(/dev/(cciss|ida)/c[0-9]d[0-9]|/dev/(?!nvme)[a-z]+).*',
r'\1', target) |
|
| 2016-08-01 20:28:23 |
Launchpad Janitor |
branch linked |
|
lp:~ubuntu-installer/ubiquity/trusty-proposed |
|
| 2016-08-01 23:22:42 |
Adam Conrad |
ubiquity (Ubuntu Trusty): status |
In Progress |
Fix Committed |
|
| 2016-08-01 23:22:45 |
Adam Conrad |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2016-08-01 23:22:50 |
Adam Conrad |
bug |
|
|
added subscriber SRU Verification |
| 2016-08-01 23:22:56 |
Adam Conrad |
tags |
|
verification-needed |
|
| 2016-08-02 03:52:19 |
Launchpad Janitor |
ubiquity (Ubuntu Trusty): status |
Fix Committed |
Fix Released |
|
| 2016-11-09 20:39:54 |
System76 |
bug |
|
|
added subscriber System76 |
| 2019-05-16 20:06:43 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu Xenial): assignee |
Mathieu Trudel-Lapierre (cyphermox) |
|
|
| 2019-05-16 20:06:47 |
Mathieu Trudel-Lapierre |
ubiquity (Ubuntu Xenial): status |
In Progress |
Triaged |
|
| 2019-05-16 20:14:16 |
Mathieu Trudel-Lapierre |
tags |
verification-needed |
rls-x-notfixing |
|
