Activity log for bug #1557673

Date Who What changed Old value New value Message
2016-03-15 17:32:26 Dan Streetman bug added bug
2016-03-15 17:33:58 Dan Streetman tags sts bot-stop-nagging sts
2016-03-15 18:01:44 Dan Streetman systemtap (Ubuntu): assignee Dan Streetman (ddstreet)
2016-03-15 18:01:51 Dan Streetman systemtap (Ubuntu): status New In Progress
2016-03-16 18:16:45 Dan Streetman description Systemtap doesn't work on xenial, due to changes in struct module in the kernel: ubuntu@xenial:~$ sudo stap test.stap In file included from /usr/share/systemtap/runtime/print.c:17:0, from /usr/share/systemtap/runtime/runtime_context.h:22, from /tmp/stapxvNfgC/stap_2e27f5927a5796b18cb7b3c2abd24ec4_812_src.c:50: /usr/share/systemtap/runtime/linux/print.c: In function ‘_stp_print_kernel_info’: /usr/share/systemtap/runtime/linux/print.c:242:20: error: ‘struct module’ has no member named ‘module_core’ THIS_MODULE->module_core, ^ /usr/share/systemtap/runtime/linux/print.c:243:37: error: ‘struct module’ has no member named ‘core_size’ (unsigned long) (THIS_MODULE->core_size - THIS_MODULE->core_text_size)/1024, ^ /usr/share/systemtap/runtime/linux/print.c:243:62: error: ‘struct module’ has no member named ‘core_text_size’ (unsigned long) (THIS_MODULE->core_size - THIS_MODULE->core_text_size)/1024, ^ /usr/share/systemtap/runtime/linux/print.c:244:44: error: ‘struct module’ has no member named ‘core_text_size’ (unsigned long) (THIS_MODULE->core_text_size)/1024, ^ scripts/Makefile.build:258: recipe for target '/tmp/stapxvNfgC/stap_2e27f5927a5796b18cb7b3c2abd24ec4_812_src.o' failed make[1]: *** [/tmp/stapxvNfgC/stap_2e27f5927a5796b18cb7b3c2abd24ec4_812_src.o] Error 1 Makefile:1396: recipe for target '_module_/tmp/stapxvNfgC' failed make: *** [_module_/tmp/stapxvNfgC] Error 2 WARNING: kbuild exited with status: 2 Pass 4: compilation failed. [man error::pass4] Tip: /usr/share/doc/systemtap/README.Debian should help you get started. [Impact] Attempting to use systemtap on xenial with the 4.4 kernel results in: ubuntu@xenial:~$ sudo stap test.stap In file included from /usr/share/systemtap/runtime/print.c:17:0,                  from /usr/share/systemtap/runtime/runtime_context.h:22,                  from /tmp/stapxvNfgC/stap_2e27f5927a5796b18cb7b3c2abd24ec4_812_src.c:50: /usr/share/systemtap/runtime/linux/print.c: In function ‘_stp_print_kernel_info’: /usr/share/systemtap/runtime/linux/print.c:242:20: error: ‘struct module’ has no member named ‘module_core’          THIS_MODULE->module_core,                     ^ /usr/share/systemtap/runtime/linux/print.c:243:37: error: ‘struct module’ has no member named ‘core_size’          (unsigned long) (THIS_MODULE->core_size - THIS_MODULE->core_text_size)/1024,                                      ^ /usr/share/systemtap/runtime/linux/print.c:243:62: error: ‘struct module’ has no member named ‘core_text_size’          (unsigned long) (THIS_MODULE->core_size - THIS_MODULE->core_text_size)/1024,                                                               ^ /usr/share/systemtap/runtime/linux/print.c:244:44: error: ‘struct module’ has no member named ‘core_text_size’                 (unsigned long) (THIS_MODULE->core_text_size)/1024,                                             ^ scripts/Makefile.build:258: recipe for target '/tmp/stapxvNfgC/stap_2e27f5927a5796b18cb7b3c2abd24ec4_812_src.o' failed make[1]: *** [/tmp/stapxvNfgC/stap_2e27f5927a5796b18cb7b3c2abd24ec4_812_src.o] Error 1 Makefile:1396: recipe for target '_module_/tmp/stapxvNfgC' failed make: *** [_module_/tmp/stapxvNfgC] Error 2 WARNING: kbuild exited with status: 2 Pass 4: compilation failed. [man error::pass4] Tip: /usr/share/doc/systemtap/README.Debian should help you get started. [Test Case] on a xenial system with the 4.4 kernel installed, and systemtap and kernel dbgsyms installed, simply create a dummy stap script and try to run it, e.g.: $ cat test.stap #!/usr/bin/stap probe begin { println("hello") } $ sudo stap test.stap the above compilation failure will result. [Regression Potential] The commit updates stap to use the kernel module header correctly based on a small test program, so there should be no regression, but possible regression is breaking stap on the xenial 4.3 kernel. [Other Info] this requires upstream stap commit 3f040971e7efb4d323fcb63d83b4337f355c60db
2016-03-16 18:17:19 Dan Streetman tags bot-stop-nagging sts sts sts-sru
2016-03-16 18:53:37 Dan Streetman attachment added lp1557673.debdiff https://bugs.launchpad.net/ubuntu/+source/systemtap/+bug/1557673/+attachment/4601396/+files/lp1557673.debdiff
2016-03-16 20:26:58 Ubuntu Foundations Team Bug Bot tags sts sts-sru patch sts sts-sru
2016-03-16 20:27:06 Ubuntu Foundations Team Bug Bot bug added subscriber Ubuntu Sponsors Team
2016-03-16 22:39:03 Mathew Hodson systemtap (Ubuntu): importance Undecided High
2016-03-18 15:20:41 Brian Murray tags patch sts sts-sru patch sts sts-sru xenial
2016-03-18 15:21:53 Brian Murray nominated for series Ubuntu Xenial
2016-03-18 15:21:53 Brian Murray bug task added systemtap (Ubuntu Xenial)
2016-04-02 22:50:54 Launchpad Janitor systemtap (Ubuntu Xenial): status In Progress Fix Released
2016-11-09 12:20:16 Louis Bouchard tags patch sts sts-sru xenial patch sts xenial