snapd-glib changes needed for pulseaudio snap policy module xenial backport

Bug #1793298 reported by James Henstridge on 2018-09-19
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
snapd-glib (Ubuntu)
Xenial
High
Unassigned

Bug Description

[Impact]
Older versions of Ubuntu are running older versions of snapd-glib. There have since been bug fixes and support for newer API that was added to snapd since release.

[Test Case]
1. Delete existing Snap credentials by deleting keys com.ubuntu.UbuntuOne.GnomeSoftware in Seahorse.
2. Start GNOME Software
3. Install a snap (e.g. moon-buggy)

Expected result:
User is prompted for Ubuntu credentials and is able to install snap.

Observed result:
Works as expected (i.e. only looking for regressions).

[Regression Potential]
There is a risk of breaking existing use cases. This is reduced by the regression tests in the package and the newer versions of snapd-glib working in newer releases.

The xenial backport of the fix for 1781428 malfunctioned due to the use of snapd-glib behaviour introduced after the version included in xenial: namely auto-connection (and reconnection) to the snapd socket that was introduced in snapd-glib 1.24.

With the policy module loaded, Pulse Audio will contact snapd to check the interfaces plugged by a client in order to decide whether to provide access to the microphone. As the Pulse Audio daemon is long lived, it is not uncommon for the socket connection to be disconnected (either due to a timeout, or because snapd is upgraded while the user is logged in). So simply adding a snapd_client_connect() call at module initialisation time is not sufficient.

The specific snapd-glib calls that could be affected are:

 * snapd_client_list_one_async
 * snapd_client_get_interfaces_async

Robert Ancell (robert-ancell) wrote :

1.33 was uploaded months ago (bug 1748289), we need someone to get it out of the unapproved queue.

Changed in snapd-glib (Ubuntu):
importance: Undecided → High
status: New → Fix Released
no longer affects: snapd-glib (Ubuntu)
Changed in snapd-glib (Ubuntu Xenial):
status: New → Triaged
importance: Undecided → High
description: updated
Robert Ancell (robert-ancell) wrote :

Uploaded snapd-glib 1.45-0ubuntu0.16.04.1

Hello James, or anyone else affected,

Accepted snapd-glib into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/snapd-glib/1.47-0ubuntu0.16.04.0 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in snapd-glib (Ubuntu Xenial):
status: Triaged → Fix Committed
tags: added: verification-needed verification-needed-xenial
Robert Ancell (robert-ancell) wrote :

Tested snapd-glib 1.47-0ubuntu0.16.04.0 in 16.04 LTS (xenial). All working.

tags: added: verification-done-xenial
removed: verification-needed verification-needed-xenial

The verification of the Stable Release Update for snapd-glib has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :
Download full text (3.2 KiB)

This bug was fixed in the package snapd-glib - 1.47-0ubuntu0.16.04.0

---------------
snapd-glib (1.47-0ubuntu0.16.04.0) xenial; urgency=medium

  * New upstream release (LP: #1818766)
  * debian/rules:
    - Build with --enable-installed-tests
  * debian/tests/control:
  * debian/tests/unit:
  * debian/snapd-glib-tests.install:
    - Add autopkg tests
  * debian/libsnapd-glib1.symbols:
    - Updated

snapd-glib (1.45-0ubuntu0.16.04.1) xenial; urgency=medium

  * New upstream release (LP: #1793298):
    - Remove deprecated snapd-login-service
    - New API:
      - snapd_app_get_common_id
      - snapd_client_get_apps2_sync
      - snapd_client_get_apps2_async
      - snapd_client_get_apps2_finish
      - snapd_client_get_maintenance
      - snapd_client_get_snap_async
      - snapd_client_get_snap_finish
      - snapd_client_get_snap_sync
      - snapd_client_get_snaps_async
      - snapd_client_get_snaps_finish
      - snapd_client_get_snap_sync
      - snapd_maintenance_get_kind
      - snapd_maintenance_get_message
      - snapd_media_get_media_type
      - snapd_media_get_url
      - snapd_media_get_width
      - snapd_media_get_height
      - snapd_snap_get_base
      - snapd_snap_get_common_ids
      - snapd_snap_get_media
      - snapd_snap_get_mounted_from
      - snapd_snap_get_publisher_display_name
      - snapd_snap_get_publisher_id
      - snapd_snap_get_publisher_username
      - snapd_snap_get_publisher_validation
      - snapd_system_information_get_build_id
      - snapd_system_information_get_refresh_hold
      - snapd_system_information_get_refresh_last
      - snapd_system_information_get_refresh_next
      - snapd_system_information_get_refresh_schedule
      - snapd_system_information_get_refresh_timer
      - snapd_system_information_get_sandbox_features
      - SNAPD_ERROR_AUTH_CANCELLED
      - SNAPD_ERROR_NOT_FOUND
      - SNAPD_ERROR_NOT_IN_STORE
      - SNAPD_ERROR_NOT_CLASSIC
      - SNAPD_ERROR_REVISION_NOT_AVAILABLE
      - SNAPD_ERROR_CHANNEL_NOT_AVAILABLE
      - SNAPD_ERROR_NOT_A_SNAP
      - SNAPD_FIND_FLAGS_SCOPE_WIDE
    - Deprecated API:
      - snapd_client_get_apps_sync
      - snapd_client_get_apps_async
      - snapd_client_get_apps_finish
      - snapd_client_list_async
      - snapd_client_list_finish
      - snapd_client_list_sync
      - snapd_login_async
      - snapd_login_finish
      - snapd_login_sync
      - snapd_snap_get_screenshots
    - Fix buffer overflows reading HTTP chunked data
    - Reconnect to snapd if disconnected while trying to send the request
    - Handle short writes to snapd
    - Remove cancelled requests from the request queue.
    - Fix SnapdClient reference leak in each request
    - Fix snapd_snap_match_channel not matching risks correctly
    - Fix progress callback scope annotations
    - Fix double-unref on cancelled requests
    - Support new snap media and mounted-from fields
    - Support filtering when querying apps
    - Support snapd maintenance information
    - Support new error codes
    - GIR annotation fixes
  * debian/libsnapd-glib1.symbols:
    - Updated
  * debian/control:
  * debian/snapd-login-service.install
    - snapd-login-service removed

 -- ...

Read more...

Changed in snapd-glib (Ubuntu Xenial):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers