skytools3 autopkgtest broken in xenial and artful

[Christian Ehrhardt ]

[Impact]

 * A recent Security pushed CVE containing Postgres upload modified the
   output of a few commands (good for safety, bad for tests checking exact
   output).

 * We want to get the tests working and reliable again and for this
   package that change seems rather easy to do, so lets do it.

[Test Case]

 * Run the autopkgtests of skytools3 against current Xenial/Artful

 * You can just drop the file as the patch does and the tests will work
   again.

[Regression Potential]

 * This is a Test-Only change and currently Tests are totally broken on
   all arches. So the only regression potential I see is a silly mistake
   we might have missed in our Patch, but it is rather small and I doubt
   there is one affecting the packages function.

[Other Info]

 * Short Term the mark the current version as badtest (This also helps to
   not let too much uploads depend to unblock on each other)

 * Mid Term we want the tests to work, therefore this non-functional test
   only Upload proposed here (If we don't do that we end up with no tests
   after a while).

---

Past security releases changed the output of postgres.
Due to that autopkgtests are broken currently.

Example: https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful/artful/amd64/s/skytools3/20180524_164925_7c562@/log.gz

This should be safe to adapt and due to the CVE push not gating on it in the past is already a fact.
So lets mask the current version a badtest and work on the fix if there is time.

[Christian Ehrhardt  (paelzer)]

Fix suggestion that worked in a local lxd.

[Christian Ehrhardt  (paelzer)]

Newer releases are unaffected (skytools was repackaged and is not affected in a similar manner).
Just X/A for SRU purpose.

[Christian Ehrhardt  (paelzer)]

Added an override for that as interim solution until the package is fixed.
part of:
X - https://code.launchpad.net/~paelzer/britney/hints-ubuntu-xenial-postgresMREII/+merge/346935
A - https://code.launchpad.net/~paelzer/britney/hints-ubuntu-artful-postgresMREII/+merge/346960

[Andreas Hasenack (ahasenack)]

This branch fixes the test: https://code.launchpad.net/~ahasenack/ubuntu/+source/skytools3/+git/skytools3/+ref/fix-dep8-new-postgresql

I also tried with the original xenial postgresql version, tests also pass there, i.e., this modification doesn't break them.

The diff in the test output is this:
--- londiste_create_part.out 2018-05-28 11:46:40.251216169 -0300
+++ londiste_create_part_1.out 2018-05-28 15:09:47.287071961 -0300
@@ -69,9 +69,9 @@
 (1 row)

 select tgenabled, pg_get_triggerdef(oid) from pg_trigger where tgrelid = 'events_2011_01'::regclass::oid;
- tgenabled | pg_get_triggerdef
------------+------------------------------------------------------------------------------------------------------
- A | CREATE TRIGGER "Fooza" AFTER DELETE ON events_2011_01 FOR EACH ROW EXECUTE PROCEDURE "NullTrigger"()
+ tgenabled | pg_get_triggerdef
+-----------+-------------------------------------------------------------------------------------------------------------
+ A | CREATE TRIGGER "Fooza" AFTER DELETE ON public.events_2011_01 FOR EACH ROW EXECUTE PROCEDURE "NullTrigger"()
 (1 row)

It's adding the "public." prefix to the "events_2011-01" table name, and compensating for the extra length in the output (whitespace and --- chars).

[Andreas Hasenack (ahasenack)]

Summary:
xenial-release: 9.5.2: passes with and without this patch
xenial-updates/security: 9.5.12-0ubuntu0.16.04: fails without this patch
xenial-proposed: 9.5.13-0ubuntu0.16.04: also fails without this patch

[Christian Ehrhardt  (paelzer)]

Thanks Andreas for helping me with this aspect of the current PG MRE!
I reviewed both MPs and they LGTM and match my pre-tests I had yesterday.

I'm also adding a SRU Template Entry here.

Furthermore I wanted to make clear that this is orthogonal to mark the old version of skytools as badtest for britney. I'd prefer to do both, mark it (the current version) bad AND SRU this change.

[Brian Murray (brian-murray)]

Hello , or anyone else affected,

Accepted skytools3 into artful-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/skytools3/3.2.6-5ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-artful to verification-done-artful. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-artful. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Brian Murray (brian-murray)]

Hello , or anyone else affected,

Accepted skytools3 into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/skytools3/3.2.6-4ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Christian Ehrhardt  (paelzer)]

Found no issue in a few manual tries with the package.
But since our change modified only the autopkgtest that was to be expected.
Here the change made it working in proposed migration again
passing fine, so the change is working as expected.

Example:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-artful/artful/amd64/s/skytools3/20180615_010352_774bb@/log.gz
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac/autopkgtest-xenial/xenial/amd64/s/skytools3/20180615_004857_0ab60@/log.gz

So verification of the change is ok.

[Launchpad Janitor (janitor)]

This bug was fixed in the package skytools3 - 3.2.6-5ubuntu0.1

---------------
skytools3 (3.2.6-5ubuntu0.1) artful; urgency=medium

  * debian/patches/londiste_create_part_alternate_output.patch: Add
    alternate test result that includes the schema prefix. Closes LP:
    #1773763.

 -- Andreas Hasenack <email address hidden> Mon, 28 May 2018 15:31:08 -0300

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for skytools3 has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package skytools3 - 3.2.6-4ubuntu0.1

---------------
skytools3 (3.2.6-4ubuntu0.1) xenial; urgency=medium

  * debian/patches/londiste_create_part_alternate_output.patch: Add
    alternate test result that includes the schema prefix. Closes LP:
    #1773763.

 -- Andreas Hasenack <email address hidden> Mon, 28 May 2018 11:59:18 -0300