[SRU] shim 15+1552672080.a4a1fbe-0ubuntu2

Bug #1862171 reported by Julian Andres Klode on 2020-02-06
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
shim (Ubuntu)
Status tracked in Groovy
Xenial
Undecided
Unassigned
Bionic
Undecided
Unassigned
Focal
Undecided
Unassigned
Groovy
Undecided
Unassigned
shim-signed (Ubuntu)
Status tracked in Groovy
Xenial
Undecided
Unassigned
Bionic
Undecided
Unassigned
Focal
Undecided
Unassigned
Groovy
Undecided
Unassigned

Bug Description

[Impact]
New shim, various upstream fixes, fixes support for ARM64, also see bionic arm64 SRU bug: LP: #1890813.

[Test case]

Roughly

https://wiki.ubuntu.com/UEFI/SecureBoot/ShimUpdateProcess/TestPlan

but I certainly don't have any clue about the maas one.

[Regression potential]
- System might not boot anymore
- System might not boot some helpers like fwupd anymore (which was a regression in ubuntu1 we fixed)
- New security bugs that make shim load unsigned stuff are of course possible too

Dimitri John Ledkov (xnox) wrote :

Windows 10 chainloading did work correctly with the new shim.

Julian Andres Klode (juliank) wrote :

Netboot worked correctly

- unsigned grub caused validation error
- unsigned shim was not loaded by OVMF
- signed shim + grub correctly loaded signed kernel, which was locked down

Julian Andres Klode (juliank) wrote :

Verified MokUtil. This should be enough to release shims into focal.

tags: removed: block-proposed
Changed in shim-signed (Ubuntu):
status: New → Fix Released
Changed in shim (Ubuntu):
status: New → Fix Released
summary: - Perform TestPlan
+ [SRU] shim 15+1552672080.a4a1fbe-0ubuntu1
Julian Andres Klode (juliank) wrote :

Repurposing for ubuntu2 :D

Changed in shim-signed (Ubuntu Focal):
status: New → In Progress
Changed in shim-signed (Ubuntu Bionic):
status: New → In Progress
summary: - [SRU] shim 15+1552672080.a4a1fbe-0ubuntu1
+ [SRU] shim 15+1552672080.a4a1fbe-0ubuntu2
Changed in shim-signed (Ubuntu Xenial):
status: New → In Progress
Changed in shim (Ubuntu Focal):
status: New → In Progress
Changed in shim (Ubuntu Bionic):
status: New → In Progress
Changed in shim (Ubuntu Xenial):
status: New → In Progress
description: updated

Hello Julian, or anyone else affected,

Accepted shim-signed into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/shim-signed/1.40.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in shim-signed (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Changed in shim (Ubuntu Focal):
status: In Progress → Fix Committed
Łukasz Zemczak (sil2100) wrote :

Hello Julian, or anyone else affected,

Accepted shim-signed into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/shim-signed/1.37~18.04.7 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in shim-signed (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic
Łukasz Zemczak (sil2100) wrote :

Hello Julian, or anyone else affected,

Accepted shim-signed into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/shim-signed/1.33.1~16.04.6 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in shim-signed (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed-xenial
Changed in shim (Ubuntu Bionic):
status: In Progress → Fix Committed
Changed in shim (Ubuntu Xenial):
status: In Progress → Fix Committed
Łukasz Zemczak (sil2100) wrote :

Along with the shim-signed SRUs, I have also accepted the related shim binary syncs (15+1552672080.a4a1fbe-0ubuntu2). Since those did not have any relevant bug links (as they're syncs from one build), they did not appear as part of this SRU - but they are.

Julian Andres Klode (juliank) wrote :

The shim-signed SRU for bionic accidentally contained the old shimx64.efi (only shimaa64.efi was updated), hence verification failed (and it built successfully against the old shim rather than FTBFS until the new one was published).

tags: added: verification-failed-bionic
removed: verification-needed-bionic
Łukasz Zemczak (sil2100) wrote :

Hello Julian, or anyone else affected,

Accepted shim-signed into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/shim-signed/1.37~18.04.8 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

tags: added: verification-needed-bionic
removed: verification-failed-bionic
Julian Andres Klode (juliank) wrote :

shim booting, desktop inside secureboot VM:

focal ✓
bionic ✓
xenial ✓

tags: added: id-5bdb8a5a8202ad5b735c45b9
Julian Andres Klode (juliank) wrote :

netboot - testing the new shim binaries against stable release grubs using PXE boot

xenial, bionic, and focal all pass the tests

netboot - booted to kernel ✓
netboot-unsigned-grub - unsigned grub rejected - "security violation" ✓
netboot-unsigned-kernel - unsigned kernel rejected / not loaded ✓

See test script. Can be run on groovy or any of the systems with the shim installed, against specified grub debs.

Julian Andres Klode (juliank) wrote :

Verified the MokManager and mokutil tests on focal

tags: added: verification-done-focal
removed: verification-needed-focal
Julian Andres Klode (juliank) wrote :

So this means focal (shim-signed 1.40.4) as done. fwupd is tracked in bug 1864223.

Julian Andres Klode (juliank) wrote :

I've not verified Windows chainloading (which xnox did for 0ubuntu1, and we only had a tiny patch on top), or MAAS, as those are not really feasible for me.

Julian Andres Klode (juliank) wrote :

Presumably the binaries work OK enough for MAAS, as they've been in groovy for quite a while now. That said, MAAS also has a lot of failures on the grub side, so verifying is probably not even possible.

Julian Andres Klode (juliank) wrote :

shim-signed/bionic=....1.37~18.04.8 is good. I coalesced some of the timeout tests with the other reset tests to reduce the number of reboots needed, and it was nicer :)

tags: added: verification-done-bionic
removed: verification-needed-bionic
Julian Andres Klode (juliank) wrote :

here's a log even for xenial, so it's visible how the tests are coalesced:

- Enroll MOK with timeout 66 - OK
- disable validation - OK
- reenable validation with timeout -1 (completes mokutil timeout test) - OK
- reset MOK - OK

This means xenial passed too, weeehh (1.33.1~16.04.6).

tags: added: verification-done verification-done-xenial
removed: verification-needed verification-needed-xenial
Julian Andres Klode (juliank) wrote :

(xnox tested chainloading windows now too)

Dimitri John Ledkov (xnox) wrote :

-device e1000,netdev=n1,bootindex=1

adding ',bootindex=1' causes the netboot to actually be used by default.

And for automating the test, it would be nice to boot to echo a message and shutdown, such that one can capture console log to verify if the boot was as expected.

Julian Andres Klode (juliank) wrote :

Sweet. Yeah that message was the plan.

It should also do stuff like mount /proc and cat /proc/cmdline and tell you secure boot state and such from inside the kernel.

Such that we check that too.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments