broken link to raphael.min.js and missing settings in conf file

[Anchal Nigam]

[Impact]
After a fresh install on 16.04 the symbolic link /usr/share/nzbget/webui/lib/raphael.min.js points a broken link. it *should* point to ../../../javascript/raphael/raphael-min.js

[Test Case]
$ sudo apt update
$ sudo apt install nzbget

* Check broken symlink:
$ ls -la --color /usr/share/nzbget/webui/lib/raphael.min.js
lrwxrwxrwx 1 root root 42 Feb 17 2016 /usr/share/nzbget/webui/lib/raphael.min.js -> ../../../javascript/raphael/raphael.min.js

$ ls -laH /usr/share/nzbget/webui/lib/raphael.min.js
ls: cannot access '/usr/share/nzbget/webui/lib/raphael.min.js': No such file or directory

* Update and check again:
$ ls -laH /usr/share/nzbget/webui/lib/raphael.min.js
-rw-r--r-- 1 root root 94617 Jul 3 21:08 /usr/share/nzbget/webui/lib/raphael.min.js

[Regression Potential]
This changes a filename so that the nzbget symlink points to an actual file. For backwards compatibility, we also make the incorrect raphael-min.js file available as another symlink, for users who might have changed nzbget to point at that. In other words, this updated raphaeljs package provildes both raphael-min.js and raphael.min.js.

If someone already created a raphael.min.js file, then installing the updated libjs-raphael would conflict with that and dpkg would complain/fail.

[Other Info]
Not at this time.

[Original Description]
After a fresh install on 16.04 the symbolic link /usr/share/nzbget/webui/lib/raphael.min.js points a broken link. it *should* point to ../../../javascript/raphael/raphael-min.js

also, the default conf file /usr/share/nzbget/webui/nzbget.conf does not have certain required settings set like WebDir and ConfigTemplate

also, this can be used as the systemd file /etc/systemd/system/nzbget.service

[Unit]
Description=NZBGet Daemon
Documentation=http://nzbget.net/Documentation
After=network.target

[Service]
User=media
Group=media
Type=forking
ExecStart=/usr/bin/nzbget -c /home/media/.nzbget.conf -D
ExecStop=/usr/bin/nzbget -Q
ExecReload=/usr/bin/nzbget -O
KillMode=process
Restart=on-failure

[Install]
WantedBy=multi-user.target

[Andreas Moog (ampelbein)]

Thanks for the report. I agree with the webdir and configtemplate in the sample nzbget configuration file.
But I can't see the missing link for raphael.js, at least on Debian the link is correct. Maybe its different on Ubuntu (I don't have an Ubuntu installation to check)?

I'll see about releasing a new debian release.

[Peter Oostewechel (peter-oostewechel)]

This also affects me on Ubuntu 16.04.

This is the directory listing of the raphael directory:

ls -la /usr/share/javascript/raphael/
total 324
drwxr-xr-x 2 root root 4096 Jul 1 22:06 .
drwxr-xr-x 20 root root 4096 Jul 1 15:55 ..
-rw-r--r-- 1 root root 221137 Jun 11 2012 raphael.js
-rw-r--r-- 1 root root 94608 Nov 29 2012 raphael-min.js
-rw-r--r-- 1 root root 4 Jun 11 2012 version.txt

[Chris Scheib (schweeb)]

I also am affected by this issue on 15.04, I have resolved it (temporarily) by modifying the symlink. I don't know when this stopped working, but I noticed it today.

####
root@bobtheskull:/usr/share/nzbget/webui/lib# ls -l /usr/share/nzbget/webui/lib/raphael.min.js
lrwxrwxrwx 1 root root 42 Jul 1 18:43 /usr/share/nzbget/webui/lib/raphael.min.js -> ../../../javascript/raphael/raphael-min.js
####
root@bobtheskull:/usr/share/nzbget/webui/lib# apt-file search raphael-min.js
icinga-web: /usr/share/icinga-web/lib/raphael/g.raphael-min.js
icinga-web: /usr/share/icinga-web/lib/raphael/raphael-min.js
libjs-raphael: /usr/share/javascript/raphael/raphael-min.js
openerp6.1-core: /usr/share/openerp/addons/web_diagram/static/lib/js/raphael-min.js
ruby-raphael-rails: /usr/share/ruby-raphael-rails/vendor/assets/javascripts/raphael-min.js
####
root@bobtheskull:/usr/share/nzbget/webui/lib# apt-file search raphael.min.js
nzbget: /usr/share/nzbget/webui/lib/raphael.min.js

[Chris Scheib (schweeb)]

excuse me, I meant 15.10.

[Andreas Moog (ampelbein)]

I had a look on why this link points to the wrong target on ubuntu. In their infinite wisdom, the Ubuntu maintainer for the raphael javascript library decided to change the name of the minified script file, breaking the symbolic link. Slow clap.

The fix is easy, make Ubuntu specific version of the package with a symlink that points to the correct filename. I don't have an Ubuntu installation ready for doing this work, so maybe someone will step up and do it. If you need help with it, you can ask me.

[Launchpad Janitor (janitor)]

This bug was fixed in the package nzbget - 17.0+dfsg-1

---------------
nzbget (17.0+dfsg-1) unstable; urgency=medium

  * New Upstream Release
  * debian/nzbget.conf:
    - Add WebDir and ConfigTemplate to sample configuration (LP: #1576471)
    - Update sample configuration file
  * debian/patches: Refresh patches
  * debian/rules: Use GnuTLS

 -- Andreas Moog <email address hidden> Sun, 31 Jul 2016 15:13:43 +0200

[fruitfrog (k-mark-a)]

simply removing the incorrect symbolic link and linking the correct file fixes the problem.

$ sudo rm /usr/share/nzbget/webui/lib/raphael.min.js
$ sudo ln -s ../../../javascript/raphael/raphael-min.js /usr/share/nzbget/webui/lib/raphael.min.js

thats all.
the NZBGET package has "raphael.min.js" with a dot while the actual file is "raphael-min.js"

[Andreas Moog (ampelbein)]

The problem is with the Ubuntu raphael package, which changed filenames without making sure that the reverse-depends still work.

[Christian Ehrhardt  (paelzer)]

As Andreas already pointed out this is due to a bad Delta, quoting from the changelog:
- debian/rules: Name raphael-min.js instead of raphael.min.js

The change (and the updates in the package) are very old: 28 Nov 2012

Unfortunately there is no reason why it is done so, if anything then to drop the uglifyjs dependency - but that should be doable otherwise.

Since we don't know how many depend on the new filename I agree to Andreas summary that adding a symlink of the right name to the current name should be a solution.

[Andreas Hasenack (ahasenack)]

Confirmed in trusty, xenial, zesty and artful.

[Launchpad Janitor (janitor)]

This bug was fixed in the package raphael - 2.1.0-1ubuntu2

---------------
raphael (2.1.0-1ubuntu2) artful; urgency=medium

  * d/links: produce the correct filename for raphael.min.js and symlink
    our previous incorrect name (raphael-min.js) to the fixed one for
    backwards compatibility reasons. (LP: #1576471)
  * d/README.Ubuntu: update its contents to reflect the current state
    of the package.
  * d/docs: actually install the README.Ubuntu file

 -- Andreas Hasenack <email address hidden> Tue, 29 Aug 2017 13:17:25 -0300

[Andreas Hasenack (ahasenack)]

Zesty is eol. Re-verifying the others, and starting an SRU.

[Andreas Hasenack (ahasenack)]

This is not worth fixing for trusty, marking it as such.

[Robie Basak (racb)]

I'm not sure this is worth fixing in Xenial either.

Can someone who actually needs a fix in Xenial (16.04) please step forward? Note that it is already fixed in Bionic (18.04) onwards.

If nobody steps forward I propose dropping the SRU due to no user impact.

[Robie Basak (racb)]

An upload of raphael to xenial-proposed has been rejected from the upload queue for the following reason: "No known user impact on Xenial; see https://bugs.launchpad.net/ubuntu/+source/nzbget/+bug/1576471/comments/14".