[ppc64-diag] package update for Marvell SATA HDD LEDs support

[bugproxy]

[SRU Justification]
Hardware enablement

[Regression potential]
Low; the code changes are limited to the LED detection, to enable LED support on a different class of system.

[Test case]
1. Install ppc64-diag on an existing supported ppc64el system.
2. Run 'usysident' and capture output.
3. Install ppc64-diag from proposed.
4. Run 'usysident' and capture output.
5. Compare the output from the two runs and confirm that it is the same.
6. Install ppc64-diag on a system with Marvell SATA LEDs.
7. Run 'usysident' and confirm that the output includes reporting of the SATA HDD LEDs.

== Comment: #0 - Mauricio Faria De Oliveira - 2016-12-16 05:10:23 ==
Hi Canonical,

Can you please update ppc64-diag with the patches
to support the Marvell HDD LEDs in the 'IBM Power
System S822LC for HPC' server?

The main target is 16.04.x. I realize that SRUs
are not suited for features, only bugs, however
since this is related to hardware support, and
16.04 is LTS, it seems we can ask/talk about it.

The commits apply cleanly, attached debdiffs for
Zesty and Xenial.

commit id/summary
(most-recent first; git-log style; ordered in debian/patches/series)

cf718b32bcbd lpd: marvell: mark the indirect-access registers as volatile
727c17f75033 lpd/test: Fix test case
22e8e4edd4c2 lpd: Check for device tree property
d88b88735bd7 lpd: Remove redundant warning message
82a6a8c966b9 lpd: Validate get_indicator_for_loc_code() return value
53f12274da2c lpd: opal: call all get_indices() in opal_get_indicator_list()
d56f7f1367bd lpd: marvell: do not exit early on empty /sys/class/leds dir (OPAL)
627287130fab lpd: marvell: handle non-unique/duplicate location codes
efb9a4df3f88 lpd: Add support for Marvell HDD LEDs on S822LC for HPC

---Additional Hardware Info---
0009:04:00.0 SATA controller [0106]: Marvell Technology Group Ltd. 88SE9235 PCIe 2.0 x2 4-port SATA 6 Gb/s Controller [1b4b:9235] (rev 11) (prog-if 01 [AHCI 1.0])
 Subsystem: IBM 88SE9235 PCIe 2.0 x2 4-port SATA 6 Gb/s Controller [1014:0612]

Machine Type = IBM Power System S822LC for HPC

== Comment: #5 - Mauricio Faria De Oliveira - 2016-12-16 05:18:12 ==
@taco-screen-team

For assignee suggestions, the recent uploaders of Ubuntu local versions were @cyphermox and @vorlon.

Thanks

[bugproxy (bugproxy)]

Default Comment by Bridge

[bugproxy (bugproxy)]

Default Comment by Bridge

[Breno Leitão (breno-leitao)]

Hi,

This bug should target both 17.04 and 16.04.

Thanks

[Mauricio Faria de Oliveira (mfo)]

Hi @vorlon,

For tracking information..

Do you expect that these patches can still make 16.04.2 GA, given the upcoming release date,
or is it more reasonable to expect a SRU update?

Thank you

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-01-11 06:33 EDT-------
Hello Mauricio,

on Debian side for Zesty's package upgrade, I would need to upgrade to latest ppc64-diag which is 2.7.3.
Most patches are in 2.7.3 but one is missing and for some already applied patches, by checking
cherry-picked ones (from the upstream), some hunks were still applying... so I'd prefer you to
have a look if you don't mind.
I've checked with Vasant and he is planning a 2.7.4 version in February.
So a plan based on 2.7.4 is tight for both Debian and Ubuntu freeze.
Mauricio, would you mind having a look at what's needed on top of 2.7.3 ?
Few things should be needed (1patch from my understanding), so it would be
easy and safe to add it to the 2.7.3 packaging, and I can push the update right away to
Debian Unstable and thus Ubuntu Zesty.
Thanks,

F.

[Steve Langasek (vorlon)]

On Wed, Jan 11, 2017 at 11:39:31AM -0000, bugproxy wrote:
> So a plan based on 2.7.4 is tight for both Debian and Ubuntu freeze.
> Mauricio, would you mind having a look at what's needed on top of 2.7.3 ?
> Few things should be needed (1patch from my understanding), so it would be
> easy and safe to add it to the 2.7.3 packaging, and I can push the update right away to
> Debian Unstable and thus Ubuntu Zesty.
> Thanks,

As this is requested for Ubuntu 16.04.2 GA, which is due in two weeks, I'll
go ahead with cherry-picking on top of 2.7.0 (xenial) / 2.7.1 (yakkety +
zesty).

[Steve Langasek (vorlon)]

IBM, please confirm that the SRU test case added to the bug description is suitable. We will want someone with access to this Marvell hardware to run the test case, so that we can verify that the SRU addresses the problem.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ppc64-diag - 2.7.1-5ubuntu1

---------------
ppc64-diag (2.7.1-5ubuntu1) zesty; urgency=medium

  [ Mauricio Faria de Oliveira ]
  * Add upstream patches to support Marvell HDD LEDs on S822LC for HPC
    (LP: #1650596)
    - debian/patches/marvell-leds-0001-add-support.patch
    - debian/patches/marvell-leds-0002-handle-non-unique-loc.patch
    - debian/patches/marvell-leds-0003-do-not-exit-early-sys-class-led.patch
    - debian/patches/marvell-leds-0004-opal-call-all-get_indices-in-opal_get_indicator.patch
    - debian/patches/marvell-leds-0005-validate-get-indicator-for-loc.patch
    - debian/patches/marvell-leds-0006-remove-warning.patch
    - debian/patches/marvell-leds-0007-check-for-dt-property.patch
    - debian/patches/marvell-leds-0008-fix-test-case.patch
    - debian/patches/marvell-leds-0009-volatile.patch

 -- Steve Langasek <email address hidden> Wed, 11 Jan 2017 16:21:54 +0200

[Mauricio Faria de Oliveira (mfo)]

Hi @vorlon,

> IBM, please confirm that the SRU test case added to the bug description is suitable.

Yes, steps 1-7 in the Test Case section are suitable.

> We will want someone with access to this Marvell hardware to run the test case,
> so that we can verify that the SRU addresses the problem.

Sure. I have access to such systems/hardware and can run the test case.

Thus I believe we're waiting for the SRU to land in xenial-proposed, then I can verify it.

Thank you.

[Brian Murray (brian-murray)]

Hello bugproxy, or anyone else affected,

Accepted ppc64-diag into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ppc64-diag/2.7.1-5ubuntu1~16.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-01-12 17:42 EDT-------
Verification Done with yakkety-proposed. All good. Thanks.

System without Marvell hardware (no changes):
---

Old version:

# dpkg -s ppc64-diag | grep ^Version:
Version: 2.7.0-0ubuntu3

# usysident > before 2>&1

New version:

# dpkg -s ppc64-diag | grep ^Version:
Version: 2.7.1-5ubuntu1~16.10

# usysident > after 2>&1

# wc -l before after
45 before
45 after
90 total

# diff before after
# echo $?
0
#

System with Marvell hardware (ok changes):
---

Old version:

# dpkg -s ppc64-diag | grep ^Version:
Version: 2.7.0-0ubuntu3

# usysident
#

New version:

# dpkg -s ppc64-diag | grep ^Version:
Version: 2.7.1-5ubuntu1~16.10

# usysident
-B0-T0-L0 [off]
-B0-T0-L0 [off]

Functional test (passes):

# usysident -d sda
sda is at location code -B0-T0-L0.
-B0-T0-L0 [off]

# usysident -d sdb
sdb is at location code -B0-T0-L0.
-B0-T0-L0 [off]

# usysident -d sda -s identify
sda is at location code -B0-T0-L0.
-B0-T0-L0 [on]

# usysident -d sda -s normal
sda is at location code -B0-T0-L0.
-B0-T0-L0 [off]

# usysident -d sdb -s identify
sdb is at location code -B0-T0-L0.
-B0-T0-L0 [on]

# usysident -d sdb -s normal
sdb is at location code -B0-T0-L0.
-B0-T0-L0 [off]

[Brian Murray (brian-murray)]

Hello bugproxy, or anyone else affected,

Accepted ppc64-diag into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ppc64-diag/2.7.0-0ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-01-13 08:26 EDT-------
Verification Done with xenial-proposed. All good. Thanks.

System without Marvell hardware (no changes):
---

Old version:

# dpkg -s ppc64-diag | grep ^Version:
Version: 2.7.0-0ubuntu3

# usysident > before 2>&1

New version:

# dpkg -s ppc64-diag | grep ^Version:
Version: 2.7.0-0ubuntu4

# usysident > after 2>&1

# wc -l before after
45 before
45 after
90 total

# diff before after
# echo $?
0

System with Marvell hardware (ok changes):
---

Old version:

# dpkg -s ppc64-diag | grep ^Version:
Version: 2.7.0-0ubuntu3

# usysident
#

New version:

# dpkg -s ppc64-diag | grep ^Version:
Version: 2.7.0-0ubuntu4

# usysident
-B0-T0-L0 [off]
-B0-T0-L0 [off]

Functional test (passes):

# usysident
-B0-T0-L0 [off]
-B0-T0-L0 [off]

# usysident -d sda -s identify
sda is at location code -B0-T0-L0.
-B0-T0-L0 [on]

# usysident
-B0-T0-L0 [on]
-B0-T0-L0 [off]

# usysident -d sdb -s identify
sdb is at location code -B0-T0-L0.
-B0-T0-L0 [on]

# usysident
-B0-T0-L0 [on]
-B0-T0-L0 [on]

# usysident -d sda -s normal
sda is at location code -B0-T0-L0.
-B0-T0-L0 [off]

# usysident
-B0-T0-L0 [off]
-B0-T0-L0 [on]

# usysident -d sdb -s normal
sdb is at location code -B0-T0-L0.
-B0-T0-L0 [off]

# usysident
-B0-T0-L0 [off]
-B0-T0-L0 [off]

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-01-13 14:19 EDT-------
For the record,

This has been verified in the lab, and the LEDs correctly turned on and off according to the functional test.

[Steve Langasek (vorlon)]

On Fri, Jan 13, 2017 at 07:29:36PM -0000, bugproxy wrote:
> ------- Comment From <email address hidden> 2017-01-13 14:19 EDT-------
> For the record,

> This has been verified in the lab, and the LEDs correctly turned on and
> off according to the functional test.

Can you please confirm which versions of the package you verified this with?
Did you verify for both 16.04 and 16.10?

[bugproxy (bugproxy)]

------- Comment From <email address hidden> 2017-01-16 04:57 EDT-------
Hi @vorlon,

> Can you please confirm which versions of the package you verified this with?
> Did you verify for both 16.04 and 16.10?

(In reply to comment #22)
> # dpkg -s ppc64-diag | grep ^Version:
> Version: 2.7.0-0ubuntu4

(In reply to comment #20)
> # dpkg -s ppc64-diag | grep ^Version:
> Version: 2.7.1-5ubuntu1~16.10

More details in previous comments (in Launchpad the respective comment numbers are #13 and #11).

[Launchpad Janitor (janitor)]

This bug was fixed in the package ppc64-diag - 2.7.1-5ubuntu1~16.10

---------------
ppc64-diag (2.7.1-5ubuntu1~16.10) yakkety; urgency=medium

  [ Mauricio Faria de Oliveira ]
  * Add upstream patches to support Marvell HDD LEDs on S822LC for HPC
    (LP: #1650596)
    - debian/patches/marvell-leds-0001-add-support.patch
    - debian/patches/marvell-leds-0002-handle-non-unique-loc.patch
    - debian/patches/marvell-leds-0003-do-not-exit-early-sys-class-led.patch
    - debian/patches/marvell-leds-0004-opal-call-all-get_indices-in-opal_get_indicator.patch
    - debian/patches/marvell-leds-0005-validate-get-indicator-for-loc.patch
    - debian/patches/marvell-leds-0006-remove-warning.patch
    - debian/patches/marvell-leds-0007-check-for-dt-property.patch
    - debian/patches/marvell-leds-0008-fix-test-case.patch
    - debian/patches/marvell-leds-0009-volatile.patch

 -- Steve Langasek <email address hidden> Wed, 11 Jan 2017 16:21:54 +0200

[Steve Langasek (vorlon)]

The verification of the Stable Release Update for ppc64-diag has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ppc64-diag - 2.7.0-0ubuntu4

---------------
ppc64-diag (2.7.0-0ubuntu4) xenial; urgency=medium

  [ Mauricio Faria de Oliveira ]
  * Add upstream patches to support Marvell HDD LEDs on S822LC for HPC
    (LP: #1650596)
    - debian/patches/marvell-leds-0001-add-support.patch
    - debian/patches/marvell-leds-0002-handle-non-unique-loc.patch
    - debian/patches/marvell-leds-0003-do-not-exit-early-sys-class-led.patch
    - debian/patches/marvell-leds-0004-opal-call-all-get_indices-in-opal_get_indicator.patch
    - debian/patches/marvell-leds-0005-validate-get-indicator-for-loc.patch
    - debian/patches/marvell-leds-0006-remove-warning.patch
    - debian/patches/marvell-leds-0007-check-for-dt-property.patch
    - debian/patches/marvell-leds-0008-fix-test-case.patch
    - debian/patches/marvell-leds-0009-volatile.patch

 -- Steve Langasek <email address hidden> Wed, 11 Jan 2017 16:25:37 +0200