phpquery always returns 0
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
php-defaults (Debian) |
Fix Released
|
Unknown
|
|||
php-defaults (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Nish Aravamudan | ||
Yakkety |
Fix Released
|
Undecided
|
Unassigned | ||
Zesty |
Fix Released
|
Undecided
|
Unassigned | ||
Artful |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
* various PHP postinst uses php-defaults' scripts for determing what actions to perform.
* The phpquery script has an error that does not propogate state correctly.
[Test Case]
[Regression Potential]
* This is pure bug-fix backport from version 44 (in yakkety and on) to xenial. The regression potential is very low; most likely people were seeing the issue as reported in this bug and manually, e.g., disabling modules again on every upgrade. This will actually avoid having to do that.
---
In the course of diagnosing an issue with a PHP module (xdebug in this case) kept re-enabling itself during upgrades of libapache2-
1. libapache2-
2. php-maintscript
3. phpquery calls its own action() function, which initializes the $ret variable to 0
4. phpquery action() calls into various other functions in the script, and sets the $ret variable based on their returns
5. phpquery action() returns 0
6. php-maintscript
Source link for xenial: https:/
the following addition to action() after the esac is necessary to bubble up the internal functions' returns:
return $ret
Changed in php-defaults (Ubuntu Yakkety): | |
status: | New → Fix Released |
Changed in php-defaults (Ubuntu Zesty): | |
status: | New → Fix Released |
Changed in php-defaults (Ubuntu Artful): | |
status: | New → Fix Released |
Changed in php-defaults (Debian): | |
status: | Unknown → Fix Released |
description: | updated |
Hello and thank you for filing this bug report! This was fixed in src:php-defaults 44, which is in Y and on. I will submit a SRU for this to X.