| 2017-12-01 19:40:29 |
Ryan Harper |
bug |
|
|
added bug |
| 2017-12-01 19:41:38 |
Ryan Harper |
attachment added |
|
add_bridge_port_priority.patch https://bugs.launchpad.net/ubuntu/+source/nplan/+bug/1735821/+attachment/5017168/+files/add_bridge_port_priority.patch |
|
| 2017-12-01 20:13:50 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~raharper/cloud-init/+git/cloud-init/+merge/334611 |
|
| 2017-12-01 20:22:26 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2017-12-01 20:22:32 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Review Team |
| 2018-01-23 19:58:49 |
Mathieu Trudel-Lapierre |
nplan (Ubuntu): status |
New |
Fix Committed |
|
| 2018-02-16 19:43:48 |
Launchpad Janitor |
nplan (Ubuntu): status |
Fix Committed |
Fix Released |
|
| 2018-02-26 15:16:10 |
Mathieu Trudel-Lapierre |
nominated for series |
|
Ubuntu Xenial |
|
| 2018-02-26 15:16:10 |
Mathieu Trudel-Lapierre |
bug task added |
|
nplan (Ubuntu Xenial) |
|
| 2018-02-26 15:16:10 |
Mathieu Trudel-Lapierre |
nominated for series |
|
Ubuntu Artful |
|
| 2018-02-26 15:16:10 |
Mathieu Trudel-Lapierre |
bug task added |
|
nplan (Ubuntu Artful) |
|
| 2018-02-26 15:38:14 |
Mathieu Trudel-Lapierre |
description |
Now that systemd supports port-priority for bridges (LP: #1668347)
netplan should handle port-priority like it does path-cost.
1) % lsb_release -rd
Description: Ubuntu 16.04.3 LTS
Release: 16.04
1) # lsb_release -rd
Description: Ubuntu Bionic Beaver (development branch)
Release: 18.04
2) # apt-cache policy nplan
nplan:
Installed: 0.30
Candidate: 0.32
Version table:
0.32 500
500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages
*** 0.30 100
100 /var/lib/dpkg/status
3) netplan generate renders a networkd .network file which has [Bridge] section including Priority value set on each of the bridge ports specified
4) netplan fails to parse the input yaml with
Sample config that should parse:
% cat br-pp.yaml
network:
version: 2
ethernets:
eth0:
match:
macaddress: '52:54:00:12:34:04'
bridges:
br0:
addresses:
- 192.168.14.2/24
interfaces:
- eth0
parameters:
path-cost:
eth0: 50
priority: 22
port-priority:
eth0: 14
% netplan generate
Error in network definition br-pp.yaml line 13 column 16: unknown key port-priority
If fixed, then I would expect a /run/systemd/network/10-netplan-eth0.network that looks like
[Match]
MACAddress=52:54:00:12:34:00
Name=eth0
[Network]
Bridge=br0
LinkLocalAddressing=no
IPv6AcceptRA=no
[Bridge]
Cost=50
Priority=14 |
[Impact]
Users of netplan configuring any bridge. Port priority is a very common setting to change when setting up bridge devices that might have multiple interfaces.
[Test case]
1) Write a netplan configuration:
network:
version: 2
ethernets:
eth0:
match:
name: eth0
bridges:
br0:
addresses:
- 192.168.14.2/24
interfaces:
- eth0
parameters:
path-cost:
eth0: 50
priority: 22
port-priority:
eth0: 14
2) Run 'sudo netplan apply'
3) Validate that the config generated by netplan is correct:
In /run/systemd/network/10-netplan-eth0.network:
[...]
[Bridge]
[...]
Priority=14
4) Validate that the port-priority value for the bridge has been correctly set:
$ cat /sys/class/net/mybr/brif/eth0/priority
[Regression potential]
This might impact STP behavior, such that while the port priority for a bridge changes, the general network topology might change -- this may lead to loss of connectivity on the bridge itself or on other devices on the network, invalid packet traffic (packets showing up where they should not), etc.
---
Now that systemd supports port-priority for bridges (LP: #1668347)
netplan should handle port-priority like it does path-cost.
1) % lsb_release -rd
Description: Ubuntu 16.04.3 LTS
Release: 16.04
1) # lsb_release -rd
Description: Ubuntu Bionic Beaver (development branch)
Release: 18.04
2) # apt-cache policy nplan
nplan:
Installed: 0.30
Candidate: 0.32
Version table:
0.32 500
500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages
*** 0.30 100
100 /var/lib/dpkg/status
3) netplan generate renders a networkd .network file which has [Bridge] section including Priority value set on each of the bridge ports specified
4) netplan fails to parse the input yaml with
Sample config that should parse:
% cat br-pp.yaml
network:
version: 2
ethernets:
eth0:
match:
macaddress: '52:54:00:12:34:04'
bridges:
br0:
addresses:
- 192.168.14.2/24
interfaces:
- eth0
parameters:
path-cost:
eth0: 50
priority: 22
port-priority:
eth0: 14
% netplan generate
Error in network definition br-pp.yaml line 13 column 16: unknown key port-priority
If fixed, then I would expect a /run/systemd/network/10-netplan-eth0.network that looks like
[Match]
MACAddress=52:54:00:12:34:00
Name=eth0
[Network]
Bridge=br0
LinkLocalAddressing=no
IPv6AcceptRA=no
[Bridge]
Cost=50
Priority=14 |
|
| 2018-02-28 00:55:28 |
Chris Halse Rogers |
nplan (Ubuntu Artful): status |
New |
Fix Committed |
|
| 2018-02-28 00:55:30 |
Chris Halse Rogers |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2018-02-28 00:55:32 |
Chris Halse Rogers |
bug |
|
|
added subscriber SRU Verification |
| 2018-02-28 00:55:39 |
Chris Halse Rogers |
tags |
patch |
patch verification-needed verification-needed-artful |
|
| 2018-03-05 13:16:15 |
Łukasz Zemczak |
nplan (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2018-03-05 13:17:54 |
Łukasz Zemczak |
tags |
patch verification-needed verification-needed-artful |
patch verification-done-xenial verification-needed verification-needed-artful |
|
| 2018-03-05 13:19:42 |
Łukasz Zemczak |
tags |
patch verification-done-xenial verification-needed verification-needed-artful |
patch verification-needed verification-needed-artful verification-needed-xenial |
|
| 2018-03-16 17:22:22 |
Scott Moser |
nplan (Ubuntu): importance |
Undecided |
Medium |
|
| 2018-03-16 17:22:24 |
Scott Moser |
nplan (Ubuntu Xenial): importance |
Undecided |
Medium |
|
| 2018-03-16 17:22:26 |
Scott Moser |
nplan (Ubuntu Artful): importance |
Undecided |
Medium |
|
| 2018-03-16 17:23:09 |
Scott Moser |
bug task added |
|
cloud-init |
|
| 2018-03-16 17:23:16 |
Scott Moser |
cloud-init: status |
New |
Confirmed |
|
| 2018-03-16 17:23:19 |
Scott Moser |
cloud-init: importance |
Undecided |
Medium |
|
| 2018-03-16 18:00:16 |
Scott Moser |
cloud-init: status |
Confirmed |
Fix Committed |
|
| 2018-03-16 21:49:56 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/cloud-init/+git/cloud-init/+merge/341552 |
|
| 2018-03-19 16:05:37 |
Mathieu Trudel-Lapierre |
tags |
patch verification-needed verification-needed-artful verification-needed-xenial |
verification-done-artful verification-done-xenial |
|
| 2018-03-27 20:55:21 |
Chad Smith |
cloud-init: status |
Fix Committed |
Fix Released |
|
| 2018-04-09 06:58:46 |
MOHAMMED FAHAD MUSHAHID |
nplan (Ubuntu): assignee |
|
MOHAMMED FAHAD MUSHAHID (89mfahad) |
|
| 2018-04-09 07:19:01 |
Julian Andres Klode |
nplan (Ubuntu): assignee |
MOHAMMED FAHAD MUSHAHID (89mfahad) |
|
|
| 2018-04-11 22:35:13 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2018-04-11 22:45:09 |
Launchpad Janitor |
nplan (Ubuntu Artful): status |
Fix Committed |
Fix Released |
|
| 2018-04-12 08:48:55 |
Launchpad Janitor |
nplan (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2023-05-11 08:57:30 |
James Falcon |
bug watch added |
|
https://github.com/canonical/cloud-init/issues/3074 |
|
