missing alembic migrations due to use of git based workflows

[James Page]

Various openstack related packages are missing required neutron database migrations due to the direct use of a git based workflow of merging upstream tags and generating orig.tar.xz directly from the git tree for packaging. This is *not* the same process as generated a sdist tarball, and as a result, files that need to reside in the python module get missed - this includes alembic migrations.

Known impacts:

  networking-odl
  vmware-nsx (bug 1574610)

A simple fix is to switch to using the upstream published release artefacts, rather than directly using git.

[James Page (james-page)]

Note that this does not impact the core neutron* packages, as these don't use the same git based workflow as Debian does, relying on git-buildpackage, upstream release artefacts and pristine-tar instead.

[James Page (james-page)]

After some discussion on #openstack-pkg on alternative approach is to ensure that the files are included in MANIFEST.in.

[Launchpad Janitor (janitor)]

This bug was fixed in the package networking-odl - 1:2.0.1~git20160926.416a5c7-0ubuntu1

---------------
networking-odl (1:2.0.1~git20160926.416a5c7-0ubuntu1) yakkety; urgency=medium

  * New upstream snapshot for OpenStack Newton.
  * d/p/0001-Include-alembic-migrations-in-module.patch: Cherry pick fix to
    ensure that alembic db migrations are included in the installed
    package (LP: #1627656).
  * d/control,rules: Switch to using ostestr for unit test execution.

 -- James Page <email address hidden> Mon, 26 Sep 2016 12:24:08 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package neutron-taas - 0.0.0+git20160926.675af77-0ubuntu1

---------------
neutron-taas (0.0.0+git20160926.675af77-0ubuntu1) yakkety; urgency=medium

  * New upstream snapshot for OpenStack Newton.
  * d/p/0001-Include-alembic-migrations-in-module.patch: Cherry pick fix to
    ensure that alembic migrations are installed as part of the module
    (LP: #1627656).

 -- James Page <email address hidden> Mon, 26 Sep 2016 12:51:34 +0100

[Launchpad Janitor (janitor)]

This bug was fixed in the package networking-l2gw - 1:1.0.0+git20160926.29cb4fe-0ubuntu1

---------------
networking-l2gw (1:1.0.0+git20160926.29cb4fe-0ubuntu1) yakkety; urgency=medium

  * New upstream snapshot for OpenStack Newton.
  * d/p/0001-Include-alembic-migrations-in-module.patch: Cherry pick fix to
    ensure that alembic migrations are included in the package (LP: #1627656).

 -- James Page <email address hidden> Mon, 26 Sep 2016 17:12:13 +0100

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/376390
Committed: https://git.openstack.org/cgit/openstack/networking-odl/commit/?id=7fd14d19106ad930f0072b45e1d3af4bd78c4b3f
Submitter: Jenkins
Branch: master

commit 7fd14d19106ad930f0072b45e1d3af4bd78c4b3f
Author: James Page <email address hidden>
Date: Mon Sep 26 11:52:32 2016 +0100

    Include alembic migrations in module

    Explicitly include all alembic data in installed python module,
    ensuring that installations directly from git repositories are
    fully functional when compared to use of sdist generated tarballs
    from tarballs.openstack.org or pypi.

    Closes-Bug: 1627656

    Change-Id: Ieb4272bdbf65e4b63a0e8d875847d299999470c2

[Bernard Cafarelli (bcafarel)]

https://review.openstack.org/#/c/376378/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-odl 3.0.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/376378
Committed: https://git.openstack.org/cgit/openstack/networking-sfc/commit/?id=a640a99527ee2c51179278823b50661bc6038278
Submitter: Jenkins
Branch: master

commit a640a99527ee2c51179278823b50661bc6038278
Author: James Page <email address hidden>
Date: Mon Sep 26 11:23:11 2016 +0100

    Include alembic migrations in module

    Explicitly include all alembic data in installed python module,
    ensuring that installations direct from git repositories are
    fully functional when compared to use of sdist generated tarballs
    from tarballs.openstack.org or pypi.

    Closes-Bug: 1627656

    Change-Id: I246672cd6a343583daa96720e433c8c0a62086fc

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/376381
Committed: https://git.openstack.org/cgit/openstack/tap-as-a-service/commit/?id=55a387744dacb837b92556d714d2b6b5bb6c0e4f
Submitter: Jenkins
Branch: master

commit 55a387744dacb837b92556d714d2b6b5bb6c0e4f
Author: James Page <email address hidden>
Date: Mon Sep 26 11:45:35 2016 +0100

    Include alembic migrations in module

    Explicitly include all alembic data in installed python module,
    ensuring that installations directly from git repositories are
    fully functional when compared to use of sdist generated tarballs
    from tarballs.openstack.org or pypi.

    Closes-Bug: 1627656

    Change-Id: I445481445b6b5c0649a95f775042ba4067e83aa3

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-sfc 4.0.0 release.

[Ricardo Noriega (rnoriega-b)]

Patch released for networking-l2gw: https://review.openstack.org/#/c/376406/
I'm setting this bug as: Fix released