| 2018-09-25 22:15:37 |
Robert C Jennings |
bug |
|
|
added bug |
| 2018-09-25 22:15:37 |
Robert C Jennings |
attachment added |
|
livecd-rootfs_2.408.37.debdiff https://bugs.launchpad.net/bugs/1794383/+attachment/5192923/+files/livecd-rootfs_2.408.37.debdiff |
|
| 2018-09-25 22:53:23 |
Steve Langasek |
description |
We use a LP build recipe that includes livecd-rootfs.
We are moving from bzr to git due to other projects moving to git.
When we import livecd-rootfs into git it does not commit empty
directories into the git tree. The livecd-build/ubuntu-
cpc/includes.chroot/etc/network/interfaces.d/ directory is dropped
when we do this import.
[Impact]
* Importing the package and committing it to a git repository
drops empty directories from the ubuntu-cpc/includes.chroot tree
* Images built in the ubuntu-cpc project drop this directory which
is a regression
[Test Case]
* Create a bare git repo,
* Pull the livecd-rootfs from xenial-updates into the repo,
* Commit the code to git
* Use the committed code (fresh clone) to build the ubuntu-cpc project
* Inspect the images to see if /etc/network/interfaces.d exists
[Regression Potential]
* Low. This create a directory if it does or doesn't exist so builds from
sources that include the empty directory should not be impacted. The
difference would be owner or permissions between the two methods (includes.chroot
and the chroot hook) and my testing with this patch has shown that to
be correct. |
We use a LP build recipe that includes livecd-rootfs.
We are moving from bzr to git due to other projects moving to git.
When we import livecd-rootfs into git it does not commit empty
directories into the git tree. The livecd-build/ubuntu-
cpc/includes.chroot/etc/network/interfaces.d/ directory is dropped
when we do this import.
Foundations team would also like to move the upstream repositories to git including for stable releases, and this change would need to be made as part of this.
[Impact]
* Importing the package and committing it to a git repository
drops empty directories from the ubuntu-cpc/includes.chroot tree
* Images built in the ubuntu-cpc project drop this directory which
is a regression
[Test Case]
* Create a bare git repo,
* Pull the livecd-rootfs from xenial-updates into the repo,
* Commit the code to git
* Use the committed code (fresh clone) to build the ubuntu-cpc project
* Inspect the images to see if /etc/network/interfaces.d exists
[Regression Potential]
* Low. This create a directory if it does or doesn't exist so builds from
sources that include the empty directory should not be impacted. The
difference would be owner or permissions between the two methods (includes.chroot
and the chroot hook) and my testing with this patch has shown that to
be correct. |
|
| 2018-09-26 01:45:22 |
Robert C Jennings |
attachment added |
|
livecd-rootfs_2.408.37.debdiff https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1794383/+attachment/5192974/+files/livecd-rootfs_2.408.37.debdiff |
|
| 2018-09-26 01:45:39 |
Robert C Jennings |
attachment removed |
livecd-rootfs_2.408.37.debdiff https://bugs.launchpad.net/ubuntu/+source/livecd-rootfs/+bug/1794383/+attachment/5192923/+files/livecd-rootfs_2.408.37.debdiff |
|
|
| 2018-09-26 02:37:51 |
Robert C Jennings |
description |
We use a LP build recipe that includes livecd-rootfs.
We are moving from bzr to git due to other projects moving to git.
When we import livecd-rootfs into git it does not commit empty
directories into the git tree. The livecd-build/ubuntu-
cpc/includes.chroot/etc/network/interfaces.d/ directory is dropped
when we do this import.
Foundations team would also like to move the upstream repositories to git including for stable releases, and this change would need to be made as part of this.
[Impact]
* Importing the package and committing it to a git repository
drops empty directories from the ubuntu-cpc/includes.chroot tree
* Images built in the ubuntu-cpc project drop this directory which
is a regression
[Test Case]
* Create a bare git repo,
* Pull the livecd-rootfs from xenial-updates into the repo,
* Commit the code to git
* Use the committed code (fresh clone) to build the ubuntu-cpc project
* Inspect the images to see if /etc/network/interfaces.d exists
[Regression Potential]
* Low. This create a directory if it does or doesn't exist so builds from
sources that include the empty directory should not be impacted. The
difference would be owner or permissions between the two methods (includes.chroot
and the chroot hook) and my testing with this patch has shown that to
be correct. |
We use a LP build recipe that includes livecd-rootfs.
We are moving from bzr to git due to other projects moving to git.
When we import livecd-rootfs into git it does not commit empty
directories into the git tree. The livecd-build/ubuntu-
cpc/includes.chroot/etc/network/interfaces.d/ directory is dropped
when we do this import.
Foundations team would also like to move the upstream repositories to git including for stable releases, and this change would need to be made as part of this.
[Impact]
* Importing the package and committing it to a git repository
drops empty directories from the ubuntu-cpc/includes.chroot tree
* Images built in the ubuntu-cpc project drop this directory which
is a regression
[Test Case]
* Create a bare git repo,
* Pull the livecd-rootfs from xenial-updates into the repo,
* Commit the code to git
* Use the committed code (fresh clone) to build the ubuntu-cpc project
* Inspect the images to see if /etc/network/interfaces.d exists
[Regression Potential]
* Low. This create a directory via dh_installdirs if it doesn't exist
already in the packaging. Builds from sources that include the
empty directory are not be impacted. The owner and permissions on
the directory are same. |
|
| 2018-09-26 03:46:44 |
Robert C Jennings |
summary |
ubuntu-cpc project: Add a hack for git empty directory handling |
ubuntu-cpc project: git empty directory handling |
|
| 2018-09-26 03:51:54 |
Launchpad Janitor |
branch linked |
|
lp:~rcj/livecd-rootfs/xenial-proposed |
|
| 2018-09-26 04:18:23 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2018-09-26 04:18:31 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Sponsors Team |
| 2018-09-26 20:45:34 |
Robie Basak |
livecd-rootfs (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2018-09-26 20:45:36 |
Robie Basak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2018-09-26 20:45:39 |
Robie Basak |
bug |
|
|
added subscriber SRU Verification |
| 2018-09-26 20:45:40 |
Robie Basak |
tags |
patch |
patch verification-needed verification-needed-xenial |
|
| 2018-09-28 15:13:03 |
Robert C Jennings |
tags |
patch verification-needed verification-needed-xenial |
patch verification-done verification-done-xenial |
|
| 2018-10-04 07:50:38 |
Launchpad Janitor |
livecd-rootfs (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2018-10-04 07:50:42 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2018-10-24 19:21:43 |
Robert C Jennings |
branch unlinked |
lp:~rcj/livecd-rootfs/xenial-proposed |
|
|
| 2018-11-03 23:41:47 |
Mathew Hodson |
bug task deleted |
livecd-rootfs (Ubuntu) |
|
|
| 2018-11-03 23:41:58 |
Mathew Hodson |
livecd-rootfs (Ubuntu Xenial): importance |
Undecided |
High |
|
