backport DIMLIB (lib/dim/) to pre-5.2 kernels
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
In Progress
|
Undecided
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Kamal Mostafa | ||
Bionic |
Fix Released
|
Undecided
|
Kamal Mostafa | ||
Disco |
Fix Released
|
Undecided
|
Kamal Mostafa |
Bug Description
The mellanox and broadcom drivers contained a "dynamic interrupt moderation" feature (as early as v5.0) which was broken out into a common kernel library 'DIMLIB' in lib/dim/ circa mainline v5.2.
Backported drivers may now need DIMLIB to be available in pre-5.2 kernels (specifically, the latest upstream version of net/ethernet/
For Disco:
Apply all the mainline commits from v5.2 which extract DIMLIB from mellanox/broadcom and wire those drivers to use DIMLIB (plus a few later DIMLIB fixes). I.e. make Disco work the same as > 5.2 kernels; no significant functional change to those drivers.
For Bionic and Xenial:
Import the lib/dim/ directory from mainline (plus a couple porting prerequisites), but do *not* make mellanox/broadcom use it. I.e. no functional change at all.
---
The mainline commits for Disco:
(newest first)
f8be17b81d44 lib/dim: Fix -Wunused-
f06d0ca45827 linux/dim: Fix overflow in dim calculation
f4915455dcf0 linux/dim: Implement RDMA adaptive moderation (DIM)
398c2b05bbee linux/dim: Add completions count to dim_sample
4f75da3666c0 linux/dim: Move implementation to .c files
8960b38932be linux/dim: Rename externally used net_dim members
e5b6ab02d7aa linux/dim: Rename net_dim_sample() to net_dim_
c002bd529d71 linux/dim: Rename externally exposed macros
449986ea9241 linux/dim: Remove "net" prefix from internal DIM members
0e58983de0d8 linux/dim: Move logic to dim.h
CVE References
Changed in linux (Ubuntu Xenial): | |
assignee: | nobody → Kamal Mostafa (kamalmostafa) |
Changed in linux (Ubuntu Disco): | |
assignee: | nobody → Kamal Mostafa (kamalmostafa) |
Changed in linux (Ubuntu Bionic): | |
assignee: | nobody → Kamal Mostafa (kamalmostafa) |
Changed in linux (Ubuntu Xenial): | |
status: | New → In Progress |
Changed in linux (Ubuntu Disco): | |
status: | New → In Progress |
Changed in linux (Ubuntu Bionic): | |
status: | New → In Progress |
description: | updated |
Changed in linux (Ubuntu Disco): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu Bionic): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu Xenial): | |
status: | In Progress → Fix Committed |
tags: |
added: verification-done-bionic verification-done-disco removed: verification-needed-bionic verification-needed-disco |
tags: |
added: verification-done-xenial removed: verification-needed-xenial |
Changed in linux (Ubuntu): | |
assignee: | Kamal Mostafa (kamalmostafa) → nobody |
https:/ /lists. ubuntu. com/archives/ kernel- team/2019- November/ 105521. html