Add support for custom protocols from rt_protos.d

Bug #1771783 reported by Nicolas Dichtel
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
iproute2 (Ubuntu)
Fix Released
Wishlist
Unassigned
Xenial
Triaged
Wishlist
Unassigned

Bug Description

FRR puts its own proto numbers when inserting a route, example:
$ ip route
[snip]
2.2.2.0/24 via 3.3.3.2 dev eth2 proto 188 metric 20

iproute2 defines some protocols, but not all:
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/tree/etc/iproute2/rt_protos

A patch has been pushed upstream so that external applications can define their protocols numbers:
719e331ff619 ("Add support for rt_protos.d")
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=719e331ff619

affects: linux (Ubuntu) → iproute2 (Ubuntu)
Revision history for this message
Khaled El Mously (kmously) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "proposed-patch-1.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Khaled El Mously (kmously) wrote :

Proposed fix for lp #1771764 and lp #1771783

Please ignore the first proposal.

Revision history for this message
Nicolas Dichtel (nicolas-dichtel) wrote :

It works on my side:

$ ./ip/ip r a 2.2.2.0/24 via 10.0.2.123 dev mgmt0 proto 188 metric 20
$ ./ip/ip r | grep 2.2.2
2.2.2.0/24 via 10.0.2.123 dev mgmt0 proto 188 metric 20
$ mkdir -p /etc/iproute2/rt_protos.d
$ echo "188 foo" > /etc/iproute2/rt_protos.d/bar.conf
$ ./ip/ip r | grep 2.2.2
2.2.2.0/24 via 10.0.2.123 dev mgmt0 proto foo metric 20

Mathew Hodson (mhodson)
tags: added: xenial
Changed in iproute2 (Ubuntu):
importance: Undecided → Wishlist
Mathew Hodson (mhodson)
tags: added: patch-accepted-upstream
Mathew Hodson (mhodson)
Changed in iproute2 (Ubuntu Xenial):
status: New → Triaged
importance: Undecided → Wishlist
Changed in iproute2 (Ubuntu):
status: New → Fix Released
summary: - iproute2: frr route protocols are not converted to string on xenial
+ Add support for custom protocols from rt_protos.d
Revision history for this message
Simon Quigley (tsimonq2) wrote :

Hello! Thank you for your contribution to Ubuntu.

If you would like this to be sponsored to Xenial, please edit the bug description to follow the SRU bug template. More information can be found here: https://wiki.ubuntu.com/StableReleaseUpdates#SRU_Bug_Template

Additionally, I see in your debdiff there are multiple areas which still need to be filled in, or removed. Such lines include:
+## Description: add some description
+## Origin/Author: add some origin or author
+## Bug: bug URL

I recommend you read the DEP-3 standard, which provides a standard way to fill out such a description: https://dep-team.pages.debian.net/deps/dep3/

I am unsubscribing the Ubuntu Sponsors Team for now, please resubscribe us when the changes have been made.

Thank you!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.