1.44.0 breaks API/ABI without transitioning
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
gjs (Ubuntu) |
Won't Fix
|
Undecided
|
Unassigned | ||
Xenial |
Won't Fix
|
Undecided
|
Unassigned |
Bug Description
gjs breaks API/ABI from 1.43.3 to 1.44.0
diff --git a/gi/interface.h b/gi/interface.h
index cdb41ab..70e71a7 100644
--- a/gi/interface.h
+++ b/gi/interface.h
@@ -33,7 +33,9 @@ G_BEGIN_DECLS
JSBool gjs_define_
- GIInterfaceInfo *info);
+ GIInterfaceInfo *info,
+ GType gtype,
+ JSObject **constructor_p);
JSBool gjs_lookup_
diff --git a/gjs/compat.h b/gjs/compat.h
index b5b617f..236ce60 100644
--- a/gjs/compat.h
+++ b/gjs/compat.h
@@ -77,8 +77,8 @@ gjs_##name#
* be at the very top.
*/
#define GJS_NATIVE_
- JSObject *object = NULL; \
- jsval *argv G_GNUC_UNUSED = JS_ARGV(context, vp);
+ JSObject *object = NULL; \
+ JS::CallArgs argv G_GNUC_UNUSED = JS::CallArgsFro
/**
* GJS_NATIVE_
@@ -101,7 +101,7 @@ gjs_##name#
* successfully.
*/
#define GJS_NATIVE_
- JS_SET_
+ argv.rval(
/**
* GJS_NATIVE_
Unblocking, Debian didnt seem interested in bumping soname, and its not a function that is likely to be used externally.