Some Dell and Lenovo systems do not work after BIOS Capsule Update

[Zorro Zhang]

[Impact]
This bug is found on Ubuntu 16.04 with fwupdate 0.5-2ubuntu4, but not found on Ubuntu 17.04 with fwupdate 9-1.

The newer version of capsule flashing tools in Ubuntu 17.04 supports the reset type from some querycapsuleinfo call：

https://github.com/rhinstaller/fwupdate/commit/f1cc489783d2054e90fa6bebc3732e7ea8bb3722

[Test Case]

== fwupdate ==
On a system with a capsule update available, perform capsule update using fwupdate. Verify the system works properly after the update.

== efivar ==
We avoided the upgrade of efivar so we don't need to validate its reverse-dependencies.

[Regression Potential]
Any vendors that relied upon the previous functionality (hardcoded to warm reset rather than querying for reset types) may have problems. This is actually a BIOS
problem in those situations.

It's unlikely that this should happen though because querying for reset types more closely aligns to the implementations that other OSes use when applying capsule updates.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Mathieu Trudel-Lapierre (cyphermox)]

Looks like newer fwupdate would need a newer efivar too; this will need a bit more testing (verifying that reverse-dependencies still build).

[Anthony Wong (anthonywong)]

Debdiff for updating fwupdate and fwupd for Xenial are attached above.

The soname version of libfwup has been increased to 1 in fwupdate 9. Since the current fwupd is depending on libfwup0 so fwupd has to be rebuilt against the new libfwup1.

Packages also available in https://launchpad.net/~canonical-hwe-team/+archive/ubuntu/ppa/+packages

[Mario Limonciello (superm1)]

@Anthony
If fwupd is spinning anyway for this SRU, it might be worthwhile to pull in this fix at the same time: https://bugs.launchpad.net/ubuntu/+source/fwupd/+bug/1642812

[Ivan Hu (ivan.hu)]

Have modified 4 required patches base on the fwupdate 0.5 for Xenial,
    - 0001-fwupdate-fix-memory-leaks-and-storing-update_table-t.patch: fwupdate:
      fix memory leaks and storing update_table to NULL pointer.
      commit 765bb7221af37ac56b11ef2253bf1bb3230ef589
    - 0001-fwupdate.efi-use-the-reset-type-from-some-querycapsu.patch: fwupdate.
      efi: use the reset type from some querycapsuleinfo call.
      commit f1cc489783d2054e90fa6bebc3732e7ea8bb3722
    - 0001-Add-a-flag-to-Allow-flashing-GUID-s-that-don-t-match.patch: Add a
      flag to Allow flashing GUID's that don't match the ESRT table.
      commit 64b4cd53baa57352fa9b2459e804c4ea50d40299
    - 0001-Make-sure-our-BootNext-entry-is-always-in-BootOrder.patch: Make sure
      our BootNext entry is always in BootOrder.
      commit ba48ac4ed7329ae5beb44063dcbd3c424e11fc46

Package available in https://launchpad.net/~ivan.hu/+archive/ubuntu/sru/+packages

[Timo Aaltonen (tjaalton)]

ivan: in series you have "update-four-patches" patch, why?

[Timo Aaltonen (tjaalton)]

An upload of fwupdate to xenial-proposed has been rejected from the upload queue for the following reason: "cruft in package, no reason to create patches in the source root".

[Anthony Wong (anthonywong)]

Fixed the above problem and packages are uploaded to https://launchpad.net/~anthonywong/+archive/ubuntu/for-review

[Timo Aaltonen (tjaalton)]

Hello Zorro, or anyone else affected,

Accepted fwupdate into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupdate/0.5-2ubuntu5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Adam Conrad (adconrad)]

Hello Zorro, or anyone else affected,

Accepted fwupdate-signed into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/fwupdate-signed/1.11.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Adam Conrad (adconrad)]

Yakkety is EOL in a week, so there's closing the Yakkety tasks given that no one has uploaded a package yet (which would likely take a week or more to get through the verification pipe).

[Ivan Hu (ivan.hu)]

I've tested it with xenail, it worked. And also asked Lenovo to help to test with their platforms with multiple capsules support. Confirmed work fine.

[Robie Basak (racb)]

Please can you confirm what package versions you tested and verified works fine?

[Launchpad Janitor (janitor)]

This bug was fixed in the package fwupdate - 0.5-2ubuntu5

---------------
fwupdate (0.5-2ubuntu5) xenial; urgency=medium

  [Ivan Hu]
  * Backport new version to Xenial. (LP: #1684034)
  * 4 Patches need to be updated, and modified from
    https://github.com/rhboot/fwupdate/
    - 0002-fwupdate-fix-memory-leaks-and-storing-update_table-t.patch: fwupdate:
      fix memory leaks and storing update_table to NULL pointer.
      commit 765bb7221af37ac56b11ef2253bf1bb3230ef589
    - 0003-fwupdate.efi-use-the-reset-type-from-some-querycapsu.patch: fwupdate.
      efi: use the reset type from some querycapsuleinfo call.
      commit f1cc489783d2054e90fa6bebc3732e7ea8bb3722
    - 0004-Add-a-flag-to-Allow-flashing-GUID-s-that-don-t-match.patch: Add a
      flag to Allow flashing GUID's that don't match the ESRT table.
      commit 64b4cd53baa57352fa9b2459e804c4ea50d40299
    - 0005-Make-sure-our-BootNext-entry-is-always-in-BootOrder.patch: Make sure
      our BootNext entry is always in BootOrder.
      commit ba48ac4ed7329ae5beb44063dcbd3c424e11fc46

 -- Anthony Wong <email address hidden> Fri, 07 Jul 2017 18:50:54 +0800

[Adam Conrad (adconrad)]

The verification of the Stable Release Update for fwupdate has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package fwupdate-signed - 1.11.1

---------------
fwupdate-signed (1.11.1) xenial; urgency=medium

  * Build-depend on fwupdate 0.5-2ubuntu5 (LP: #1684034)

 -- Adam Conrad <email address hidden> Thu, 13 Jul 2017 22:18:08 -0600